Updated pylintrc to version 3.2

Author: joachimmetz

.pylintrc

@@ -1,4 +1,4 @@
-# Pylint 3.0.x configuration file
+# Pylint 3.2.x configuration file
 #
 # This file is generated by l2tdevtools update-dependencies.py, any dependency
 # related changes should be made in dependencies.ini.
@@ -29,6 +29,7 @@ clear-cache-post-run=no
 # A comma-separated list of package or module names from where C extensions may
 # be loaded. Extensions are loading into the active Python interpreter and may
 # run arbitrary code.
+# extension-pkg-allow-list=
 extension-pkg-allow-list=pyfwps,pyfwsi,pygzipf,pylnk,pyolecf,pyregf,zstd
 
 # A comma-separated list of package or module names from where C extensions may
@@ -63,10 +64,11 @@ ignore-paths=
 # Emacs file locks
 ignore-patterns=^\.#
 
-# List of module names for which member attributes should not be checked
-# (useful for modules/projects where namespaces are manipulated during runtime
-# and thus existing member attributes cannot be deduced by static analysis). It
-# supports qualified module names, as well as Unix pattern matching.
+# List of module names for which member attributes should not be checked and
+# will not be imported (useful for modules/projects where namespaces are
+# manipulated during runtime and thus existing member attributes cannot be
+# deduced by static analysis). It supports qualified module names, as well as
+# Unix pattern matching.
 ignored-modules=
 
 # Python code to execute, usually for sys.path manipulation such as
@@ -85,11 +87,16 @@ limit-inference-results=100
 
 # List of plugins (as comma separated values of python module names) to load,
 # usually to register additional checkers.
+# load-plugins=
 load-plugins=pylint.extensions.docparams
 
 # Pickle collected data for later comparisons.
 persistent=yes
 
+# Resolve imports to .pyi stubs if available. May reduce no-member messages and
+# increase not-an-iterable messages.
+prefer-stubs=no
+
 # Minimum Python version to use for version dependent checks. Will default to
 # the version used to run pylint.
 py-version=3.12
@@ -440,7 +447,6 @@ confidence=HIGH,
 # --enable=similarities". If you want to run only the classes checker, but have
 # no Warning level messages displayed, use "--disable=all --enable=classes
 # --disable=W".
-
 disable=assignment-from-none,
         bad-inline-option,
         consider-using-f-string,
@@ -478,6 +484,7 @@ disable=assignment-from-none,
 # either give multiple identifier separated by comma (,) or put this option
 # multiple time (only on the command line, not in the configuration file where
 # it should appear only once). See also the "--disable" option for examples.
+# enable=
 enable=c-extension-no-member
 
 
@@ -510,6 +517,11 @@ max-nested-blocks=5
 # printed.
 never-returning-functions=sys.exit,argparse.parse_error
 
+# Let 'consider-using-join' be raised when the separator to join on would be
+# non-empty (resulting in expected fixes of the type: ``"- " + " -
+# ".join(items)``)
+suggest-join-with-non-empty-separator=yes
+
 
 [REPORTS]
 

dtformats/chrome_cache.py

@@ -739,10 +739,6 @@ def ParseFile(self, path):
         raise errors.ParseError(
             f'Unable to signature with error: {exception!s}')
 
-      if signature not in (DataBlockFile.SIGNATURE, IndexFile.SIGNATURE):
-        raise errors.ParseError(
-            f'Unsupported signature: 0x{signature:08x}')
-
       if signature == DataBlockFile.SIGNATURE:
         chrome_cache_file = DataBlockFile(
             debug=self._debug, output_writer=self._output_writer)
@@ -751,4 +747,7 @@ def ParseFile(self, path):
         chrome_cache_file = IndexFile(
             debug=self._debug, output_writer=self._output_writer)
 
+      else:
+        raise errors.ParseError(f'Unsupported signature: 0x{signature:08x}')
+
       chrome_cache_file.ReadFileObject(file_object)

dtformats/cpio.py

@@ -169,6 +169,8 @@ def _ReadFileEntry(self, file_object, file_offset):
       data_type_map = self._GetDataTypeMap('cpio_portable_ascii_file_entry')
     elif self.file_format in ('crc', 'newc'):
       data_type_map = self._GetDataTypeMap('cpio_new_ascii_file_entry')
+    else:
+      data_type_map = None
 
     file_entry, file_entry_data_size = self._ReadStructureFromFileObject(
         file_object, file_offset, data_type_map, 'file entry')

dtformats/fseventsd.py

@@ -80,6 +80,8 @@ def _ReadDLSRecord(self, file_object, file_offset, format_version):
       data_type_map = self._GetDataTypeMap('dls_record_v1')
     elif format_version == 2:
       data_type_map = self._GetDataTypeMap('dls_record_v2')
+    else:
+      data_type_map = None
 
     dls_record, bytes_read = self._ReadStructureFromFileObject(
         file_object, file_offset, data_type_map, 'DLS record')

dtformats/jump_list.py

@@ -135,6 +135,10 @@ def _ReadDestListEntry(self, olecf_item, stream_offset):
       data_type_map = self._GetDataTypeMap('dest_list_entry_v2')
       description = 'dest list entry v2'
 
+    else:
+      data_type_map = None
+      description = None
+
     dest_list_entry, entry_data_size = self._ReadStructureFromFileObject(
         olecf_item, stream_offset, data_type_map, description)
 

dtformats/spotlight_storedb.py

@@ -1174,6 +1174,9 @@ def _ReadMetadataAttributePageValues(
     Raises:
       ParseError: if the property page values cannot be read.
     """
+    data_type_map = None
+    debug_info = None
+
     if page_header.property_table_type == 0x00000011:
       data_type_map = self._GetDataTypeMap(
           'spotlight_store_db_property_value11')
@@ -1277,6 +1280,9 @@ def _ReadMetadataAttributeStreamsMap(
     """
     stream_values = self._ReadStreamsMap(streams_map_number)
 
+    data_type_map = None
+    debug_info = None
+
     if streams_map_number == 1:
       data_type_map = self._GetDataTypeMap(
           'spotlight_metadata_attribute_type')

dtformats/usn_journal.py

@@ -67,9 +67,7 @@ def ReadRecords(self):
 
     file_offset = 0
     while file_offset < self._file_size:
-      block_size = 4096
-      if block_size > self._file_size:
-        block_size = self._file_size
+      block_size = min(4096, self._file_size)
 
       while block_size > 60:
         usn_record_header = self._file_object.read(60)

dtformats/wmi_repository.py

@@ -1210,7 +1210,7 @@ def _ReadChildObjectsTree(self, file_object, root_node_offset):
           leaf_node = self._ReadChildObjectsTreeLeafNode(
               node_cell.data, branch_node.leaf_node_offset)
 
-          for node_offset in (
+          yield from (
               leaf_node.value_node_offset1,
               leaf_node.value_node_offset2,
               leaf_node.value_node_offset3,
@@ -1220,8 +1220,7 @@ def _ReadChildObjectsTree(self, file_object, root_node_offset):
               leaf_node.value_node_offset7,
               leaf_node.value_node_offset8,
               leaf_node.value_node_offset9,
-              leaf_node.value_node_offset10):
-            yield node_offset
+              leaf_node.value_node_offset10)
 
   # TODO: rename
   def _ReadChildObjectsTreeBranchNode(self, block_data, file_offset):
@@ -1770,9 +1769,8 @@ def _ReadClassDefinitionHierarchy(self, file_object, root_node_offset):
       for value_node_offset in self._ReadChildObjectsTree(
           file_object, root_node.sub_node_offset):
         if value_node_offset > 40:
-          for instance in self._ReadClassDefinitionHierarchy(
-              file_object, value_node_offset):
-            yield instance
+          yield from self._ReadClassDefinitionHierarchy(
+              file_object, value_node_offset)
 
     if self._debug:
       if root_node.child_objects_root_node_offset > 40:
@@ -1900,10 +1898,8 @@ def _ReadInstanceHierarchy(self, file_object, root_node_offset):
                   node_cell.data, instance_leaf_value_node.name_node_offset)
 
           if instance_leaf_value_node.instance_root_node_offset > 40:
-            for instance in self._ReadInstanceHierarchy(
-                file_object,
-                instance_leaf_value_node.instance_root_node_offset):
-              yield instance
+            yield from self._ReadInstanceHierarchy(
+                file_object, instance_leaf_value_node.instance_root_node_offset)
 
     if self._debug:
       if root_node.child_objects_list_node_offset > 40:
@@ -1956,11 +1952,10 @@ def _ReadNamespaceInstanceHierarchy(
                 node_cell.data, value_node_offset)
 
             if instance_leaf_value_node.instance_root_node_offset > 40:
-              for instance in self._ReadNamespaceInstanceHierarchy(
+              yield from self._ReadNamespaceInstanceHierarchy(
                   file_object,
                   instance_leaf_value_node.instance_root_node_offset,
-                  namespace_segments):
-                yield instance
+                  namespace_segments)
 
   def ReadClassDefinitions(self):
     """Reads class definitions.
@@ -1969,9 +1964,8 @@ def ReadClassDefinitions(self):
       Instance: instance.
     """
     if self._system_class_definition_root_node_offset > 40:
-      for instance in self._ReadClassDefinitionHierarchy(
-          self._file_object, self._system_class_definition_root_node_offset):
-        yield instance
+      yield from self._ReadClassDefinitionHierarchy(
+          self._file_object, self._system_class_definition_root_node_offset)
 
   def ReadInstances(self):
     """Reads instances.
@@ -1980,9 +1974,8 @@ def ReadInstances(self):
       Instance: instance.
     """
     if self._root_namespace_node_offset > 40:
-      for instance in self._ReadInstanceHierarchy(
-          self._file_object, self._root_namespace_node_offset):
-        yield instance
+      yield from self._ReadInstanceHierarchy(
+          self._file_object, self._root_namespace_node_offset)
 
   def ReadNamespaces(self):
     """Reads namespace instances.
@@ -1991,9 +1984,8 @@ def ReadNamespaces(self):
       Instance: instance.
     """
     if self._root_namespace_node_offset > 40:
-      for instance in self._ReadNamespaceInstanceHierarchy(
-          self._file_object, self._root_namespace_node_offset, []):
-        yield instance
+      yield from self._ReadNamespaceInstanceHierarchy(
+          self._file_object, self._root_namespace_node_offset, [])
 
   def ReadFileObject(self, file_object):
     """Reads a mappings file-like object.
@@ -3462,14 +3454,12 @@ def _GetKeysFromIndexPage(self, index_page):
       str: a CIM key.
     """
     if index_page:
-      for key in index_page.keys:
-        yield key
+      yield from index_page.keys
 
       for mapped_page_number in index_page.sub_pages:
         sub_index_page = self._GetIndexPageByMappedPageNumber(
             mapped_page_number)
-        for key in self._GetKeysFromIndexPage(sub_index_page):
-          yield key
+        yield from self._GetKeysFromIndexPage(sub_index_page)
 
   def _GetObjectsPageByMappedPageNumber(self, mapped_page_number, is_data_page):
     """Retrieves a specific objects page by mapped page number.
@@ -3942,8 +3932,7 @@ def GetInstances(self):
       Instance: an instance.
     """
     if self._repository_file:
-      for instance in self._repository_file.ReadInstances():
-        yield instance
+      yield from self._repository_file.ReadInstances()
 
     else:
       for _, object_record in self._ReadInstanceObjectRecords():
@@ -3962,15 +3951,13 @@ def GetNamespaces(self):
       Instance: an instance.
     """
     if self._repository_file:
-      for instance in self._repository_file.ReadNamespaces():
-        yield instance
+      yield from self._repository_file.ReadNamespaces()
 
     else:
       if not self._namespace_instances:
         self._ReadNamespacesFromObjectRecords()
 
-      for instance in self._namespace_instances:
-        yield instance
+      yield from self._namespace_instances
 
   def GetIndexKeys(self):
     """Retrieves the index keys.
@@ -3980,8 +3967,7 @@ def GetIndexKeys(self):
     """
     if self._index_binary_tree_file:
       index_page = self._GetIndexRootPage()
-      for key in self._GetKeysFromIndexPage(index_page):
-        yield key
+      yield from self._GetKeysFromIndexPage(index_page)
 
   # TODO: remove after debugging.
   def GetObjectRecordByKey(self, key):

dtformats/yaml_definitions_file.py

@@ -174,5 +174,4 @@ def ReadFromFile(self, path):
       DebugDefinition: a debug definition.
     """
     with open(path, 'r', encoding='utf-8') as file_object:
-      for yaml_definition in self._ReadFromFileObject(file_object):
-        yield yaml_definition
+      yield from self._ReadFromFileObject(file_object)

scripts/cpio.py

@@ -86,6 +86,8 @@ def HashFileEntries(self):
             f'Unsupported file type at offset: 0x{file_offset:08x}.\n')
         return
 
+      cpio_file_object = None
+
       if file_type == 'cpio':
         file_object.seek(file_offset, os.SEEK_SET)
         cpio_file_object = file_object

scripts/firefox_cache1.py

@@ -56,6 +56,10 @@ def Main():
   elif filename.startswith('_CACHE_00'):
     cache_file = firefox_cache1.CacheBlockFile(
         debug=options.debug, output_writer=output_writer)
+  else:
+    print('Unsupported Firefox cache version 1 file name.')
+    print('')
+    return False
 
   cache_file.Open(options.source)
 

scripts/indexeddb.py

@@ -79,6 +79,8 @@ def Main():
       value_type_string = 'del'
     elif table_entry.value_type == 1:
       value_type_string = 'val'
+    else:
+      value_type_string = 'UNKNOWN'
 
     key = ', '.join(table_entry.key_segments)
 

scripts/leveldb.py

@@ -104,6 +104,8 @@ def Main():
         value_type_string = 'del'
       elif table_entry.value_type == 1:
         value_type_string = 'val'
+      else:
+        value_type_string = 'UNKNOWN'
 
       # Print key and value without leading b
       key = repr(table_entry.key)[1:]

setup.cfg

@@ -1,6 +1,6 @@
 [metadata]
 name = dtformats
-version = 20241006
+version = 20241007
 description = Data formats (dtformats)
 long_description = dtFormats is a collection of various file formats.
 long_description_content_type = text/plain

tests/test_lib.py

@@ -1,6 +1,7 @@
 # -*- coding: utf-8 -*-
 """Shared test case."""
 
+import abc
 import os
 import unittest
 
@@ -70,3 +71,12 @@ def WriteText(self, text):
       text (str): text to write.
     """
     self.output.append(text)
+
+  @abc.abstractmethod
+  def WriteValue(self, description, value):
+    """Writes a value.
+
+    Args:
+      description (str): description.
+      value (str): value to write.
+    """

tox.ini

@@ -45,7 +45,7 @@ deps =
   -rrequirements.txt
   -rtest_requirements.txt
   docformatter
-  pylint >= 3.0.0, < 3.1.0
+  pylint >= 3.2.0, < 3.3.0
   setuptools
   yamllint >= 1.26.0
 commands =