More variant support (#2705)

Author: veloce

ios/Podfile.lock

@@ -50,61 +50,61 @@ PODS:
   - file_picker (0.0.1):
     - DKImagePickerController/PhotoGallery
     - Flutter
-  - Firebase/CoreOnly (12.8.0):
-    - FirebaseCore (~> 12.8.0)
-  - Firebase/Crashlytics (12.8.0):
+  - Firebase/CoreOnly (12.9.0):
+    - FirebaseCore (~> 12.9.0)
+  - Firebase/Crashlytics (12.9.0):
     - Firebase/CoreOnly
-    - FirebaseCrashlytics (~> 12.8.0)
-  - Firebase/Messaging (12.8.0):
+    - FirebaseCrashlytics (~> 12.9.0)
+  - Firebase/Messaging (12.9.0):
     - Firebase/CoreOnly
-    - FirebaseMessaging (~> 12.8.0)
-  - firebase_core (4.4.0):
-    - Firebase/CoreOnly (= 12.8.0)
+    - FirebaseMessaging (~> 12.9.0)
+  - firebase_core (4.5.0):
+    - Firebase/CoreOnly (= 12.9.0)
     - Flutter
-  - firebase_crashlytics (5.0.7):
-    - Firebase/Crashlytics (= 12.8.0)
+  - firebase_crashlytics (5.0.8):
+    - Firebase/Crashlytics (= 12.9.0)
     - firebase_core
     - Flutter
-  - firebase_messaging (16.1.1):
-    - Firebase/Messaging (= 12.8.0)
+  - firebase_messaging (16.1.2):
+    - Firebase/Messaging (= 12.9.0)
     - firebase_core
     - Flutter
-  - FirebaseCore (12.8.0):
-    - FirebaseCoreInternal (~> 12.8.0)
+  - FirebaseCore (12.9.0):
+    - FirebaseCoreInternal (~> 12.9.0)
     - GoogleUtilities/Environment (~> 8.1)
     - GoogleUtilities/Logger (~> 8.1)
-  - FirebaseCoreExtension (12.8.0):
-    - FirebaseCore (~> 12.8.0)
-  - FirebaseCoreInternal (12.8.0):
+  - FirebaseCoreExtension (12.9.0):
+    - FirebaseCore (~> 12.9.0)
+  - FirebaseCoreInternal (12.9.0):
     - "GoogleUtilities/NSData+zlib (~> 8.1)"
-  - FirebaseCrashlytics (12.8.0):
-    - FirebaseCore (~> 12.8.0)
-    - FirebaseInstallations (~> 12.8.0)
-    - FirebaseRemoteConfigInterop (~> 12.8.0)
-    - FirebaseSessions (~> 12.8.0)
+  - FirebaseCrashlytics (12.9.0):
+    - FirebaseCore (~> 12.9.0)
+    - FirebaseInstallations (~> 12.9.0)
+    - FirebaseRemoteConfigInterop (~> 12.9.0)
+    - FirebaseSessions (~> 12.9.0)
     - GoogleDataTransport (~> 10.1)
     - GoogleUtilities/Environment (~> 8.1)
     - nanopb (~> 3.30910.0)
     - PromisesObjC (~> 2.4)
-  - FirebaseInstallations (12.8.0):
-    - FirebaseCore (~> 12.8.0)
+  - FirebaseInstallations (12.9.0):
+    - FirebaseCore (~> 12.9.0)
     - GoogleUtilities/Environment (~> 8.1)
     - GoogleUtilities/UserDefaults (~> 8.1)
     - PromisesObjC (~> 2.4)
-  - FirebaseMessaging (12.8.0):
-    - FirebaseCore (~> 12.8.0)
-    - FirebaseInstallations (~> 12.8.0)
+  - FirebaseMessaging (12.9.0):
+    - FirebaseCore (~> 12.9.0)
+    - FirebaseInstallations (~> 12.9.0)
     - GoogleDataTransport (~> 10.1)
     - GoogleUtilities/AppDelegateSwizzler (~> 8.1)
     - GoogleUtilities/Environment (~> 8.1)
     - GoogleUtilities/Reachability (~> 8.1)
     - GoogleUtilities/UserDefaults (~> 8.1)
     - nanopb (~> 3.30910.0)
-  - FirebaseRemoteConfigInterop (12.8.0)
-  - FirebaseSessions (12.8.0):
-    - FirebaseCore (~> 12.8.0)
-    - FirebaseCoreExtension (~> 12.8.0)
-    - FirebaseInstallations (~> 12.8.0)
+  - FirebaseRemoteConfigInterop (12.9.0)
+  - FirebaseSessions (12.9.0):
+    - FirebaseCore (~> 12.9.0)
+    - FirebaseCoreExtension (~> 12.9.0)
+    - FirebaseInstallations (~> 12.9.0)
     - GoogleDataTransport (~> 10.1)
     - GoogleUtilities/Environment (~> 8.1)
     - GoogleUtilities/UserDefaults (~> 8.1)
@@ -170,9 +170,9 @@ PODS:
     - Flutter
   - receive_sharing_intent (1.8.1):
     - Flutter
-  - SDWebImage (5.21.5):
-    - SDWebImage/Core (= 5.21.5)
-  - SDWebImage/Core (5.21.5)
+  - SDWebImage (5.21.7):
+    - SDWebImage/Core (= 5.21.7)
+  - SDWebImage/Core (5.21.7)
   - share_plus (0.0.1):
     - Flutter
   - shared_preferences_foundation (0.0.1):
@@ -306,18 +306,18 @@ SPEC CHECKSUMS:
   DKImagePickerController: 946cec48c7873164274ecc4624d19e3da4c1ef3c
   DKPhotoGallery: b3834fecb755ee09a593d7c9e389d8b5d6deed60
   file_picker: a0560bc09d61de87f12d246fc47d2119e6ef37be
-  Firebase: 9a58fdbc9d8655ed7b79a19cf9690bb007d3d46d
-  firebase_core: ee30637e6744af8e0c12a6a1e8a9718506ec2398
-  firebase_crashlytics: 28b8f39df8104131376393e6af658b8b77dd120f
-  firebase_messaging: 343de01a8d3e18b60df0c6d37f7174c44ae38e02
-  FirebaseCore: 0dbad74bda10b8fb9ca34ad8f375fb9dd3ebef7c
-  FirebaseCoreExtension: 6605938d51f765d8b18bfcafd2085276a252bee2
-  FirebaseCoreInternal: fe5fa466aeb314787093a7dce9f0beeaad5a2a21
-  FirebaseCrashlytics: fb31c6907e5b52aa252668394d3f1ab326df1511
-  FirebaseInstallations: 6a14ab3d694ebd9f839c48d330da5547e9ca9dc0
-  FirebaseMessaging: 7f42cfd10ec64181db4e01b305a613791c8e782c
-  FirebaseRemoteConfigInterop: 869ddca16614f979e5c931ece11fbb0b8729ed41
-  FirebaseSessions: d614ca154c63dbbc6c10d6c38259c2162c4e7c9b
+  Firebase: 065f2bb395062046623036d8e6dc857bc2521d56
+  firebase_core: afac1aac13c931e0401c7e74ed1276112030efab
+  firebase_crashlytics: a316d8dddba772359d93dc38d303ed964579b7a6
+  firebase_messaging: 7cb2727feb789751fc6936bcc8e08408970e2820
+  FirebaseCore: 428912f751178b06bef0a1793effeb4a5e09a9b8
+  FirebaseCoreExtension: e911052d59cd0da237a45d706fc0f81654f035c1
+  FirebaseCoreInternal: b321eafae5362113bc182956fafc9922cfc77b72
+  FirebaseCrashlytics: 43913d587ef07beaf5db703baa61eacf9554658c
+  FirebaseInstallations: 7b64ffd006032b2b019a59b803858df5112d9eaa
+  FirebaseMessaging: 7d6cdbff969127c4151c824fe432f0e301210f15
+  FirebaseRemoteConfigInterop: 765ee19cd2bfa8e54937c8dae901eb634ad6787d
+  FirebaseSessions: a2d06fd980431fda934c7a543901aca05fc4edcc
   Flutter: cabc95a1d2626b1b06e7179b784ebcf0c0cde467
   flutter_appauth: d4abcf54856e5d8ba82ed7646ffc83245d4aa448
   flutter_local_notifications: a5a732f069baa862e728d839dd2ebb904737effb
@@ -335,7 +335,7 @@ SPEC CHECKSUMS:
   PromisesSwift: 9d77319bbe72ebf6d872900551f7eeba9bce2851
   quick_actions_ios: 500fcc11711d9f646739093395c4ae8eec25f779
   receive_sharing_intent: 222384f00ffe7e952bbfabaa9e3967cb87e5fe00
-  SDWebImage: e9c98383c7572d713c1a0d7dd2783b10599b9838
+  SDWebImage: e9fc87c1aab89a8ab1bbd74eba378c6f53be8abf
   share_plus: 50da8cb520a8f0f65671c6c6a99b3617ed10a58a
   shared_preferences_foundation: 7036424c3d8ec98dfe75ff1667cb0cd531ec82bb
   sound_effect: fa0600cdb9ebdc8ca14671fdc20418d7c223e92b

lib/src/model/analysis/analysis_controller.dart

@@ -861,10 +861,13 @@ class AnalysisController extends AsyncNotifier<AnalysisState>
 
 @freezed
 sealed class AnalysisState
-    with _$AnalysisState
+    with _$AnalysisState, AnalysisExplosionMixin
     implements EvaluationMixinState, CommonAnalysisState {
   const AnalysisState._();
 
+  @override
+  ViewRoot get analysisRoot => root;
+
   const factory AnalysisState({
     /// The ID of the game if it's a lichess game.
     required GameId? gameId,

lib/src/model/analysis/common_analysis_state.dart

@@ -1,7 +1,10 @@
+import 'package:collection/collection.dart';
 import 'package:dartchess/dartchess.dart';
 import 'package:fast_immutable_collections/fast_immutable_collections.dart';
 import 'package:lichess_mobile/src/model/common/chess.dart';
 import 'package:lichess_mobile/src/model/common/eval.dart';
+import 'package:lichess_mobile/src/model/common/node.dart';
+import 'package:lichess_mobile/src/model/common/uci.dart';
 import 'package:lichess_mobile/src/model/engine/evaluation_preferences.dart';
 
 /// Interface for Analysis's State.
@@ -29,6 +32,40 @@ abstract class CommonAnalysisState {
 
   /// Possible promotion move to be played.
   NormalMove? get promotionMove;
+
+  /// Squares that should have an atomic explosion animation after the last move.
+  ///
+  /// Returns `null` if the variant is not atomic, there is no last move, or the
+  /// last move was not a capture (no explosion occurs).
+  ISet<Square>? get explosionSquares;
+}
+
+/// Mixin that computes [CommonAnalysisState.explosionSquares] for states that
+/// have a position tree ([ViewRoot]) and a current path ([UciPath]).
+///
+/// The mixin walks up one step in the tree to find the position **before** the
+/// last move, then delegates to dartchess's [Atomic.explosionSquares].
+mixin AnalysisExplosionMixin implements CommonAnalysisState {
+  /// The tree root used to find the parent position.
+  ///
+  /// Return `null` if the tree is not available (e.g. illegal starting
+  /// position), in which case no explosion will be shown.
+  ViewRoot? get analysisRoot;
+
+  /// The path of the current node inside [analysisRoot].
+  UciPath get currentPath;
+
+  @override
+  ISet<Square>? get explosionSquares {
+    if (variant != Variant.atomic || lastMove == null || currentPath.isEmpty) return null;
+    final root = analysisRoot;
+    if (root == null) return null;
+    final parentPos =
+        root.branchesOn(currentPath.penultimate).lastOrNull?.position ?? root.position;
+    if (parentPos is! Atomic) return null;
+    final squareSet = parentPos.explosionSquares(lastMove!);
+    return squareSet.isEmpty ? null : squareSet.squares.toISet();
+  }
 }
 
 /// Interface for Analysis's current node.

lib/src/model/analysis/retro_controller.dart

@@ -138,6 +138,7 @@ class RetroController extends AsyncNotifier<RetroState> with EngineEvaluationMix
         currentNode: RetroCurrentNode.fromNode(_root),
         variant: _game.meta.variant,
         currentPath: UciPath.empty,
+        root: _root.view,
         evaluationContext: EvaluationContext(
           id: options.id,
           variant: _game.meta.variant,
@@ -229,6 +230,7 @@ class RetroController extends AsyncNotifier<RetroState> with EngineEvaluationMix
       currentNode: RetroCurrentNode.fromNode(mistakes.firstOrNull?.branch.branch ?? _root),
       lastMove: mistakes.firstOrNull?.branch.sanMove.move,
       variant: _game.meta.variant,
+      root: _root.view,
       evaluationContext: EvaluationContext(
         id: options.id,
         variant: _game.meta.variant,
@@ -370,6 +372,7 @@ class RetroController extends AsyncNotifier<RetroState> with EngineEvaluationMix
           currentNode: RetroCurrentNode.fromNode(currentNode),
           lastMove: currentNode.sanMove.move,
           promotionMove: null,
+          root: isNavigating ? state.root : _root.view,
         ),
       );
     } else {
@@ -379,6 +382,7 @@ class RetroController extends AsyncNotifier<RetroState> with EngineEvaluationMix
           currentNode: RetroCurrentNode.fromNode(currentNode),
           lastMove: null,
           promotionMove: null,
+          root: isNavigating ? state.root : _root.view,
         ),
       );
     }
@@ -485,7 +489,9 @@ class RetroController extends AsyncNotifier<RetroState> with EngineEvaluationMix
 enum RetroFeedback { findMove, evalMove, correct, incorrect, viewingSolution, done }
 
 @freezed
-sealed class RetroState with _$RetroState implements EvaluationMixinState, CommonAnalysisState {
+sealed class RetroState
+    with _$RetroState, AnalysisExplosionMixin
+    implements EvaluationMixinState, CommonAnalysisState {
   const RetroState._();
 
   const factory RetroState({
@@ -502,6 +508,7 @@ sealed class RetroState with _$RetroState implements EvaluationMixinState, Commo
     required Variant variant,
     required UciPath currentPath,
     required EvaluationContext evaluationContext,
+    required ViewRoot root,
     DateTime? evalRequestedAt,
     Move? lastMove,
     NormalMove? promotionMove,
@@ -526,6 +533,9 @@ sealed class RetroState with _$RetroState implements EvaluationMixinState, Commo
   @override
   Position get currentPosition => currentNode.position;
 
+  @override
+  ViewRoot get analysisRoot => root;
+
   @override
   bool isEngineAvailable(EngineEvaluationPrefState prefs) => true;
 

lib/src/model/broadcast/broadcast_analysis_controller.dart

@@ -556,10 +556,13 @@ class BroadcastAnalysisController extends AsyncNotifier<BroadcastAnalysisState>
 
 @freezed
 sealed class BroadcastAnalysisState
-    with _$BroadcastAnalysisState
+    with _$BroadcastAnalysisState, AnalysisExplosionMixin
     implements EvaluationMixinState, CommonAnalysisState {
   const BroadcastAnalysisState._();
 
+  @override
+  ViewRoot get analysisRoot => root;
+
   const factory BroadcastAnalysisState({
     /// Broadcast game ID
     required StringId id,

lib/src/model/common/chess.dart

@@ -90,6 +90,7 @@ const ISet<Variant> readSupportedVariants = ISetConst({
   Variant.chess960,
   Variant.fromPosition,
   Variant.antichess,
+  Variant.atomic,
   Variant.kingOfTheHill,
   Variant.threeCheck,
   Variant.racingKings,
@@ -102,6 +103,13 @@ const ISet<Variant> playSupportedVariants = ISetConst({
   Variant.standard,
   Variant.chess960,
   Variant.fromPosition,
+  Variant.antichess,
+  Variant.atomic,
+  Variant.kingOfTheHill,
+  Variant.threeCheck,
+  Variant.racingKings,
+  Variant.horde,
+  Variant.crazyhouse,
 });
 
 enum Variant {