fix: simplify deletion logic (#113)

Signed-off-by: Thomas Sedlmayer <tsedlmayer@pmsfit.de>

Author: thomassedlmayer

src/index.ts

@@ -755,23 +755,6 @@ function getDeletedEntities<T extends { id: { value: number } }>(
   }));
 }
 
-function getDeletedSceneEntities(
-  sceneEntities: PartialSceneEntity[],
-  previousFrameIds: Set<number>,
-  entityPrefix: string,
-  timestamp: Time,
-): PartialSceneEntity[] {
-  const currentIds = new Set(sceneEntities.map((entity) => entity.id));
-  const deletedIds = Array.from(previousFrameIds).filter(
-    (id) => !currentIds.has(generateSceneEntityId(entityPrefix, id)),
-  );
-  return deletedIds.map((id) => ({
-    id: generateSceneEntityId(entityPrefix, id),
-    timestamp,
-    type: SceneEntityDeletionType.MATCHING_ID,
-  }));
-}
-
 export function activate(extensionContext: ExtensionContext): void {
   preloadDynamicTextures();
 
@@ -854,25 +837,25 @@ export function activate(extensionContext: ExtensionContext): void {
       timestamp,
     );
     const deletionsLaneBoundaries = getDeletedEntities(
-      osiGroundTruthReq.lane_boundary,
+      config?.showPhysicalLanes === true ? osiGroundTruthReq.lane_boundary : [],
       state.previousLaneBoundaryIds,
       PREFIX_LANE_BOUNDARY,
       timestamp,
     );
     const deletionsLogicalLaneBoundaries = getDeletedEntities(
-      osiGroundTruthReq.logical_lane_boundary,
+      config?.showLogicalLanes === true ? osiGroundTruthReq.logical_lane_boundary : [],
       state.previousLogicalLaneBoundaryIds,
       PREFIX_LOGICAL_LANE_BOUNDARY,
       timestamp,
     );
     const deletionsLanes = getDeletedEntities(
-      osiGroundTruthReq.lane,
+      config?.showPhysicalLanes === true ? osiGroundTruthReq.lane : [],
       state.previousLaneIds,
       PREFIX_LANE,
       timestamp,
     );
     const deletionsLogicalLanes = getDeletedEntities(
-      osiGroundTruthReq.logical_lane,
+      config?.showLogicalLanes === true ? osiGroundTruthReq.logical_lane : [],
       state.previousLogicalLaneIds,
       PREFIX_LOGICAL_LANE,
       timestamp,
@@ -945,39 +928,6 @@ export function activate(extensionContext: ExtensionContext): void {
         ...logicalLanes,
       ];
 
-      // Frame clenup for scene entities
-      const deletedLaneBoundaries = getDeletedSceneEntities(
-        laneBoundaries,
-        state.previousLaneBoundaryIds,
-        PREFIX_LANE_BOUNDARY,
-        timestamp,
-      );
-      deletions.push(...deletedLaneBoundaries);
-
-      const deletedLogicalLaneBoundaries = getDeletedSceneEntities(
-        logicalLaneBoundaries,
-        state.previousLogicalLaneBoundaryIds,
-        PREFIX_LOGICAL_LANE_BOUNDARY,
-        timestamp,
-      );
-      deletions.push(...deletedLogicalLaneBoundaries);
-
-      const deletedLanes = getDeletedSceneEntities(
-        lanes,
-        state.previousLaneIds,
-        PREFIX_LANE,
-        timestamp,
-      );
-      deletions.push(...deletedLanes);
-
-      const deletedLogicalLanes = getDeletedSceneEntities(
-        logicalLanes,
-        state.previousLogicalLaneIds,
-        PREFIX_LOGICAL_LANE,
-        timestamp,
-      );
-      deletions.push(...deletedLogicalLanes);
-
       // Store lane boundaries in cache
       if (caching === true && updateFlags.laneBoundaries && laneBoundaryHash) {
         laneBoundaryCache.clear(); // keep only one lane boundary in cache