Skip to content

Commit 970c706

Browse files
committed
feat: changed README file
1 parent 0cc1434 commit 970c706

2 files changed

Lines changed: 8 additions & 3 deletions

File tree

example-data/README.md

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,10 +18,11 @@ With this MCAP you can simply test stop line road marking.
1818

1919
**File Name:** MovingHostWith3DModel.mcap
2020

21-
With this MCAP you can test 3D model visualization of moving objects. To do test properly, you should copy the `models/MilkTruck.glTF` file to `/opt/models/vehicles/MilkTruck.glTF` in your file system or you should just change the base path from "Default 3D Model Path" setting in 3D panel. Also don't forget to start Lichtblick with `--allow-file-access-from-files` argument:
21+
The 3D model visualization of moving objects can be tested with this MCAP. To do so, copy the `models/MilkTruck.glTF` file to `/opt/models/vehicles/MilkTruck.glTF` or change the base path of the "Default 3D Model Path" setting in the Lichtblick 3D panel.
22+
Start Lichtblick with `--allow-file-access-from-files` argument:
2223

2324
```
2425
lichtblick --allow-file-access-from-files
2526
```
2627

27-
[Milk Truck](https://github.com/KhronosGroup/glTF-Sample-Models/tree/main/2.0/CesiumMilkTruck) model has taken from [Khronos glTF Examples](https://github.com/KhronosGroup/glTF-Sample-Models/tree/main/2.0).
28+
The [Milk Truck](https://github.com/KhronosGroup/glTF-Sample-Models/tree/main/2.0/CesiumMilkTruck) model has been taken from [Khronos glTF Examples](https://github.com/KhronosGroup/glTF-Sample-Models/tree/main/2.0).

src/index.ts

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -497,7 +497,11 @@ function buildSceneEntities(
497497
];
498498

499499
const modelPathKey = config?.defaultModelPath + obj.model_reference;
500-
if (!modelCache.has(modelPathKey) && convertPathToFileUrl(modelPathKey)) {
500+
if (
501+
!modelCache.has(modelPathKey) &&
502+
obj.model_reference.length !== 0 &&
503+
convertPathToFileUrl(modelPathKey)
504+
) {
501505
modelCache.set(modelPathKey, createModelPrimitive(obj, modelPathKey));
502506
}
503507

0 commit comments

Comments
 (0)