chore(deps): migrate to ESLint 9 and @lichtblick/eslint-plugin 2.x (#191)

* chore(deps): migrate to ESLint 9 and @lichtblick/eslint-plugin 2.x

Migrate from ESLint 8 to ESLint 9 flat config, aligning with Lichtblick v1.25.0:

- Replace .eslintrc.yaml + .eslintignore with eslint.config.mjs (flat config)
- Upgrade @lichtblick/eslint-plugin from 1.x to 2.0.7
- Upgrade eslint from 8.x to 9.x
- Remove standalone ESLint plugins now bundled in @lichtblick/eslint-plugin 2.x:
  eslint-plugin-es, eslint-plugin-filenames, eslint-plugin-import,
  eslint-plugin-jest, eslint-plugin-prettier, eslint-plugin-react,
  eslint-plugin-react-hooks, @typescript-eslint/eslint-plugin,
  @typescript-eslint/parser
- Disable import/named for TypeScript files (false positives, same as Lichtblick)

Security: resolves 3 high-severity minimatch ReDoS vulnerabilities
(GHSA-2qfj-455h-2qmm, GHSA-952p-fqcp-g8pc, GHSA-3fvg-4v2m-98jf)
that were rooted in the eslint@8 / @lichtblick/eslint-plugin@1.x dependency tree.

Audit: 23 vulnerabilities (3 High) -> 19 vulnerabilities (0 High)
Lint: 76 errors -> 73 errors (net improvement from autofix of newly detected issues)

Resolves #180

* refactor: remove unnecessary type assertions

Autofix from @typescript-eslint/no-unnecessary-type-assertion rule
newly enabled by @lichtblick/eslint-plugin 2.x. Removes redundant
`as Point3`, `as LinePrimitive`, `as GroundTruth` etc. casts and
their now-unused imports.
---------

Signed-off-by: Carlo van Driesten <carlo.van-driesten@bmw.de>

Author: jdsika

.eslintignore

@@ -0,0 +1,45 @@
+import lichtblickPlugin from "@lichtblick/eslint-plugin";
+
+export default [
+  {
+    ignores: ["dist/**", "*.js", "*.mjs", "website/**"],
+  },
+
+  ...lichtblickPlugin.configs.base,
+
+  ...lichtblickPlugin.configs.typescript.map((config) => ({
+    ...config,
+    files: ["**/*.ts", "**/*.tsx"],
+  })),
+
+  {
+    files: ["**/*.ts", "**/*.tsx"],
+    languageOptions: {
+      parserOptions: {
+        projectService: false,
+        project: "./tsconfig.json",
+        tsconfigRootDir: import.meta.dirname,
+      },
+    },
+    rules: {
+      "linebreak-style": ["error", "unix"],
+      // TypeScript validates named imports at compile time; the ESLint rule
+      // produces false positives for packages with non-standard exports.
+      "import/named": "off",
+    },
+  },
+
+  ...lichtblickPlugin.configs.react,
+
+  ...lichtblickPlugin.configs.jest.map((config) => ({
+    ...config,
+    files: ["**/*.spec.ts", "**/*.test.ts", "tests/**/*.ts"],
+    rules: {
+      ...config.rules,
+      "@typescript-eslint/no-unsafe-assignment": "off",
+      "@typescript-eslint/no-unsafe-return": "off",
+      "@typescript-eslint/no-unsafe-member-access": "off",
+      "@typescript-eslint/no-explicit-any": "off",
+    },
+  })),
+];

.eslintrc.yaml

@@ -32,25 +32,16 @@
     "@commitlint/config-conventional": "^19.6.0",
     "@foxglove/schemas": "^1.9.0",
     "@lichtblick/asam-osi-types": "^3.7.0",
-    "@lichtblick/eslint-plugin": "^1.0.2",
+    "@lichtblick/eslint-plugin": "^2.0.7",
     "@lichtblick/suite": "^1.25.0",
     "@types/jest": "^30.0.0",
     "@types/minimatch": "^5.1.2",
     "@types/react": "18.2.55",
     "@types/react-dom": "18.2.19",
-    "@typescript-eslint/eslint-plugin": "^8.48.0",
-    "@typescript-eslint/parser": "^8.48.0",
     "create-lichtblick-extension": "^1.0.0",
     "esbuild": "^0.25.0",
-    "eslint": "^8.57.0",
+    "eslint": "^9.38.0",
     "eslint-config-prettier": "9.1.0",
-    "eslint-plugin-es": "4.1.0",
-    "eslint-plugin-filenames": "1.3.2",
-    "eslint-plugin-import": "2.31.0",
-    "eslint-plugin-jest": "29.0.1",
-    "eslint-plugin-prettier": "5.5.4",
-    "eslint-plugin-react": "7.37.5",
-    "eslint-plugin-react-hooks": "4.6.0",
     "husky": "^9.1.7",
     "jest": "^29.7.0",
     "jest-environment-jsdom": "^29.7.0",

eslint.config.mjs

@@ -1,5 +1,4 @@
-import { TriangleListPrimitive, type Point3 } from "@foxglove/schemas";
-import { Time } from "@foxglove/schemas";
+import { TriangleListPrimitive, Time } from "@foxglove/schemas";
 import { LaneBoundary, LaneBoundary_Classification_Type, Lane } from "@lichtblick/asam-osi-types";
 import {
   pointListToTriangleListPrimitive,
@@ -42,7 +41,7 @@ export function buildLaneBoundaryEntity(
   // Create LaneBoundaryPoint objects using only necessary fields for rendering
   const laneBoundaryPoints = osiLaneBoundary.boundary_line.map((point) => {
     return {
-      position: { x: point.position.x, y: point.position.y, z: point.position.z } as Point3,
+      position: { x: point.position.x, y: point.position.y, z: point.position.z },
       width: point.width === 0 ? LANE_BOUNDARY_MIN_RENDERING_WIDTH : point.width, // prevent zero-width lane boundaries from being invisible
       height: point.height,
       dash: point.dash,
@@ -83,7 +82,7 @@ export function buildLaneEntity(
   for (const lb of osiLeftLaneBoundaries) {
     const laneBoundaryPoints = lb.boundary_line.map((point) => {
       return {
-        position: { x: point.position.x, y: point.position.y, z: point.position.z } as Point3,
+        position: { x: point.position.x, y: point.position.y, z: point.position.z },
         width: point.width === 0 ? LANE_BOUNDARY_MIN_RENDERING_WIDTH : point.width, // prevent zero-width lane boundaries from being invisible
         height: point.height,
         dash: point.dash,
@@ -95,7 +94,7 @@ export function buildLaneEntity(
   for (const lb of osiRightLaneBoundaries) {
     const laneBoundaryPoints = lb.boundary_line.map((point) => {
       return {
-        position: { x: point.position.x, y: point.position.y, z: point.position.z } as Point3,
+        position: { x: point.position.x, y: point.position.y, z: point.position.z },
         width: point.width === 0 ? LANE_BOUNDARY_MIN_RENDERING_WIDTH : point.width, // prevent zero-width lane boundaries from being invisible
         height: point.height,
         dash: point.dash,
@@ -109,7 +108,7 @@ export function buildLaneEntity(
   if (LANE_CENTERLINE_SHOW) {
     const centerlinePoints = osiLane.classification.centerline.map((point) => {
       return {
-        position: { x: point.x, y: point.y, z: point.z } as Point3,
+        position: { x: point.x, y: point.y, z: point.z },
         width: LANE_CENTERLINE_WIDTH,
         height: 0,
       };

package.json

@@ -1,4 +1,3 @@
-import { type Point3 } from "@foxglove/schemas";
 import { Time } from "@foxglove/schemas";
 import { LogicalLane, LogicalLaneBoundary } from "@lichtblick/asam-osi-types";
 import {
@@ -33,7 +32,7 @@ export function buildLogicalLaneBoundaryEntity(
         x: point.position.x,
         y: point.position.y,
         z: point.position.z + LOGICAL_LANE_RENDERING_HEIGHT_OFFSET,
-      } as Point3,
+      },
       width: LOGICAL_LANE_BOUNDARY_RENDERING_WIDTH,
       height: 0,
     };
@@ -74,7 +73,7 @@ export function buildLogicalLaneEntity(
           x: point.position.x,
           y: point.position.y,
           z: point.position.z + LOGICAL_LANE_RENDERING_HEIGHT_OFFSET,
-        } as Point3,
+        },
         width: LOGICAL_LANE_BOUNDARY_RENDERING_WIDTH,
         height: 0, // no need to set height for logical lanes
       };
@@ -89,7 +88,7 @@ export function buildLogicalLaneEntity(
           x: point.position.x,
           y: point.position.y,
           z: point.position.z + LOGICAL_LANE_RENDERING_HEIGHT_OFFSET,
-        } as Point3,
+        },
         width: LOGICAL_LANE_BOUNDARY_RENDERING_WIDTH,
         height: 0, // no need to set height for logical lanes
       };

src/features/lanes/index.ts

@@ -1,4 +1,4 @@
-import { Point3, Time } from "@foxglove/schemas";
+import { Time } from "@foxglove/schemas";
 import { ReferenceLine } from "@lichtblick/asam-osi-types";
 import { MarkerPoint, pointListToTriangleListPrimitive } from "@utils/index";
 import { PartialSceneEntity, generateSceneEntityId } from "@utils/scene";
@@ -19,7 +19,7 @@ export function buildReferenceLineEntity(
         x: p.world_position.x,
         y: p.world_position.y,
         z: p.world_position.z,
-      } as Point3,
+      },
       width: REFERENCE_LINE_VISUALIZATION_WIDTH,
       height: 0.0,
     }));

src/features/logicallanes/index.ts

@@ -611,5 +611,5 @@ export function pointListToDashedLinePrimitive(
     color: { r: 0, g: 0, b: 0, a: 0 },
     colors: new_colors,
     indices: [],
-  } as LinePrimitive;
+  };
 }

src/features/referenceline/index.ts

@@ -8,7 +8,6 @@ import {
   MovingObject,
   MovingObject_Type,
   MovingObject_VehicleClassification_Type,
-  ReferenceLine,
   ReferenceLine_Type,
   StationaryObject,
 } from "@lichtblick/asam-osi-types";
@@ -186,7 +185,7 @@ describe("OSI Visualizer: Message Converter", () => {
         t_axis_yaw: 0,
       },
     ],
-  } as unknown as DeepRequired<ReferenceLine>;
+  };
   const mockMessageData = {
     timestamp: {
       seconds: 0,

src/utils/primitives/lines.ts

@@ -41,7 +41,7 @@ function minimalGroundTruth(overrides?: Partial<GroundTruth>): GroundTruth {
       },
     ],
     ...overrides,
-  } as GroundTruth;
+  };
 }
 
 describe("emitAlert — GroundTruth FrameTransforms", () => {
@@ -104,7 +104,7 @@ describe("emitAlert — GroundTruth FrameTransforms", () => {
           vehicle_attributes: {},
         },
       ],
-    } as Partial<GroundTruth>);
+    });
 
     convertGroundTruthToFrameTransforms(msg, undefined, undefined, context);
 
@@ -147,7 +147,7 @@ describe("emitAlert — SensorView SceneUpdate", () => {
     const { context, emitAlert } = mockContext();
     const converter = registerSensorViewConverter();
 
-    converter({} as SensorView, dummyEvent, undefined, context);
+    converter({}, dummyEvent, undefined, context);
 
     expect(emitAlert).toHaveBeenCalledWith(
       expect.objectContaining({ severity: "warn" }),
@@ -159,7 +159,7 @@ describe("emitAlert — SensorView SceneUpdate", () => {
     const { context } = mockContext();
     const converter = registerSensorViewConverter();
 
-    const result = converter({} as SensorView, dummyEvent, undefined, context) as {
+    const result = converter({}, dummyEvent, undefined, context) as {
       deletions: unknown[];
       entities: unknown[];
     };