Skip to content

Commit 3ad906c

Browse files
committed
fix(ci): remove temp hardcoded DG_PROPOSAL_IDS
1 parent ee514bd commit 3ad906c

5 files changed

Lines changed: 8 additions & 13 deletions

File tree

.github/workflows/core_tests.yml

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -61,14 +61,12 @@ jobs:
6161
exit 1
6262
6363
- name: Prepare test environment with Brownie
64-
run: docker exec -e GITHUB_TOKEN -e ETH_RPC_URL -e ETHERSCAN_TOKEN -e DG_PROPOSAL_IDS tests-runner bash -c 'make ci-prepare-environment'
64+
run: docker exec -e GITHUB_TOKEN -e ETH_RPC_URL -e ETHERSCAN_TOKEN tests-runner bash -c 'make ci-prepare-environment'
6565
env:
6666
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
6767
ETHERSCAN_TOKEN: ${{ secrets.ETHERSCAN_TOKEN }}
68-
DG_PROPOSAL_IDS: "12"
6968

7069
- name: Run core tests
71-
run: docker exec -e CORE_TESTS_TARGET_RPC_URL -e NODE_OPTIONS -e DG_PROPOSAL_IDS tests-runner bash -c 'make test-core'
70+
run: docker exec -e CORE_TESTS_TARGET_RPC_URL -e NODE_OPTIONS tests-runner bash -c 'make test-core'
7271
env:
7372
CORE_TESTS_TARGET_RPC_URL: http://127.0.0.1:8545
74-
DG_PROPOSAL_IDS: "12"

.github/workflows/dual_governance_regression.yml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -146,7 +146,7 @@ jobs:
146146
working-directory: scripts
147147

148148
- name: Prepare test environment with Brownie
149-
run: DG_PROPOSAL_IDS=12 PYTHONPATH=$PWD poetry run brownie run scripts/ci/prepare_environment --network mfh-1
149+
run: PYTHONPATH=$PWD poetry run brownie run scripts/ci/prepare_environment --network mfh-1
150150
working-directory: scripts
151151
env:
152152
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
@@ -176,5 +176,4 @@ jobs:
176176
DEPLOY_ARTIFACT_FILE_NAME: deploy-artifact-mainnet.toml
177177
FOUNDRY_ETH_RPC_TIMEOUT: "120"
178178
FOUNDRY_THREADS: "1"
179-
DG_PROPOSAL_IDS: "12"
180179
working-directory: dual-governance

.github/workflows/large_vote_ci.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ jobs:
3636
vote: "large"
3737
rpc_url: ${{ secrets.ETH_RPC_URL }}
3838
etherscan: ${{ secrets.ETHERSCAN_TOKEN }}
39-
command: "DG_PROPOSAL_IDS=12 PYTHONPATH=$PWD make test-1/2"
39+
command: "PYTHONPATH=$PWD make test-1/2"
4040

4141
run-tests-large-2:
4242
name: Brownie fork LARGE tests 2
@@ -62,4 +62,4 @@ jobs:
6262
vote: "large"
6363
rpc_url: ${{ secrets.ETH_RPC_URL }}
6464
etherscan: ${{ secrets.ETHERSCAN_TOKEN }}
65-
command: "DG_PROPOSAL_IDS=12 PYTHONPATH=$PWD make test-2/2"
65+
command: "PYTHONPATH=$PWD make test-2/2"

.github/workflows/normal_vote_ci.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ jobs:
3232
vote: "normal"
3333
rpc_url: ${{ secrets.ETH_RPC_URL }}
3434
etherscan: ${{ secrets.ETHERSCAN_TOKEN }}
35-
command: "DG_PROPOSAL_IDS=12 PYTHONPATH=$PWD make test-1/2"
35+
command: "PYTHONPATH=$PWD make test-1/2"
3636

3737
run-tests-normal-2:
3838
name: Brownie fork NORMAL tests 2
@@ -56,4 +56,4 @@ jobs:
5656
vote: "normal"
5757
rpc_url: ${{ secrets.ETH_RPC_URL }}
5858
etherscan: ${{ secrets.ETHERSCAN_TOKEN }}
59-
command: "DG_PROPOSAL_IDS=12 PYTHONPATH=$PWD make test-2/2"
59+
command: "PYTHONPATH=$PWD make test-2/2"

.github/workflows/sm-tests.yml

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -98,16 +98,14 @@ jobs:
9898
working-directory: scripts
9999

100100
- name: Prepare test environment with Brownie
101-
run: DG_PROPOSAL_IDS=12 PYTHONPATH=$PWD poetry run brownie run scripts/ci/prepare_environment --network mfh-1
101+
run: PYTHONPATH=$PWD poetry run brownie run scripts/ci/prepare_environment --network mfh-1
102102
working-directory: scripts
103103
env:
104104
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
105105
ETHERSCAN_TOKEN: ${{ secrets.ETHERSCAN_TOKEN }}
106106

107107
- name: Run staking modules regression tests
108108
uses: lidofinance/staking-modules/.github/actions/regression-tests@develop
109-
env:
110-
DG_PROPOSAL_IDS: "12"
111109
with:
112110
repository: lidofinance/staking-modules
113111
ref: post-vote-test

0 commit comments

Comments
 (0)