fix: address review comments - dsm and locator checks

Author: chasingrainbows

scripts/vote_edf_hoodi.py

@@ -31,6 +31,7 @@
 
 from utils.agent import agent_forward
 from utils.config import (
+    AGENT,
     LIDO_LOCATOR,
     STAKING_ROUTER,
     get_deployer_account,
@@ -206,9 +207,17 @@ def _assert_state_before_vote() -> None:
     )
 
     # The vote does not change DSM guardians, so verify the new DSM is deployed
-    # with the expected guardian set before switching the protocol to it
+    # with the expected guardian set, owner and protocol links before switching
+    # the protocol to it
+    old_dsm = interface.DepositSecurityModule(OLD_DEPOSIT_SECURITY_MODULE)
     new_dsm = interface.DepositSecurityModule(NEW_DEPOSIT_SECURITY_MODULE)
     assert new_dsm.VERSION() == 5, "New DSM version is not 5"
+    assert str(new_dsm.getOwner()).lower() == AGENT.lower(), "New DSM owner is not the Agent"
+    assert str(new_dsm.STAKING_ROUTER()).lower() == STAKING_ROUTER.lower(), "New DSM staking router mismatch"
+    assert str(new_dsm.DEPOSIT_CONTRACT()).lower() == str(old_dsm.DEPOSIT_CONTRACT()).lower(), (
+        "New DSM deposit contract mismatch"
+    )
+    assert not new_dsm.isDepositsPaused(), "New DSM deposits are paused"
     assert new_dsm.getGuardianQuorum() == NEW_DSM_GUARDIAN_QUORUM, "New DSM guardian quorum mismatch"
     new_dsm_guardians = {str(g).lower() for g in new_dsm.getGuardians()}
     assert new_dsm_guardians == {g.lower() for g in NEW_DSM_GUARDIANS}, "New DSM guardian set mismatch"

tests/test_vote_edf_hoodi.py

@@ -168,6 +168,22 @@ def _raw_event_values(raw_event: dict) -> dict:
     return {item["name"]: item["value"] for item in raw_event["data"]}
 
 
+def _locator_addresses(locator) -> dict:
+    """Snapshot every zero-arg address getter the current locator implementation responds to."""
+    addresses = {}
+    for entry in locator.abi:
+        if entry.get("type") != "function" or entry.get("inputs") or entry.get("stateMutability") != "view":
+            continue
+        outputs = entry.get("outputs") or []
+        if len(outputs) != 1 or outputs[0].get("type") != "address":
+            continue
+        try:
+            addresses[entry["name"]] = str(getattr(locator, entry["name"])())
+        except Exception:
+            continue
+    return addresses
+
+
 def _group_agent_dg_events_from_receipt(receipt: TransactionReceipt, timelock: str, agent: str) -> list[EventDict]:
     """Group DG proposal events by the Agent's inner call script items (single Agent.forward)."""
     events = tx_events_from_receipt(receipt)
@@ -386,6 +402,7 @@ def test_vote(
         expected_dg_proposal_id = timelock.getProposalsCount()
 
     details = timelock.getProposalDetails(expected_dg_proposal_id)
+    locator_addresses_before = None
     if details["status"] != PROPOSAL_STATUS["executed"]:
         # =======================================================================
         # ==================== Before DG enactment checks =======================
@@ -405,6 +422,11 @@ def test_vote(
 
         assert str(locator_proxy.proxy__getImplementation()).lower() != NEW_LIDO_LOCATOR_IMPLEMENTATION.lower()
 
+        # Snapshot the full locator address registry - the upgrade must change
+        # only the depositSecurityModule entry
+        locator_addresses_before = _locator_addresses(interface.LidoLocator(LIDO_LOCATOR))
+        assert locator_addresses_before["depositSecurityModule"].lower() == OLD_DEPOSIT_SECURITY_MODULE.lower()
+
         # Old DSM v4 holds the EOA guardian set (7 guardians: 6 mapped + 1 extra Lido dev team)
         old_dsm_guardians = {str(g).lower() for g in old_dsm.getGuardians()}
         assert old_dsm_guardians == {g.lower() for g in OLD_DSM_GUARDIANS}
@@ -530,6 +552,16 @@ def test_vote(
         == NEW_DEPOSIT_SECURITY_MODULE.lower()
     )
 
+    # Every locator entry except depositSecurityModule must stay unchanged
+    if locator_addresses_before is not None:
+        locator = interface.LidoLocator(LIDO_LOCATOR)
+        for name, before_value in locator_addresses_before.items():
+            after_value = str(getattr(locator, name)())
+            if name == "depositSecurityModule":
+                assert after_value.lower() == NEW_DEPOSIT_SECURITY_MODULE.lower()
+            else:
+                assert after_value == before_value, f"Locator entry {name} changed unexpectedly"
+
     assert not staking_router.hasRole(STAKING_MODULE_UNVETTING_ROLE, OLD_DEPOSIT_SECURITY_MODULE)
     assert staking_router.hasRole(STAKING_MODULE_UNVETTING_ROLE, NEW_DEPOSIT_SECURITY_MODULE)
     assert top_up_gateway.hasRole(TOP_UP_ROLE, DEPOSITOR_BOT_DELEGATION_CONTRACT)