Skip to content

Commit 1221d4d

Browse files
ling-alan-huangbrianchandotcom
authored andcommitted
LPD-73100 SF
1 parent cbe3350 commit 1221d4d

File tree

4 files changed

+17
-15
lines changed

4 files changed

+17
-15
lines changed

modules/apps/portal-vulcan/portal-vulcan-api/src/main/java/com/liferay/portal/vulcan/util/ActionUtil.java

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -285,15 +285,13 @@ else if ((id != null) &&
285285
() -> {
286286
UriBuilder uriBuilder = uriBuilderSupplier.get();
287287

288-
if (clazz.getSuperclass(
289-
).isAnnotationPresent(
290-
Path.class
291-
)) {
288+
Class<?> superClass = clazz.getSuperclass();
292289

293-
uriBuilder = uriBuilder.path(clazz.getSuperclass());
290+
if (superClass.isAnnotationPresent(Path.class)) {
291+
uriBuilder = uriBuilder.path(superClass);
294292
}
295293

296-
uriBuilder = uriBuilder.path(clazz.getSuperclass(), methodName);
294+
uriBuilder = uriBuilder.path(superClass, methodName);
297295

298296
if (parameterId != null) {
299297
uriBuilder = uriBuilder.resolveTemplates(

modules/apps/portal-vulcan/portal-vulcan-impl/src/main/java/com/liferay/portal/vulcan/internal/openapi/contributor/FilterableFieldsOpenAPIContributor.java

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@
2525
import com.liferay.portal.vulcan.openapi.contributor.OpenAPIContributor;
2626
import com.liferay.portal.vulcan.resource.EntityModelResource;
2727

28+
import io.swagger.v3.oas.models.Components;
2829
import io.swagger.v3.oas.models.OpenAPI;
2930
import io.swagger.v3.oas.models.Operation;
3031
import io.swagger.v3.oas.models.PathItem;
@@ -61,12 +62,13 @@ public class FilterableFieldsOpenAPIContributor implements OpenAPIContributor {
6162
public void contribute(OpenAPI openAPI, OpenAPIContext openAPIContext)
6263
throws Exception {
6364

64-
if ((openAPIContext == null) || (openAPI.getComponents() == null)) {
65+
Components components = openAPI.getComponents();
66+
67+
if ((components == null) || (openAPIContext == null)) {
6568
return;
6669
}
6770

68-
Map<String, Schema> schemas = openAPI.getComponents(
69-
).getSchemas();
71+
Map<String, Schema> schemas = components.getSchemas();
7072

7173
if (MapUtil.isEmpty(schemas)) {
7274
return;

modules/apps/portal-vulcan/portal-vulcan-impl/src/main/java/com/liferay/portal/vulcan/internal/resource/OpenAPIResourceImpl.java

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -150,11 +150,10 @@ public Response getOpenAPI(
150150

151151
@Override
152152
public Map<String, Schema> getSchemas(Class<?> entityClass) {
153+
ModelConverters modelConverters = ModelConverters.getInstance();
154+
153155
return new HashMap<>(
154-
ModelConverters.getInstance(
155-
).readAll(
156-
new AnnotatedType(entityClass)
157-
));
156+
modelConverters.readAll(new AnnotatedType(entityClass)));
158157
}
159158

160159
@Override

modules/apps/portal-vulcan/portal-vulcan-test/src/testIntegration/java/com/liferay/portal/vulcan/internal/jaxrs/exception/mapper/test/ExceptionMapperTest.java

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -134,8 +134,11 @@ public void testPrincipalExceptionReturnForbidden() throws Exception {
134134
null, "/test-vulcan/testPrincipalException2",
135135
HashMapBuilder.put(
136136
"Accept-Language",
137-
LocaleUtil.getDefault(
138-
).toLanguageTag()
137+
() -> {
138+
Locale defaultLocale = LocaleUtil.getDefault();
139+
140+
return defaultLocale.toLanguageTag();
141+
}
139142
).build(),
140143
Http.Method.POST
141144
).getString(

0 commit comments

Comments
 (0)