Skip to content

🐛 [BUG] - Lightning 3 - Empty CoreTextNode attempts to load image that points to the current URL #759

@guilhermesimoes

Description

@guilhermesimoes

Description

With CanvasTextRenderer, an empty CoreTextNode (with src set to '') leads to an attempt to load an invalid image.

The WebPlatform calls convertUrlToAbsolute(src) and then converts '' to an absolute URL like https://peacocktv.com. Obviously trying to load an image from this URL then fails.

Reproduction URL

none

Reproduction steps

1. Add to the render tree an empty `CoreTextNode`.

Screenshots

Logs

Stack trace:

(anonymous)
Promise.catch
xhr.onload
XMLHttpRequest.send
(anonymous)
getImage
self.onmessage
Worker.postMessage
(anonymous) (ImageWorker.ts:231)
getImage (ImageWorker.ts:220)
loadImage (WebPlatform.ts:225)
determineImageTypeAndLoadImage (ImageTexture.ts:219)
getTextureSource (ImageTexture.ts:148)
getTextureData (Texture.ts:453)
loadTexture (CoreTextureManager.ts:307)
load (Texture.ts:320)
setRenderableOwner (Texture.ts:297)
updateTextureOwnership (CoreNode.ts:1615)
updateIsRenderable (CoreNode.ts:1590)
updateIsRenderable (CoreTextNode.ts:227)
update (CoreNode.ts:1248)
update (CoreTextNode.ts:218)
update (CoreNode.ts:1349)
update (CoreNode.ts:1349)
update (CoreNode.ts:1349)
update (CoreNode.ts:1349)
update (CoreNode.ts:1349)
update (CoreNode.ts:1349)
update (CoreNode.ts:1349)
update (CoreNode.ts:1349)
update (CoreNode.ts:1349)
drawFrame (Stage.ts:457)

Browsers

All

Browser version

All

OS

All

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions