Add LSPS2ServiceConfig::allow_client_0reserve

This setting allows LSPS2 services to open 0-reserve channels to their
clients.

Author: tankyleo

src/liquidity.rs

@@ -142,6 +142,10 @@ pub struct LSPS2ServiceConfig {
 	///
 	/// [`bLIP-52`]: https://github.com/lightning/blips/blob/master/blip-0052.md#trust-models
 	pub client_trusts_lsp: bool,
+	/// When set, clients will be allowed to spend their entire balance in the channel. This
+	/// allows clients to try to steal your funds with no financial penalty, so this should only
+	/// be set if you trust your clients.
+	pub allow_client_0reserve: bool,
 }
 
 pub(crate) struct LiquiditySourceBuilder<L: Deref>
@@ -786,22 +790,38 @@ where
 				config.channel_config.forwarding_fee_base_msat = 0;
 				config.channel_config.forwarding_fee_proportional_millionths = 0;
 
-				match self.channel_manager.create_channel(
-					their_network_key,
-					channel_amount_sats,
-					0,
-					user_channel_id,
-					None,
-					Some(config),
-				) {
+				let result = if service_config.allow_client_0reserve {
+					self.channel_manager.create_channel_to_trusted_peer_0reserve(
+						their_network_key,
+						channel_amount_sats,
+						0,
+						user_channel_id,
+						None,
+						Some(config),
+					)
+				} else {
+					self.channel_manager.create_channel(
+						their_network_key,
+						channel_amount_sats,
+						0,
+						user_channel_id,
+						None,
+						Some(config),
+					)
+				};
+
+				match result {
 					Ok(_) => {},
 					Err(e) => {
 						// TODO: We just silently fail here. Eventually we will need to remember
 						// the pending requests and regularly retry opening the channel until we
 						// succeed.
+						let zero_reserve_string =
+							if service_config.allow_client_0reserve { "0reserve " } else { "" };
 						log_error!(
 							self.logger,
-							"Failed to open LSPS2 channel to {}: {:?}",
+							"Failed to open LSPS2 {}channel to {}: {:?}",
+							zero_reserve_string,
 							their_network_key,
 							e
 						);

tests/integration_tests_rust.rs

@@ -1705,6 +1705,7 @@ async fn do_lsps2_client_service_integration(client_trusts_lsp: bool) {
 		min_channel_opening_fee_msat: 0,
 		max_client_to_self_delay: 1024,
 		client_trusts_lsp,
+		allow_client_0reserve: false,
 	};
 
 	let service_config = random_config(true);
@@ -2023,6 +2024,7 @@ async fn lsps2_client_trusts_lsp() {
 		min_channel_opening_fee_msat: 0,
 		max_client_to_self_delay: 1024,
 		client_trusts_lsp: true,
+		allow_client_0reserve: false,
 	};
 
 	let service_config = random_config(true);
@@ -2197,6 +2199,7 @@ async fn lsps2_lsp_trusts_client_but_client_does_not_claim() {
 		min_channel_opening_fee_msat: 0,
 		max_client_to_self_delay: 1024,
 		client_trusts_lsp: false,
+		allow_client_0reserve: false,
 	};
 
 	let service_config = random_config(true);