Skip to content

Commit 3afc3de

Browse files
committed
f Rename log_internal to log_given_level
1 parent c0ee016 commit 3afc3de

File tree

3 files changed

+19
-14
lines changed

3 files changed

+19
-14
lines changed

lightning-rapid-gossip-sync/src/processing.rs

+8-3
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ use lightning::ln::msgs::{
1313
use lightning::routing::gossip::{NetworkGraph, NodeAlias, NodeId};
1414
use lightning::util::logger::Logger;
1515
use lightning::util::ser::{BigSize, FixedLengthReader, Readable};
16-
use lightning::{log_debug, log_gossip, log_internal, log_trace, log_warn};
16+
use lightning::{log_debug, log_given_level, log_gossip, log_trace, log_warn};
1717

1818
use crate::{GraphSyncError, RapidGossipSync};
1919

@@ -305,7 +305,7 @@ where
305305
Ok(_) => {},
306306
Err(LightningError { action: ErrorAction::IgnoreDuplicateGossip, .. }) => {},
307307
Err(LightningError { action: ErrorAction::IgnoreAndLog(level), err }) => {
308-
log_internal!(
308+
log_given_level!(
309309
self.logger,
310310
level,
311311
"Failed to apply node announcement: {:?}",
@@ -444,7 +444,12 @@ where
444444
Ok(_) => {},
445445
Err(LightningError { action: ErrorAction::IgnoreDuplicateGossip, .. }) => {},
446446
Err(LightningError { action: ErrorAction::IgnoreAndLog(level), err }) => {
447-
log_internal!(self.logger, level, "Failed to apply channel update: {:?}", err);
447+
log_given_level!(
448+
self.logger,
449+
level,
450+
"Failed to apply channel update: {:?}",
451+
err
452+
);
448453
},
449454
Err(LightningError { action: ErrorAction::IgnoreError, .. }) => {},
450455
Err(e) => return Err(e.into()),

lightning/src/ln/peer_handler.rs

+4-4
Original file line numberDiff line numberDiff line change
@@ -1411,7 +1411,7 @@ impl<Descriptor: SocketDescriptor, CM: Deref, RM: Deref, OM: Deref, L: Deref, CM
14111411
return Err(PeerHandleError { });
14121412
},
14131413
msgs::ErrorAction::IgnoreAndLog(level) => {
1414-
log_internal!(logger, level, "Error handling {}message{}; ignoring: {}",
1414+
log_given_level!(logger, level, "Error handling {}message{}; ignoring: {}",
14151415
if level == Level::Gossip { "gossip " } else { "" },
14161416
OptionalFromDebugger(&peer_node_id), e.err);
14171417
continue
@@ -1427,7 +1427,7 @@ impl<Descriptor: SocketDescriptor, CM: Deref, RM: Deref, OM: Deref, L: Deref, CM
14271427
continue;
14281428
},
14291429
msgs::ErrorAction::SendWarningMessage { msg, log_level } => {
1430-
log_internal!(logger, log_level, "Error handling message{}; sending warning message with: {}", OptionalFromDebugger(&peer_node_id), e.err);
1430+
log_given_level!(logger, log_level, "Error handling message{}; sending warning message with: {}", OptionalFromDebugger(&peer_node_id), e.err);
14311431
self.enqueue_message($peer, &msg);
14321432
continue;
14331433
},
@@ -2385,7 +2385,7 @@ impl<Descriptor: SocketDescriptor, CM: Deref, RM: Deref, OM: Deref, L: Deref, CM
23852385
peers_to_disconnect.insert(node_id, Some(wire::Message::Warning(msg)));
23862386
},
23872387
msgs::ErrorAction::IgnoreAndLog(level) => {
2388-
log_internal!(logger, level, "Received a HandleError event to be ignored for node {}", log_pubkey!(node_id));
2388+
log_given_level!(logger, level, "Received a HandleError event to be ignored for node {}", log_pubkey!(node_id));
23892389
},
23902390
msgs::ErrorAction::IgnoreDuplicateGossip => {},
23912391
msgs::ErrorAction::IgnoreError => {
@@ -2398,7 +2398,7 @@ impl<Descriptor: SocketDescriptor, CM: Deref, RM: Deref, OM: Deref, L: Deref, CM
23982398
self.enqueue_message(&mut *get_peer_for_forwarding!(&node_id)?, msg);
23992399
},
24002400
msgs::ErrorAction::SendWarningMessage { ref msg, ref log_level } => {
2401-
log_internal!(logger, *log_level, "Handling SendWarningMessage HandleError event in peer_handler for node {} with message {}",
2401+
log_given_level!(logger, *log_level, "Handling SendWarningMessage HandleError event in peer_handler for node {} with message {}",
24022402
log_pubkey!(node_id),
24032403
msg.data);
24042404
self.enqueue_message(&mut *get_peer_for_forwarding!(&node_id)?, msg);

lightning/src/util/macro_logger.rs

+7-7
Original file line numberDiff line numberDiff line change
@@ -173,7 +173,7 @@ macro_rules! log_spendable {
173173
/// but it needs to be exported so `log_trace` etc can use it in external crates.
174174
#[doc(hidden)]
175175
#[macro_export]
176-
macro_rules! log_internal {
176+
macro_rules! log_given_level {
177177
($logger: expr, $lvl:expr, $($arg:tt)+) => (
178178
$logger.log($crate::util::logger::Record::new($lvl, None, None, format_args!($($arg)+), module_path!(), file!(), line!(), None))
179179
);
@@ -183,46 +183,46 @@ macro_rules! log_internal {
183183
#[macro_export]
184184
macro_rules! log_error {
185185
($logger: expr, $($arg:tt)*) => (
186-
$crate::log_internal!($logger, $crate::util::logger::Level::Error, $($arg)*);
186+
$crate::log_given_level!($logger, $crate::util::logger::Level::Error, $($arg)*);
187187
)
188188
}
189189

190190
/// Log at the `WARN` level.
191191
#[macro_export]
192192
macro_rules! log_warn {
193193
($logger: expr, $($arg:tt)*) => (
194-
$crate::log_internal!($logger, $crate::util::logger::Level::Warn, $($arg)*);
194+
$crate::log_given_level!($logger, $crate::util::logger::Level::Warn, $($arg)*);
195195
)
196196
}
197197

198198
/// Log at the `INFO` level.
199199
#[macro_export]
200200
macro_rules! log_info {
201201
($logger: expr, $($arg:tt)*) => (
202-
$crate::log_internal!($logger, $crate::util::logger::Level::Info, $($arg)*);
202+
$crate::log_given_level!($logger, $crate::util::logger::Level::Info, $($arg)*);
203203
)
204204
}
205205

206206
/// Log at the `DEBUG` level.
207207
#[macro_export]
208208
macro_rules! log_debug {
209209
($logger: expr, $($arg:tt)*) => (
210-
$crate::log_internal!($logger, $crate::util::logger::Level::Debug, $($arg)*);
210+
$crate::log_given_level!($logger, $crate::util::logger::Level::Debug, $($arg)*);
211211
)
212212
}
213213

214214
/// Log at the `TRACE` level.
215215
#[macro_export]
216216
macro_rules! log_trace {
217217
($logger: expr, $($arg:tt)*) => (
218-
$crate::log_internal!($logger, $crate::util::logger::Level::Trace, $($arg)*)
218+
$crate::log_given_level!($logger, $crate::util::logger::Level::Trace, $($arg)*)
219219
)
220220
}
221221

222222
/// Log at the `GOSSIP` level.
223223
#[macro_export]
224224
macro_rules! log_gossip {
225225
($logger: expr, $($arg:tt)*) => (
226-
$crate::log_internal!($logger, $crate::util::logger::Level::Gossip, $($arg)*);
226+
$crate::log_given_level!($logger, $crate::util::logger::Level::Gossip, $($arg)*);
227227
)
228228
}

0 commit comments

Comments
 (0)