f - Address more review feedback

Author: jkczyz

CHANGELOG.md

@@ -1,4 +1,4 @@
-# 0.0.107 - 2022-06-07
+# 0.0.107 - 2022-06-08
 
 ## API Updates
  * Wumbo channels are now supported and can be enabled for inbound channels
@@ -31,7 +31,6 @@
    which can be determined at runtime (#1423).
  * `lightning-invoice` crate's `utils` now accept an expiration time (#1422,
    #1474).
- * `find_route` now assumes variable-length onions by default (#1414).
  * `Event::PaymentForwarded` includes `prev_channel_id` and `next_channel_id`
    (#1419, #1475).
  * `chain::Watch::release_pending_monitor_events`' return type now associates
@@ -43,38 +42,35 @@
    ` lightning-persister`'s `FilesystemPersister` implements `KVStorePersister`
    (#1417).
  * `ChannelDetails` and `ChannelCounterparty` include fields for HTLC minimum
-   and maximum values (#1378, #1444).
- * `ProabilisticScorer` is parameterized by a `Logger`, which it uses to log
+   and maximum values, which are set in `RouteHints` by the `lightning-invoice`
+   crate (#1378, #1444).
+ * Added a `max_inbound_htlc_value_in_flight_percent_of_channel` field to
+   `ChannelHandshakeConfig`, capping the total value of outstanding inbound
+   HTLCs for a channel (#1444).
+ * `ProbabilisticScorer` is parameterized by a `Logger`, which it uses to log
    channel liquidity updates or lack thereof (#1405).
- * `ChannelDetails` has a `outbound_htlc_limit_msat` field, which should be used
-   in routing instead of `outbound_capacity_msat` (#1435).
- * `ProabilisticScorer`'s channel liquidities can be logged via
+ * `ChannelDetails` has an `outbound_htlc_limit_msat` field, which should be
+   used in routing instead of `outbound_capacity_msat` (#1435).
+ * `ProbabilisticScorer`'s channel liquidities can be logged via
    `debug_log_liquidity_stats` (#1460).
  * `BackgroundProcessor` now takes an optional `WriteableScore` which it will
    persist using the `Persister` trait's new `persist_scorer` method (#1416).
- * A `warn` message is now sent when receiving a `channel_reestablish` with an
-   old commitment transaction number rather than immediately force-closing the
-   channel (#1430).
  * Upgraded to `bitcoin` crate version 0.28.1 (#1389).
  * `ShutdownScript::new_witness_program` now takes a `WitnessVersion` instead of
    a `NonZeroU8` (#1389).
- * When a `channel_update` message is included in an onion error's `failuremsg`,
-   its message type is now encoded (#1465).
- * `Event::ChannelClosed::reason` will only be `ClosureReason::DisconnectedPeer`
-   when a peer is disconnected prior to completing funding. Thus, channels will
-   no longer be automatically force closed when the counterparty is disconnected
-   due to incompatibility (#1429).
- * `Event::FundingGenerationReady` now has a `counterparty_node_id` field, which
-   is used to pass to `ChannelManager` methods for funding, accepting, and
-   closing the channel (#1479, #1485).
+ * Channels will no longer be automatically force closed when the counterparty
+   is disconnected due to incompatibility (#1429).
+ * `ChannelManager` methods for funding, accepting, and closing channels now
+   take a `counterparty_node_id` parameter, which has also been added as a field
+   to `Event::FundingGenerationReady` (#1479, #1485).
  * `InvoicePayer::new` now takes a `Retry` enum (replacing the `RetryAttempts`
    struct), which supports both attempt- and timeout-based retrying (#1418).
  * `Score::channel_penalty_msat` takes a `ChannelUsage` struct, which contains
    the capacity as an `EffectiveCapacity` enum and any potential in-flight HTLC
    value, rather than a single `u64`. Used by `ProbabilisticScorer` for more
    accurate penalties (#1456).
- * `build_route_from_hops` is a new function useful for constructing a route to
-   probe (#1491).
+ * `build_route_from_hops` is a new function useful for constructing a `Route`
+   given a specific list of public keys (#1491).
  * `FundingLocked` message has been renamed `ChannelReady`, and related
    identifiers have been renamed accordingly (#1506).
  * `core2::io` or `std::io` (depending on feature flags `no-std` or `std`) is
@@ -88,26 +84,37 @@
    overwhelming default logging (#1421).
  * `PeerManager` supports processing messages from different peers in parallel,
    and this is taken advantage of in gossip processing (#1023).
- * `PeerManager` uses a single `Secp256k1` across all peers for reduced memory
-   usage (#1472).
+ * Reduced per-peer memory usage in `PeerManager` (#1472).
+
+## Spec Compliance
+ * `find_route` now assumes variable-length onions by default for nodes
+   supporting the feature (#1414).
+ * A `warn` message is now sent when receiving a `channel_reestablish` with an
+   old commitment transaction number rather than immediately force-closing the
+   channel (#1430).
+ * When a `channel_update` message is included in an onion error's `failuremsg`,
+   its message type is now encoded. Reading such messages is also supported
+   (#1465).
 
 ## Bug Fixes
  * Fixed a bug where crashing while persisting a `ChannelMonitorUpdate` for a
-   part of a multi-path payment would cause loss of funds due to a partial
+   part of a multi-path payment could cause loss of funds due to a partial
    payment claim on restart (#1434).
- * `ProabilisticScorer` uses more precision when approximating `log10` (#1406).
- * `BackgroundProcessor` processes pending events before processing network
-   messages to reduce lock contention in `ChannelManager`, which improves
-   `ChannelManager` serialization on slow systems to avoid force channel closes
-   (#1436).
+ * `BackgroundProcessor` has been fixed to improve serialization reliability on
+   slow systems which can avoid force-closes (#1436).
+processes pending events before processing network
+   messages to reduce lock contention in `ChannelManager`,
+   improves
  * `gossip_timestamp_filter` filters are now honored when sending gossip to
    peers (#1452).
  * During a reorg, only force-close a channel if its funding transaction is
    unconfirmed rather than as it loses confirmations (#1461).
- * Fixed a panic in `lightning-net-tokio` when fetching a peer's socket address
-   after the connection has been closed (#1449).
- * `find_route` will no longer return routes that would cause Onion construction
-   to fail (#1476).
+ * Fixed a rate panic in `lightning-net-tokio` when fetching a peer's socket
+   address after the connection has been closed caused by a race condition
+   (#1449).
+ * `find_route` will no longer return routes that would cause onion construction
+   to fail in some cases (#1476).
+ * `ProbabilisticScorer` uses more precision when approximating `log10` (#1406).
 
 ## Serialization Compatibility
 * `ChannelManager` serialization is no longer compatible with versions prior to