Log all sent + received onion messages

[TheBlueMatt]

Logging every sent + received message is invaluable as a debug tool, we should do the same thing for P2P messages as we currently lack good observability in the OM pipeline.

[tnull]

Logging every sent + received message is invaluable as a debug tool, we should do the same thing for P2P messages as we currently lack good observability in the OM pipeline.

I assume this should happen at the GOSSIP level?

[TheBlueMatt]

I'd think TRACE - in my mind the distinction is GOSSIP will flood your logs and be unreadable, TRACE shouldn't, but a counterparty that wants to spam you totally can. For receive/send OMs I'd expect them to steady-state be pretty quiet.

[Sharmalm]

Can I try this issue?

[valentinewallace]

Can I try this issue?

Go for it @Sharmalm

[Sharmalm]

This line is message processing function. So do i have to log every sent and receive message individually?

[jkczyz]

It isn't clear to me from this issue what is supposed to be logged. We already log both sent and received onion messages in PeerManager, AFAICT, just as we do for other P2P messages.

[jkczyz]

Was the description suppose to say s/P2P messages/onion message payload?

[TheBlueMatt]

Yea, payload really. The issue with the current logging is we have no idea what was in the onion messages, we just log the encrypted data.