discovery: start sending block heights in range query

Author: ellemouton

discovery/syncer.go

@@ -622,8 +622,12 @@ func (g *GossipSyncer) channelGraphSyncer() {
 			if g.localUpdateHorizon == nil &&
 				syncType.IsActiveSync() {
 
+				startBlock := g.cfg.bestHeight()
+				blockRange := uint32(math.MaxUint32)
+
 				err := g.sendGossipTimestampRange(
 					time.Now(), math.MaxUint32,
+					&startBlock, &blockRange,
 				)
 				if err != nil {
 					log.Errorf("Unable to send update "+
@@ -690,12 +694,23 @@ func (g *GossipSyncer) replyHandler() {
 // sendGossipTimestampRange constructs and sets a GossipTimestampRange for the
 // syncer and sends it to the remote peer.
 func (g *GossipSyncer) sendGossipTimestampRange(firstTimestamp time.Time,
-	timestampRange uint32) error {
+	timestampRange uint32, firstBlock, blockRange *uint32) error {
 
 	endTimestamp := firstTimestamp.Add(
 		time.Duration(timestampRange) * time.Second,
 	)
 
+	if firstBlock != nil && blockRange != nil {
+		log.Infof("GossipSyncer(%x): applying "+
+			"gossipFilter(start-time=%v, end-time=%v, "+
+			"start-block=%v, block-range=%v)", g.cfg.peerPub[:],
+			firstTimestamp, endTimestamp, *firstBlock, *blockRange)
+	} else {
+		log.Infof("GossipSyncer(%x): applying "+
+			"gossipFilter(start-time=%v, end-time=%v",
+			g.cfg.peerPub[:], firstTimestamp, endTimestamp)
+	}
+
 	log.Infof("GossipSyncer(%x): applying gossipFilter(start=%v, end=%v)",
 		g.cfg.peerPub[:], firstTimestamp, endTimestamp)
 
@@ -705,11 +720,28 @@ func (g *GossipSyncer) sendGossipTimestampRange(firstTimestamp time.Time,
 		TimestampRange: timestampRange,
 	}
 
+	if firstBlock != nil {
+		first := tlv.ZeroRecordT[tlv.TlvType2, uint32]()
+		first.Val = *firstBlock
+
+		localUpdateHorizon.FirstBlockHeight = tlv.SomeRecordT(first)
+	}
+
+	if blockRange != nil {
+		bRange := tlv.ZeroRecordT[tlv.TlvType4, uint32]()
+		bRange.Val = *blockRange
+
+		localUpdateHorizon.BlockRange = tlv.SomeRecordT(bRange)
+	}
+
 	if err := g.cfg.sendToPeer(localUpdateHorizon); err != nil {
 		return err
 	}
 
-	if firstTimestamp == zeroTimestamp && timestampRange == 0 {
+	noTimeStamps := firstTimestamp == zeroTimestamp && timestampRange == 0
+	noBlockHeights := firstBlock == nil && blockRange == nil
+
+	if noTimeStamps && noBlockHeights {
 		g.localUpdateHorizon = nil
 	} else {
 		g.localUpdateHorizon = localUpdateHorizon
@@ -1661,6 +1693,8 @@ func (g *GossipSyncer) handleSyncTransition(req *syncTransitionReq) error {
 	var (
 		firstTimestamp time.Time
 		timestampRange uint32
+		firstBlock     *uint32
+		blockRange     *uint32
 	)
 
 	switch req.newSyncType {
@@ -1669,6 +1703,10 @@ func (g *GossipSyncer) handleSyncTransition(req *syncTransitionReq) error {
 	case ActiveSync, PinnedSync:
 		firstTimestamp = time.Now()
 		timestampRange = math.MaxUint32
+		bestHeight := g.cfg.bestHeight()
+		firstBlock = &bestHeight
+		heightRange := uint32(math.MaxUint32)
+		blockRange = &heightRange
 
 	// If a PassiveSync transition has been requested, then we should no
 	// longer receive any new updates from the remote peer. We can do this
@@ -1683,7 +1721,9 @@ func (g *GossipSyncer) handleSyncTransition(req *syncTransitionReq) error {
 			req.newSyncType)
 	}
 
-	err := g.sendGossipTimestampRange(firstTimestamp, timestampRange)
+	err := g.sendGossipTimestampRange(
+		firstTimestamp, timestampRange, firstBlock, blockRange,
+	)
 	if err != nil {
 		return fmt.Errorf("unable to send local update horizon: %w",
 			err)

discovery/syncer_test.go

@@ -15,6 +15,7 @@ import (
 	"github.com/davecgh/go-spew/spew"
 	"github.com/lightningnetwork/lnd/channeldb"
 	"github.com/lightningnetwork/lnd/lnwire"
+	"github.com/lightningnetwork/lnd/tlv"
 	"github.com/stretchr/testify/require"
 )
 
@@ -2258,12 +2259,26 @@ func TestGossipSyncerSyncTransitions(t *testing.T) {
 				// send out a message that indicates we want
 				// all the updates from here on.
 				firstTimestamp := uint32(time.Now().Unix())
-				assertMsgSent(
-					t, mChan, &lnwire.GossipTimestampRange{
-						FirstTimestamp: firstTimestamp,
-						TimestampRange: math.MaxUint32,
-					},
-				)
+				firstBlock := tlv.ZeroRecordT[
+					tlv.TlvType2, uint32,
+				]()
+				firstBlock.Val = uint32(latestKnownHeight)
+
+				blockRange := tlv.ZeroRecordT[
+					tlv.TlvType4, uint32,
+				]()
+				blockRange.Val = uint32(math.MaxUint32)
+
+				assertMsgSent(t, mChan, &lnwire.GossipTimestampRange{ //nolint:lll
+					FirstTimestamp: firstTimestamp,
+					TimestampRange: math.MaxUint32,
+					FirstBlockHeight: tlv.SomeRecordT(
+						firstBlock,
+					),
+					BlockRange: tlv.SomeRecordT(
+						blockRange,
+					),
+				})
 
 				// When transitioning from active to passive, we
 				// should expect to see a new local update
@@ -2298,10 +2313,26 @@ func TestGossipSyncerSyncTransitions(t *testing.T) {
 				// horizon sent to the remote peer indicating
 				// that it would like to receive any future
 				// updates.
+				firstBlock := tlv.ZeroRecordT[
+					tlv.TlvType2, uint32,
+				]()
+				firstBlock.Val = uint32(latestKnownHeight)
+
+				blockRange := tlv.ZeroRecordT[
+					tlv.TlvType4, uint32,
+				]()
+				blockRange.Val = uint32(math.MaxUint32)
+
 				firstTimestamp := uint32(time.Now().Unix())
 				assertMsgSent(t, msgChan, &lnwire.GossipTimestampRange{
 					FirstTimestamp: firstTimestamp,
 					TimestampRange: math.MaxUint32,
+					FirstBlockHeight: tlv.SomeRecordT(
+						firstBlock,
+					),
+					BlockRange: tlv.SomeRecordT(
+						blockRange,
+					),
 				})
 
 				syncState := g.syncState()