Skip to content

channeldb: load graph cache async #8919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

channeldb: load graph cache async #8919

wants to merge 4 commits into from

Conversation

djkazic
Copy link
Contributor

@djkazic djkazic commented Jul 17, 2024 •
edited by Roasbeef
Loading

Change Description

Today, LND startup time can be slow. This PR aims to speed up initial startup by performing graph cache population in the background. All callsites for c.graphCache have been refactored to use c.getGraphCache() instead which will return the cache if it's ready or an error if an error occurred during cache population. Pending updates are queued and then executed once the graph cache is done being loaded.

Note that this PR is a prototype, reviews are welcome.

Pull Request Checklist

Testing

  • Your PR passes all CI checks. (some flaky CI tests failed)
  • Tests covering the positive and negative (error paths) are included.
  • Bug fixes contain tests triggering the bug to prevent regressions.

Code Style and Documentation

Fixes #6187

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Jul 17, 2024

Important

Review skipped

Auto reviews are limited to specific labels.

Labels to auto review (1)
  • llm-review

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@djkazic djkazic force-pushed the async-graph-load branch 12 times, most recently from 1d3f8bb to 90faf71 Compare July 18, 2024 14:02
@djkazic djkazic force-pushed the async-graph-load branch 2 times, most recently from 9f4b350 to ecb8d1b Compare July 18, 2024 21:06
@djkazic djkazic force-pushed the async-graph-load branch 2 times, most recently from 7e1f6f5 to b4e07a4 Compare July 19, 2024 03:44
@djkazic djkazic force-pushed the async-graph-load branch 7 times, most recently from d1ef97d to 243f2a0 Compare July 19, 2024 13:44
@djkazic djkazic force-pushed the async-graph-load branch from 243f2a0 to 05bdb25 Compare July 19, 2024 14:24
@saubyk saubyk added this to the v0.19.0 milestone Aug 7, 2024
@saubyk saubyk added the graph label Aug 7, 2024
@Roasbeef Roasbeef modified the milestones: v0.19.0, v0.20.0, v0.19 overflow Feb 5, 2025
@Roasbeef Roasbeef mentioned this pull request Feb 12, 2025
Open
@ellemouton ellemouton self-requested a review February 12, 2025 04:58
ellemouton
ellemouton reviewed Feb 13, 2025
View reviewed changes
Copy link
Collaborator

@ellemouton ellemouton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@djkazic - im happy to review this once it's ready

@saubyk saubyk modified the milestones: v0.19 overflow, v0.20.0 Feb 13, 2025
@lightninglabs-deploy
Copy link

@djkazic, remember to re-request review from reviewers when ready

@ellemouton
Copy link
Collaborator

!lightninglabs-deploy mute

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ellemouton ellemouton ellemouton left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees

@djkazic djkazic

Labels
graph
Projects
None yet
Milestone
v0.20.0
Development

Successfully merging this pull request may close these issues.

channeldb: make channel graph population async
5 participants
@djkazic @lightninglabs-deploy @ellemouton @Roasbeef @saubyk