Return "Temporary Channel Failure" for offline peer #6803
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only return a permanent "unknown next peer" error if we are unable to find the channel link. In other cases, especially if the peer is just offline, return a "temporary channel failure" so that future retries are encouraged. fixes lightningnetwork#6603
C-Otto
force-pushed
the
temporary-channel-failure-for-offline-peer
branch
from
fe9c281 to
bf30fcb
Compare
positiveblue
reviewed
Aug 7, 2022
| @@ -851,7 +851,7 @@ func (s *Switch) getLocalLink(pkt *htlcPacket, htlc *lnwire.UpdateAddHTLC) ( | |||
| // If the link was not found for the outgoingChanID, an outside | |||
There was a problem hiding this comment.
This logic
lock indexMtx
try to get LinkByShortID
if fails check baseIndex
retry to get LinkBysShortID with the new scid
is similar to the one in GetLinkByShortID I think we could simply call that function here.
| @@ -867,7 +867,7 @@ func (s *Switch) getLocalLink(pkt *htlcPacket, htlc *lnwire.UpdateAddHTLC) ( | |||
| link, err = s.getLinkByShortID(baseScid) | |||
| if err != nil { | |||
| log.Errorf("Link %v not found", baseScid) | |||
| return nil, NewLinkError(&lnwire.FailUnknownNextPeer{}) | |||
| return nil, NewLinkError(&lnwire.FailTemporaryChannelFailure{}) | |||
There was a problem hiding this comment.
Doesn't this also apply to non zero conf channels? Are we currently sending FailTemporaryChannelFailure instead of FailUnknownNextPeer for those?
|
I don't understand enough of this code and sadly the tests also didn't help much (I'm used to tests with 10 lines max...). I'm closing this PR as I noticed the actual error is determined in another place, and I'm unable to differentiate between "offline" and "unknown". |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
This fixes #6603. If a forwarding request cannot be processed because the next hop currently is offline, without this patch lnd returns a permanent "unknown next peer" error. Instead, if the requested channel is known, with this patch lnd returns a "temporary channel failure".
Steps to Test
Send forwarding request that should go out through an inactive channel (peer is offline).
Pull Request Checklist
Testing
Code Style and Documentation
[skip ci]in the commit message for small changes.📝 Please see our Contribution Guidelines for further guidance.