Merge pull request #266 from asamal4/print-to-logging

chore: replace pending print statement with logger

Author: asamal4

src/lightspeed_evaluation/core/llm/deepeval.py

@@ -62,7 +62,7 @@ def __init__(self, model_name: str, llm_params: dict[str, Any]):
             **self.llm_params.get("parameters", {}),
         )
 
-        print(f"✅ DeepEval LLM Manager: {self.model_name}")
+        logger.info("DeepEval LLM Manager: %s", self.model_name)
 
     def _patch_deepeval_retries(self, max_retries: int) -> None:
         """Monkey-patch DeepEval's retry decorators to use configured max_retries.

src/lightspeed_evaluation/core/metrics/custom/custom.py

@@ -1,6 +1,7 @@
 """Custom metrics using direct LLM integration."""
 
 import json
+import logging
 import re
 from typing import TYPE_CHECKING, Any, Optional
 
@@ -23,6 +24,8 @@
 if TYPE_CHECKING:
     from lightspeed_evaluation.core.metrics.manager import MetricManager
 
+logger = logging.getLogger(__name__)
+
 
 class CustomMetrics:  # pylint: disable=too-few-public-methods
     """Handles custom metrics using LLMManager for direct LLM calls."""
@@ -54,7 +57,7 @@ def __init__(
             ),
         }
 
-        print(f"✅ Custom Metrics initialized: {self.llm.model_name}")
+        logger.info("Custom Metrics initialized: %s", self.llm.model_name)
 
     def evaluate(
         self,

src/lightspeed_evaluation/core/output/data_persistence.py

@@ -1,5 +1,6 @@
 """Simple data persistence utilities for evaluation framework."""
 
+import logging
 from datetime import UTC, datetime
 from pathlib import Path
 from typing import Any, Optional
@@ -10,6 +11,8 @@
 from lightspeed_evaluation.core.models import EvaluationData
 from lightspeed_evaluation.core.models.data import DatasetMetadata
 
+logger = logging.getLogger(__name__)
+
 
 def save_evaluation_data(
     evaluation_data: list[EvaluationData],
@@ -62,9 +65,9 @@ def save_evaluation_data(
                 indent=2,
             )
 
-        print(f"💾 Amended evaluation data saved to: {amended_data_path}")
+        logger.info("Amended evaluation data saved to: %s", amended_data_path)
         return str(amended_data_path)
 
     except (OSError, yaml.YAMLError) as e:
-        print(f"❌ Failed to save amended evaluation data: {e}")
+        logger.error("Failed to save amended evaluation data: %s", e)
         return None

tests/unit/core/llm/test_deepeval_manager.py

@@ -77,17 +77,17 @@ def test_get_model_info(self, llm_params: dict, mocker: MockerFixture) -> None:
         assert info["temperature"] == 0.5
         assert info["max_completion_tokens"] == 1024
 
-    def test_initialization_prints_message(
-        self, llm_params: dict, mocker: MockerFixture, capsys: pytest.CaptureFixture
+    def test_initialization_logs_message(
+        self, llm_params: dict, mocker: MockerFixture, caplog: pytest.LogCaptureFixture
     ) -> None:
-        """Test that initialization prints configuration message."""
+        """Test that initialization logs configuration message."""
         mocker.patch("lightspeed_evaluation.core.llm.deepeval.LiteLLMModel")
 
-        DeepEvalLLMManager("gpt-4", llm_params)
+        with caplog.at_level("INFO", logger="lightspeed_evaluation.core.llm.deepeval"):
+            DeepEvalLLMManager("gpt-4", llm_params)
 
-        captured = capsys.readouterr()
-        assert "DeepEval LLM Manager" in captured.out
-        assert "gpt-4" in captured.out
+        assert "DeepEval LLM Manager" in caplog.text
+        assert "gpt-4" in caplog.text
 
     def test_drop_params_always_enabled(self, mocker: MockerFixture) -> None:
         """Test drop_params is always enabled for cross-provider compatibility."""