Skip to content

Commit 56d1dc1

Browse files
soondenanasoondenana
authored
MINOR: Use readable interface to parse requests (apache#19163)
The generated request data type's constructors take Readable as an input. However, the parse method in the AbstractRequest takes a ByteBuffer as input. So to create the corresponding request data objects, each individual concrete Request classes wraps the ByteBuffer into a ByteBufferAccessor. This is boilerplate code present in all the concrete request classes. This changes AbstractRequest's parse method so that subclasses can simply pass the `Readable` they get directly to request data classes. The same change is made to the serialize method to maintain symmetry. Reviewers: Ismael Juma <[email protected]>, José Armando García Sancio <[email protected]>, Artem Livshits <[email protected]>, Truc Nguyen <[email protected]>
1 parent b6adec4 commit 56d1dc1

File tree

117 files changed

+437
-547
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

117 files changed

+437
-547
lines changed

Diff for: ‎clients/src/main/java/org/apache/kafka/common/protocol/MessageUtil.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -204,13 +204,13 @@ public static boolean compareRawTaggedFields(List<RawTaggedField> first,
204204
}
205205
}
206206

207-
public static ByteBuffer toByteBuffer(final Message message, final short version) {
207+
public static ByteBufferAccessor toByteBufferAccessor(final Message message, final short version) {
208208
ObjectSerializationCache cache = new ObjectSerializationCache();
209209
int messageSize = message.size(cache, version);
210210
ByteBufferAccessor bytes = new ByteBufferAccessor(ByteBuffer.allocate(messageSize));
211211
message.write(bytes, cache, version);
212212
bytes.flip();
213-
return bytes.buffer();
213+
return bytes;
214214
}
215215

216216
public static ByteBuffer toVersionPrefixedByteBuffer(final short version, final Message message) {

Diff for: ‎clients/src/main/java/org/apache/kafka/common/record/MemoryRecordsBuilder.java

+5-5
Original file line numberDiff line numberDiff line change
@@ -634,39 +634,39 @@ public void appendLeaderChangeMessage(long timestamp, LeaderChangeMessage leader
634634
appendControlRecord(
635635
timestamp,
636636
ControlRecordType.LEADER_CHANGE,
637-
MessageUtil.toByteBuffer(leaderChangeMessage, ControlRecordUtils.LEADER_CHANGE_CURRENT_VERSION)
637+
MessageUtil.toByteBufferAccessor(leaderChangeMessage, ControlRecordUtils.LEADER_CHANGE_CURRENT_VERSION).buffer()
638638
);
639639
}
640640

641641
public void appendSnapshotHeaderMessage(long timestamp, SnapshotHeaderRecord snapshotHeaderRecord) {
642642
appendControlRecord(
643643
timestamp,
644644
ControlRecordType.SNAPSHOT_HEADER,
645-
MessageUtil.toByteBuffer(snapshotHeaderRecord, ControlRecordUtils.SNAPSHOT_HEADER_CURRENT_VERSION)
645+
MessageUtil.toByteBufferAccessor(snapshotHeaderRecord, ControlRecordUtils.SNAPSHOT_HEADER_CURRENT_VERSION).buffer()
646646
);
647647
}
648648

649649
public void appendSnapshotFooterMessage(long timestamp, SnapshotFooterRecord snapshotHeaderRecord) {
650650
appendControlRecord(
651651
timestamp,
652652
ControlRecordType.SNAPSHOT_FOOTER,
653-
MessageUtil.toByteBuffer(snapshotHeaderRecord, ControlRecordUtils.SNAPSHOT_FOOTER_CURRENT_VERSION)
653+
MessageUtil.toByteBufferAccessor(snapshotHeaderRecord, ControlRecordUtils.SNAPSHOT_FOOTER_CURRENT_VERSION).buffer()
654654
);
655655
}
656656

657657
public void appendKRaftVersionMessage(long timestamp, KRaftVersionRecord kraftVersionRecord) {
658658
appendControlRecord(
659659
timestamp,
660660
ControlRecordType.KRAFT_VERSION,
661-
MessageUtil.toByteBuffer(kraftVersionRecord, ControlRecordUtils.KRAFT_VERSION_CURRENT_VERSION)
661+
MessageUtil.toByteBufferAccessor(kraftVersionRecord, ControlRecordUtils.KRAFT_VERSION_CURRENT_VERSION).buffer()
662662
);
663663
}
664664

665665
public void appendVotersMessage(long timestamp, VotersRecord votersRecord) {
666666
appendControlRecord(
667667
timestamp,
668668
ControlRecordType.KRAFT_VOTERS,
669-
MessageUtil.toByteBuffer(votersRecord, ControlRecordUtils.KRAFT_VOTERS_CURRENT_VERSION)
669+
MessageUtil.toByteBufferAccessor(votersRecord, ControlRecordUtils.KRAFT_VOTERS_CURRENT_VERSION).buffer()
670670
);
671671
}
672672

Diff for: ‎clients/src/main/java/org/apache/kafka/common/requests/AbstractRequest.java

+97-95
Large diffs are not rendered by default.

Diff for: ‎clients/src/main/java/org/apache/kafka/common/requests/AbstractResponse.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ final ByteBuffer serializeWithHeader(ResponseHeader header, short version) {
5252

5353
// Visible for testing
5454
final ByteBuffer serialize(short version) {
55-
return MessageUtil.toByteBuffer(data(), version);
55+
return MessageUtil.toByteBufferAccessor(data(), version).buffer();
5656
}
5757

5858
/**

Diff for: ‎clients/src/main/java/org/apache/kafka/common/requests/AddOffsetsToTxnRequest.java

+3-5
Original file line numberDiff line numberDiff line change
@@ -19,10 +19,8 @@
1919
import org.apache.kafka.common.message.AddOffsetsToTxnRequestData;
2020
import org.apache.kafka.common.message.AddOffsetsToTxnResponseData;
2121
import org.apache.kafka.common.protocol.ApiKeys;
22-
import org.apache.kafka.common.protocol.ByteBufferAccessor;
2322
import org.apache.kafka.common.protocol.Errors;
24-
25-
import java.nio.ByteBuffer;
23+
import org.apache.kafka.common.protocol.Readable;
2624

2725
public class AddOffsetsToTxnRequest extends AbstractRequest {
2826

@@ -64,7 +62,7 @@ public AddOffsetsToTxnResponse getErrorResponse(int throttleTimeMs, Throwable e)
6462
.setThrottleTimeMs(throttleTimeMs));
6563
}
6664

67-
public static AddOffsetsToTxnRequest parse(ByteBuffer buffer, short version) {
68-
return new AddOffsetsToTxnRequest(new AddOffsetsToTxnRequestData(new ByteBufferAccessor(buffer), version), version);
65+
public static AddOffsetsToTxnRequest parse(Readable readable, short version) {
66+
return new AddOffsetsToTxnRequest(new AddOffsetsToTxnRequestData(readable, version), version);
6967
}
7068
}

Diff for: ‎clients/src/main/java/org/apache/kafka/common/requests/AddPartitionsToTxnRequest.java

+3-4
Original file line numberDiff line numberDiff line change
@@ -29,10 +29,9 @@
2929
import org.apache.kafka.common.message.AddPartitionsToTxnResponseData.AddPartitionsToTxnTopicResult;
3030
import org.apache.kafka.common.message.AddPartitionsToTxnResponseData.AddPartitionsToTxnTopicResultCollection;
3131
import org.apache.kafka.common.protocol.ApiKeys;
32-
import org.apache.kafka.common.protocol.ByteBufferAccessor;
3332
import org.apache.kafka.common.protocol.Errors;
33+
import org.apache.kafka.common.protocol.Readable;
3434

35-
import java.nio.ByteBuffer;
3635
import java.util.ArrayList;
3736
import java.util.HashMap;
3837
import java.util.List;
@@ -198,7 +197,7 @@ private AddPartitionsToTxnTopicResultCollection errorResponseForTopics(AddPartit
198197
return topicResults;
199198
}
200199

201-
public static AddPartitionsToTxnRequest parse(ByteBuffer buffer, short version) {
202-
return new AddPartitionsToTxnRequest(new AddPartitionsToTxnRequestData(new ByteBufferAccessor(buffer), version), version);
200+
public static AddPartitionsToTxnRequest parse(Readable readable, short version) {
201+
return new AddPartitionsToTxnRequest(new AddPartitionsToTxnRequestData(readable, version), version);
203202
}
204203
}

Diff for: ‎clients/src/main/java/org/apache/kafka/common/requests/AddRaftVoterRequest.java

+3-5
Original file line numberDiff line numberDiff line change
@@ -20,10 +20,8 @@
2020
import org.apache.kafka.common.message.AddRaftVoterRequestData;
2121
import org.apache.kafka.common.message.AddRaftVoterResponseData;
2222
import org.apache.kafka.common.protocol.ApiKeys;
23-
import org.apache.kafka.common.protocol.ByteBufferAccessor;
2423
import org.apache.kafka.common.protocol.Errors;
25-
26-
import java.nio.ByteBuffer;
24+
import org.apache.kafka.common.protocol.Readable;
2725

2826
public class AddRaftVoterRequest extends AbstractRequest {
2927
public static class Builder extends AbstractRequest.Builder<AddRaftVoterRequest> {
@@ -67,9 +65,9 @@ public AbstractResponse getErrorResponse(int throttleTimeMs, Throwable e) {
6765
setThrottleTimeMs(throttleTimeMs));
6866
}
6967

70-
public static AddRaftVoterRequest parse(ByteBuffer buffer, short version) {
68+
public static AddRaftVoterRequest parse(Readable readable, short version) {
7169
return new AddRaftVoterRequest(
72-
new AddRaftVoterRequestData(new ByteBufferAccessor(buffer), version),
70+
new AddRaftVoterRequestData(readable, version),
7371
version);
7472
}
7573
}

Diff for: ‎clients/src/main/java/org/apache/kafka/common/requests/AllocateProducerIdsRequest.java

+3-5
Original file line numberDiff line numberDiff line change
@@ -20,10 +20,8 @@
2020
import org.apache.kafka.common.message.AllocateProducerIdsRequestData;
2121
import org.apache.kafka.common.message.AllocateProducerIdsResponseData;
2222
import org.apache.kafka.common.protocol.ApiKeys;
23-
import org.apache.kafka.common.protocol.ByteBufferAccessor;
2423
import org.apache.kafka.common.protocol.Errors;
25-
26-
import java.nio.ByteBuffer;
24+
import org.apache.kafka.common.protocol.Readable;
2725

2826
public class AllocateProducerIdsRequest extends AbstractRequest {
2927
private final AllocateProducerIdsRequestData data;
@@ -65,8 +63,8 @@ public String toString() {
6563
}
6664
}
6765

68-
public static AllocateProducerIdsRequest parse(ByteBuffer buffer, short version) {
66+
public static AllocateProducerIdsRequest parse(Readable readable, short version) {
6967
return new AllocateProducerIdsRequest(new AllocateProducerIdsRequestData(
70-
new ByteBufferAccessor(buffer), version), version);
68+
readable, version), version);
7169
}
7270
}

Diff for: ‎clients/src/main/java/org/apache/kafka/common/requests/AlterClientQuotasRequest.java

+3-4
Original file line numberDiff line numberDiff line change
@@ -22,12 +22,11 @@
2222
import org.apache.kafka.common.message.AlterClientQuotasRequestData.OpData;
2323
import org.apache.kafka.common.message.AlterClientQuotasResponseData;
2424
import org.apache.kafka.common.protocol.ApiKeys;
25-
import org.apache.kafka.common.protocol.ByteBufferAccessor;
2625
import org.apache.kafka.common.protocol.Errors;
26+
import org.apache.kafka.common.protocol.Readable;
2727
import org.apache.kafka.common.quota.ClientQuotaAlteration;
2828
import org.apache.kafka.common.quota.ClientQuotaEntity;
2929

30-
import java.nio.ByteBuffer;
3130
import java.util.ArrayList;
3231
import java.util.Collection;
3332
import java.util.HashMap;
@@ -138,7 +137,7 @@ public AlterClientQuotasResponse getErrorResponse(int throttleTimeMs, Throwable
138137
return new AlterClientQuotasResponse(responseData);
139138
}
140139

141-
public static AlterClientQuotasRequest parse(ByteBuffer buffer, short version) {
142-
return new AlterClientQuotasRequest(new AlterClientQuotasRequestData(new ByteBufferAccessor(buffer), version), version);
140+
public static AlterClientQuotasRequest parse(Readable readable, short version) {
141+
return new AlterClientQuotasRequest(new AlterClientQuotasRequestData(readable, version), version);
143142
}
144143
}

Diff for: ‎clients/src/main/java/org/apache/kafka/common/requests/AlterConfigsRequest.java

+3-4
Original file line numberDiff line numberDiff line change
@@ -21,9 +21,8 @@
2121
import org.apache.kafka.common.message.AlterConfigsRequestData;
2222
import org.apache.kafka.common.message.AlterConfigsResponseData;
2323
import org.apache.kafka.common.protocol.ApiKeys;
24-
import org.apache.kafka.common.protocol.ByteBufferAccessor;
24+
import org.apache.kafka.common.protocol.Readable;
2525

26-
import java.nio.ByteBuffer;
2726
import java.util.Collection;
2827
import java.util.Map;
2928
import java.util.Objects;
@@ -132,7 +131,7 @@ public AbstractResponse getErrorResponse(int throttleTimeMs, Throwable e) {
132131

133132
}
134133

135-
public static AlterConfigsRequest parse(ByteBuffer buffer, short version) {
136-
return new AlterConfigsRequest(new AlterConfigsRequestData(new ByteBufferAccessor(buffer), version), version);
134+
public static AlterConfigsRequest parse(Readable readable, short version) {
135+
return new AlterConfigsRequest(new AlterConfigsRequestData(readable, version), version);
137136
}
138137
}

Diff for: ‎clients/src/main/java/org/apache/kafka/common/requests/AlterPartitionReassignmentsRequest.java

+3-4
Original file line numberDiff line numberDiff line change
@@ -24,9 +24,8 @@
2424
import org.apache.kafka.common.message.AlterPartitionReassignmentsResponseData.ReassignablePartitionResponse;
2525
import org.apache.kafka.common.message.AlterPartitionReassignmentsResponseData.ReassignableTopicResponse;
2626
import org.apache.kafka.common.protocol.ApiKeys;
27-
import org.apache.kafka.common.protocol.ByteBufferAccessor;
27+
import org.apache.kafka.common.protocol.Readable;
2828

29-
import java.nio.ByteBuffer;
3029
import java.util.ArrayList;
3130
import java.util.List;
3231
import java.util.stream.Collectors;
@@ -64,9 +63,9 @@ private AlterPartitionReassignmentsRequest(AlterPartitionReassignmentsRequestDat
6463
this.data = data;
6564
}
6665

67-
public static AlterPartitionReassignmentsRequest parse(ByteBuffer buffer, short version) {
66+
public static AlterPartitionReassignmentsRequest parse(Readable readable, short version) {
6867
return new AlterPartitionReassignmentsRequest(new AlterPartitionReassignmentsRequestData(
69-
new ByteBufferAccessor(buffer), version), version);
68+
readable, version), version);
7069
}
7170

7271
public AlterPartitionReassignmentsRequestData data() {

Diff for: ‎clients/src/main/java/org/apache/kafka/common/requests/AlterPartitionRequest.java

+3-4
Original file line numberDiff line numberDiff line change
@@ -21,10 +21,9 @@
2121
import org.apache.kafka.common.message.AlterPartitionRequestData.BrokerState;
2222
import org.apache.kafka.common.message.AlterPartitionResponseData;
2323
import org.apache.kafka.common.protocol.ApiKeys;
24-
import org.apache.kafka.common.protocol.ByteBufferAccessor;
2524
import org.apache.kafka.common.protocol.Errors;
25+
import org.apache.kafka.common.protocol.Readable;
2626

27-
import java.nio.ByteBuffer;
2827
import java.util.ArrayList;
2928
import java.util.Collections;
3029
import java.util.List;
@@ -54,8 +53,8 @@ public AbstractResponse getErrorResponse(int throttleTimeMs, Throwable e) {
5453
.setErrorCode(Errors.forException(e).code()));
5554
}
5655

57-
public static AlterPartitionRequest parse(ByteBuffer buffer, short version) {
58-
return new AlterPartitionRequest(new AlterPartitionRequestData(new ByteBufferAccessor(buffer), version), version);
56+
public static AlterPartitionRequest parse(Readable readable, short version) {
57+
return new AlterPartitionRequest(new AlterPartitionRequestData(readable, version), version);
5958
}
6059

6160
public static class Builder extends AbstractRequest.Builder<AlterPartitionRequest> {

Diff for: ‎clients/src/main/java/org/apache/kafka/common/requests/AlterReplicaLogDirsRequest.java

+3-4
Original file line numberDiff line numberDiff line change
@@ -23,10 +23,9 @@
2323
import org.apache.kafka.common.message.AlterReplicaLogDirsResponseData;
2424
import org.apache.kafka.common.message.AlterReplicaLogDirsResponseData.AlterReplicaLogDirTopicResult;
2525
import org.apache.kafka.common.protocol.ApiKeys;
26-
import org.apache.kafka.common.protocol.ByteBufferAccessor;
2726
import org.apache.kafka.common.protocol.Errors;
27+
import org.apache.kafka.common.protocol.Readable;
2828

29-
import java.nio.ByteBuffer;
3029
import java.util.HashMap;
3130
import java.util.Map;
3231
import java.util.stream.Collectors;
@@ -87,7 +86,7 @@ public Map<TopicPartition, String> partitionDirs() {
8786
return result;
8887
}
8988

90-
public static AlterReplicaLogDirsRequest parse(ByteBuffer buffer, short version) {
91-
return new AlterReplicaLogDirsRequest(new AlterReplicaLogDirsRequestData(new ByteBufferAccessor(buffer), version), version);
89+
public static AlterReplicaLogDirsRequest parse(Readable readable, short version) {
90+
return new AlterReplicaLogDirsRequest(new AlterReplicaLogDirsRequestData(readable, version), version);
9291
}
9392
}

Diff for: ‎clients/src/main/java/org/apache/kafka/common/requests/AlterShareGroupOffsetsRequest.java

+3-4
Original file line numberDiff line numberDiff line change
@@ -20,10 +20,9 @@
2020
import org.apache.kafka.common.message.AlterShareGroupOffsetsRequestData;
2121
import org.apache.kafka.common.message.AlterShareGroupOffsetsResponseData;
2222
import org.apache.kafka.common.protocol.ApiKeys;
23-
import org.apache.kafka.common.protocol.ByteBufferAccessor;
2423
import org.apache.kafka.common.protocol.Errors;
24+
import org.apache.kafka.common.protocol.Readable;
2525

26-
import java.nio.ByteBuffer;
2726
import java.util.ArrayList;
2827
import java.util.List;
2928
import java.util.stream.Collectors;
@@ -76,9 +75,9 @@ public AbstractResponse getErrorResponse(int throttleTimeMs, Throwable e) {
7675
.setResponses(results));
7776
}
7877

79-
public static AlterShareGroupOffsetsRequest parse(ByteBuffer buffer, short version) {
78+
public static AlterShareGroupOffsetsRequest parse(Readable readable, short version) {
8079
return new AlterShareGroupOffsetsRequest(
81-
new AlterShareGroupOffsetsRequestData(new ByteBufferAccessor(buffer), version),
80+
new AlterShareGroupOffsetsRequestData(readable, version),
8281
version
8382
);
8483
}

Diff for: ‎clients/src/main/java/org/apache/kafka/common/requests/AlterUserScramCredentialsRequest.java

+3-4
Original file line numberDiff line numberDiff line change
@@ -19,9 +19,8 @@
1919
import org.apache.kafka.common.message.AlterUserScramCredentialsRequestData;
2020
import org.apache.kafka.common.message.AlterUserScramCredentialsResponseData;
2121
import org.apache.kafka.common.protocol.ApiKeys;
22-
import org.apache.kafka.common.protocol.ByteBufferAccessor;
22+
import org.apache.kafka.common.protocol.Readable;
2323

24-
import java.nio.ByteBuffer;
2524
import java.util.List;
2625
import java.util.Set;
2726
import java.util.stream.Collectors;
@@ -55,8 +54,8 @@ private AlterUserScramCredentialsRequest(AlterUserScramCredentialsRequestData da
5554
this.data = data;
5655
}
5756

58-
public static AlterUserScramCredentialsRequest parse(ByteBuffer buffer, short version) {
59-
return new AlterUserScramCredentialsRequest(new AlterUserScramCredentialsRequestData(new ByteBufferAccessor(buffer), version), version);
57+
public static AlterUserScramCredentialsRequest parse(Readable readable, short version) {
58+
return new AlterUserScramCredentialsRequest(new AlterUserScramCredentialsRequestData(readable, version), version);
6059
}
6160

6261
@Override

Diff for: ‎clients/src/main/java/org/apache/kafka/common/requests/ApiVersionsRequest.java

+3-4
Original file line numberDiff line numberDiff line change
@@ -20,11 +20,10 @@
2020
import org.apache.kafka.common.message.ApiVersionsResponseData;
2121
import org.apache.kafka.common.message.ApiVersionsResponseData.ApiVersionCollection;
2222
import org.apache.kafka.common.protocol.ApiKeys;
23-
import org.apache.kafka.common.protocol.ByteBufferAccessor;
2423
import org.apache.kafka.common.protocol.Errors;
24+
import org.apache.kafka.common.protocol.Readable;
2525
import org.apache.kafka.common.utils.AppInfoParser;
2626

27-
import java.nio.ByteBuffer;
2827
import java.util.regex.Pattern;
2928

3029
public class ApiVersionsRequest extends AbstractRequest {
@@ -128,8 +127,8 @@ public ApiVersionsResponse getErrorResponse(int throttleTimeMs, Throwable e) {
128127
return new ApiVersionsResponse(data);
129128
}
130129

131-
public static ApiVersionsRequest parse(ByteBuffer buffer, short version) {
132-
return new ApiVersionsRequest(new ApiVersionsRequestData(new ByteBufferAccessor(buffer), version), version);
130+
public static ApiVersionsRequest parse(Readable readable, short version) {
131+
return new ApiVersionsRequest(new ApiVersionsRequestData(readable, version), version);
133132
}
134133

135134
}

Diff for: ‎clients/src/main/java/org/apache/kafka/common/requests/AssignReplicasToDirsRequest.java

+3-5
Original file line numberDiff line numberDiff line change
@@ -20,10 +20,8 @@
2020
import org.apache.kafka.common.message.AssignReplicasToDirsRequestData;
2121
import org.apache.kafka.common.message.AssignReplicasToDirsResponseData;
2222
import org.apache.kafka.common.protocol.ApiKeys;
23-
import org.apache.kafka.common.protocol.ByteBufferAccessor;
2423
import org.apache.kafka.common.protocol.Errors;
25-
26-
import java.nio.ByteBuffer;
24+
import org.apache.kafka.common.protocol.Readable;
2725

2826
public class AssignReplicasToDirsRequest extends AbstractRequest {
2927

@@ -75,8 +73,8 @@ public AssignReplicasToDirsRequestData data() {
7573
return data;
7674
}
7775

78-
public static AssignReplicasToDirsRequest parse(ByteBuffer buffer, short version) {
76+
public static AssignReplicasToDirsRequest parse(Readable readable, short version) {
7977
return new AssignReplicasToDirsRequest(new AssignReplicasToDirsRequestData(
80-
new ByteBufferAccessor(buffer), version), version);
78+
readable, version), version);
8179
}
8280
}

Diff for: ‎clients/src/main/java/org/apache/kafka/common/requests/BeginQuorumEpochRequest.java

+3-4
Original file line numberDiff line numberDiff line change
@@ -20,10 +20,9 @@
2020
import org.apache.kafka.common.message.BeginQuorumEpochRequestData;
2121
import org.apache.kafka.common.message.BeginQuorumEpochResponseData;
2222
import org.apache.kafka.common.protocol.ApiKeys;
23-
import org.apache.kafka.common.protocol.ByteBufferAccessor;
2423
import org.apache.kafka.common.protocol.Errors;
24+
import org.apache.kafka.common.protocol.Readable;
2525

26-
import java.nio.ByteBuffer;
2726
import java.util.Collections;
2827

2928
public class BeginQuorumEpochRequest extends AbstractRequest {
@@ -64,8 +63,8 @@ public BeginQuorumEpochResponse getErrorResponse(int throttleTimeMs, Throwable e
6463
.setErrorCode(Errors.forException(e).code()));
6564
}
6665

67-
public static BeginQuorumEpochRequest parse(ByteBuffer buffer, short version) {
68-
return new BeginQuorumEpochRequest(new BeginQuorumEpochRequestData(new ByteBufferAccessor(buffer), version), version);
66+
public static BeginQuorumEpochRequest parse(Readable readable, short version) {
67+
return new BeginQuorumEpochRequest(new BeginQuorumEpochRequestData(readable, version), version);
6968
}
7069

7170
public static BeginQuorumEpochRequestData singletonRequest(

0 commit comments

Comments
 (0)