Prevent creation of unnecessary fieldset(mirror changes from rails-api#2370)

* refactor: instance_options[:fieldset] must be nil as it's not listed in ADAPTER_OPTION_KEYS

Author: liijunwei

lib/active_model_serializers/adapter/attributes.rb

@@ -5,7 +5,10 @@ module Adapter
     class Attributes < Base
       def initialize(*)
         super
-        instance_options[:fieldset] ||= ActiveModel::Serializer::Fieldset.new(fields_to_fieldset(instance_options.delete(:fields)))
+
+        fields = instance_options.delete(:fields)
+        fieldset = fields_to_fieldset(fields)
+        instance_options[:fieldset] = ActiveModel::Serializer::Fieldset.new(fieldset) if fieldset
       end
 
       def serializable_hash(options = nil)
@@ -19,17 +22,20 @@ def serializable_hash(options = nil)
       private
 
       def fields_to_fieldset(fields)
-        return fields if fields.nil?
+        return if fields.nil?
+
         resource_fields = []
         relationship_fields = {}
+
         fields.each do |field|
           case field
           when Symbol, String then resource_fields << field
           when Hash then relationship_fields.merge!(field)
           else fail ArgumentError, "Unknown conversion of fields to fieldset: '#{field.inspect}' in '#{fields.inspect}'"
           end
         end
-        relationship_fields.merge!(serializer.json_key.to_sym => resource_fields)
+
+        relationship_fields.merge(serializer.json_key.to_sym => resource_fields)
       end
     end
   end

lib/active_model_serializers/adapter/json_api.rb

@@ -53,7 +53,7 @@ def self.fragment_cache(cached_hash, non_cached_hash, root = true)
       def initialize(serializer, options = {})
         super
         @include_directive = JSONAPI::IncludeDirective.new(options[:include], allow_wildcard: true)
-        @fieldset = options[:fieldset] || ActiveModel::Serializer::Fieldset.new(options.delete(:fields))
+        @fieldset = options[:fieldset] || fields_to_fieldset(options.delete(:fields))
       end
 
       # {http://jsonapi.org/format/#crud Requests are transactional, i.e. success or failure}
@@ -335,6 +335,7 @@ def resource_object_for(serializer, include_slice = {})
         resource_object
       end
 
+      # rubocop:disable Metrics/CyclomaticComplexity
       def data_for(serializer, include_slice)
         data = serializer.fetch(self) do
           resource_object = ResourceIdentifier.new(serializer, instance_options).as_json
@@ -348,11 +349,12 @@ def data_for(serializer, include_slice)
         data.tap do |resource_object|
           next if resource_object.nil?
           # NOTE(BF): the attributes are cached above, separately from the relationships, below.
-          requested_associations = fieldset.fields_for(resource_object[:type]) || '*'
+          requested_associations = (fieldset && fieldset.fields_for(resource_object[:type])) || '*'
           relationships = relationships_for(serializer, requested_associations, include_slice)
           resource_object[:relationships] = relationships if relationships.any?
         end
       end
+      # rubocop:enable Metrics/CyclomaticComplexity
 
       # {http://jsonapi.org/format/#document-resource-object-relationships Document Resource Object Relationship}
       # relationships
@@ -529,6 +531,12 @@ def pagination_links_for(serializer)
       def meta_for(serializer)
         Meta.new(serializer).as_json
       end
+
+      def fields_to_fieldset(fields)
+        return fields if fields.nil?
+
+        ActiveModel::Serializer::Fieldset.new(fields)
+      end
     end
   end
 end