Merge pull request #374 from alexislefebvre/chore-fix-errors-from-PHPStan

chore: fix errors from PHPStan, upgrade jakzal/phpqa

Author: alexislefebvre

.github/workflows/qa.yml

@@ -14,7 +14,7 @@ jobs:
         run: rm -v composer.json
 
       - name: PHP-CS-Fixer
-        uses: docker://jakzal/phpqa:1.113.8-php8.4-alpine
+        uses: docker://jakzal/phpqa:1.116.2-php8.4-alpine
         with:
           args: php-cs-fixer --config=./.qa/.php-cs-fixer.dist.php --dry-run --diff --no-interaction --ansi fix --show-progress none
 
@@ -29,7 +29,7 @@ jobs:
       # the Docker image will install the dependencies automatically
 
       -   name: ✅ PHPStan
-          uses: docker://jakzal/phpqa:1.113.8-php8.4-alpine
+          uses: docker://jakzal/phpqa:1.116.2-php8.4-alpine
           env:
               COMPOSER_IGNORE_PLATFORM_REQ: ext-mongodb
               # this will hide the output of the automatic call to `composer install`

.qa/phpstan.neon

@@ -1,5 +1,5 @@
 includes:
-  # it's provided by the $JAKZAL_IMAGE Docker image
+  # it's provided by the jakzal/phpqa Docker image
 #  - /tools/.composer/vendor-bin/phpstan/vendor/phpstan/phpstan-strict-rules/rules.neon
   - /tools/.composer/vendor-bin/phpstan/vendor/phpstan/phpstan-doctrine/extension.neon
   - /tools/.composer/vendor-bin/phpstan/vendor/phpstan/phpstan-symfony/extension.neon
@@ -30,13 +30,3 @@ parameters:
     -
       identifier: unset.possiblyHookedProperty
       path: ../tests/Test/
-    -
-      message: '#^Call to method arrayNode\(\) on an unknown class Symfony\\Component\\Config\\Definition\\Builder\\NodeBuilder\<Symfony\\Component\\Config\\Definition\\Builder\\ArrayNodeDefinition\>\.$#'
-      identifier: class.notFound
-      count: 1
-      path: ../src/DependencyInjection/Configuration.php
-    -
-      message: '#^Method Liip\\TestFixturesBundle\\DependencyInjection\\Configuration\:\:getConfigTreeBuilder\(\) return type with generic class Symfony\\Component\\Config\\Definition\\Builder\\TreeBuilder does not specify its types\: T$#'
-      identifier: missingType.generics
-      count: 1
-      path: ../src/DependencyInjection/Configuration.php

doc/contributing.md

@@ -61,13 +61,13 @@ docker-compose exec php bash -c "rm -rf tests/App*/var/cache/*"
 Use it through Docker:
 
 ```bash
-docker run --rm -it --volume .:/app --workdir /app jakzal/phpqa:1.113.8-php8.4-alpine php-cs-fixer --config=./.qa/.php-cs-fixer.dist.php --diff --no-interaction --ansi fix --show-progress none
+docker run --rm -it --volume .:/app --workdir /app jakzal/phpqa:1.116.2-php8.4-alpine php-cs-fixer --config=./.qa/.php-cs-fixer.dist.php --diff --no-interaction --ansi fix --show-progress none
 ```
 
 ## Run PHPStan
 
 Use it through Docker:
 
 ```bash
-docker run --rm -it --volume .:/app --workdir /app jakzal/phpqa:1.113.8-php8.4-alpine phpstan analyse --configuration ./.qa/phpstan.neon --no-progress
+docker run --rm -it --volume .:/app --workdir /app jakzal/phpqa:1.116.2-php8.4-alpine phpstan analyse --configuration ./.qa/phpstan.neon --no-progress
 ```