Skip to content

Commit 22c8601

Browse files
Merge pull request #374 from alexislefebvre/chore-fix-errors-from-PHPStan
chore: fix errors from PHPStan, upgrade jakzal/phpqa
2 parents 7533601 + ef50880 commit 22c8601

File tree

3 files changed

+5
-15
lines changed

3 files changed

+5
-15
lines changed

.github/workflows/qa.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ jobs:
1414
run: rm -v composer.json
1515

1616
- name: PHP-CS-Fixer
17-
uses: docker://jakzal/phpqa:1.113.8-php8.4-alpine
17+
uses: docker://jakzal/phpqa:1.116.2-php8.4-alpine
1818
with:
1919
args: php-cs-fixer --config=./.qa/.php-cs-fixer.dist.php --dry-run --diff --no-interaction --ansi fix --show-progress none
2020

@@ -29,7 +29,7 @@ jobs:
2929
# the Docker image will install the dependencies automatically
3030

3131
- name: ✅ PHPStan
32-
uses: docker://jakzal/phpqa:1.113.8-php8.4-alpine
32+
uses: docker://jakzal/phpqa:1.116.2-php8.4-alpine
3333
env:
3434
COMPOSER_IGNORE_PLATFORM_REQ: ext-mongodb
3535
# this will hide the output of the automatic call to `composer install`

.qa/phpstan.neon

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
includes:
2-
# it's provided by the $JAKZAL_IMAGE Docker image
2+
# it's provided by the jakzal/phpqa Docker image
33
# - /tools/.composer/vendor-bin/phpstan/vendor/phpstan/phpstan-strict-rules/rules.neon
44
- /tools/.composer/vendor-bin/phpstan/vendor/phpstan/phpstan-doctrine/extension.neon
55
- /tools/.composer/vendor-bin/phpstan/vendor/phpstan/phpstan-symfony/extension.neon
@@ -30,13 +30,3 @@ parameters:
3030
-
3131
identifier: unset.possiblyHookedProperty
3232
path: ../tests/Test/
33-
-
34-
message: '#^Call to method arrayNode\(\) on an unknown class Symfony\\Component\\Config\\Definition\\Builder\\NodeBuilder\<Symfony\\Component\\Config\\Definition\\Builder\\ArrayNodeDefinition\>\.$#'
35-
identifier: class.notFound
36-
count: 1
37-
path: ../src/DependencyInjection/Configuration.php
38-
-
39-
message: '#^Method Liip\\TestFixturesBundle\\DependencyInjection\\Configuration\:\:getConfigTreeBuilder\(\) return type with generic class Symfony\\Component\\Config\\Definition\\Builder\\TreeBuilder does not specify its types\: T$#'
40-
identifier: missingType.generics
41-
count: 1
42-
path: ../src/DependencyInjection/Configuration.php

doc/contributing.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -61,13 +61,13 @@ docker-compose exec php bash -c "rm -rf tests/App*/var/cache/*"
6161
Use it through Docker:
6262

6363
```bash
64-
docker run --rm -it --volume .:/app --workdir /app jakzal/phpqa:1.113.8-php8.4-alpine php-cs-fixer --config=./.qa/.php-cs-fixer.dist.php --diff --no-interaction --ansi fix --show-progress none
64+
docker run --rm -it --volume .:/app --workdir /app jakzal/phpqa:1.116.2-php8.4-alpine php-cs-fixer --config=./.qa/.php-cs-fixer.dist.php --diff --no-interaction --ansi fix --show-progress none
6565
```
6666

6767
## Run PHPStan
6868

6969
Use it through Docker:
7070

7171
```bash
72-
docker run --rm -it --volume .:/app --workdir /app jakzal/phpqa:1.113.8-php8.4-alpine phpstan analyse --configuration ./.qa/phpstan.neon --no-progress
72+
docker run --rm -it --volume .:/app --workdir /app jakzal/phpqa:1.116.2-php8.4-alpine phpstan analyse --configuration ./.qa/phpstan.neon --no-progress
7373
```

0 commit comments

Comments
 (0)