Skip to content

Commit 10f9687

Browse files
authored
Merge pull request #12 from Wovchena/remove-negative_prompt-from-signature
Remove negative_prompt from signature
2 parents 437ef7c + 0ace99e commit 10f9687

File tree

3 files changed

+5
-9
lines changed

3 files changed

+5
-9
lines changed

samples/cpp/video_generation/text2video.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ int main(int32_t argc, char* argv[]) {
5757
pipe.set_generation_config(config);
5858
auto output = pipe.generate(
5959
prompt,
60-
"worst quality, inconsistent motion, blurry, jittery, distorted",
60+
ov::genai::negative_prompt("worst quality, inconsistent motion, blurry, jittery, distorted"),
6161
ov::genai::height(512), // OVLTXPipeline's default
6262
ov::genai::width(704), // OVLTXPipeline's default
6363
ov::genai::num_inference_steps(10),

src/cpp/include/openvino/genai/video_generation/text2video_pipeline.hpp

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -28,23 +28,20 @@ class OPENVINO_GENAI_EXPORTS Text2VideoPipeline {
2828
/**
2929
* Generates image(s) based on prompt and other image generation parameters
3030
* @param positive_prompt Prompt to generate image(s) from
31-
* @param negative_prompt
3231
* @param properties Image generation parameters specified as properties. Values in 'properties' override default value for generation parameters.
3332
* @returns A tensor which has dimensions [num_images_per_prompt, height, width, 3]
3433
*/
3534
VideoGenerationResult generate(
3635
const std::string& positive_prompt,
37-
const std::string& negative_prompt = "",
3836
const ov::AnyMap& properties = {}
3937
);
4038

4139
template <typename... Properties>
4240
ov::util::EnableIfAllStringAny<VideoGenerationResult, Properties...> generate(
4341
const std::string& positive_prompt,
44-
const std::string& negative_prompt,
4542
Properties&&... properties
4643
) {
47-
return generate(positive_prompt, negative_prompt, ov::AnyMap{std::forward<Properties>(properties)...});
44+
return generate(positive_prompt, ov::AnyMap{std::forward<Properties>(properties)...});
4845
}
4946

5047
const VideoGenerationConfig& get_generation_config() const;

src/cpp/src/video_generation/text2video_pipeline.cpp

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -452,7 +452,7 @@ class Text2VideoPipeline::LTXPipeline {
452452
return out_vec[0]; // [B, F, H, W, C]
453453
}
454454

455-
VideoGenerationResult generate(const std::string& positive_prompt, const std::string& negative_prompt, const ov::AnyMap& properties = {}) {
455+
VideoGenerationResult generate(const std::string& positive_prompt, const ov::AnyMap& properties = {}) {
456456
const auto gen_start = std::chrono::steady_clock::now();
457457
m_perf_metrics.clean_up();
458458

@@ -473,7 +473,7 @@ class Text2VideoPipeline::LTXPipeline {
473473
callback = callback_iter->second.as<std::function<bool(size_t, size_t, ov::Tensor&)>>();
474474
}
475475

476-
compute_hidden_states(positive_prompt, negative_prompt, merged_generation_config);
476+
compute_hidden_states(positive_prompt, merged_generation_config.negative_prompt.value_or(""), merged_generation_config);
477477

478478
size_t num_channels_latents = m_transformer->get_config().in_channels;
479479
size_t spatial_compression_ratio = m_vae->get_config().patch_size * std::pow(2, std::reduce(m_vae->get_config().spatio_temporal_scaling.begin(), m_vae->get_config().spatio_temporal_scaling.end(), 0));
@@ -637,10 +637,9 @@ Text2VideoPipeline::Text2VideoPipeline(
637637

638638
VideoGenerationResult Text2VideoPipeline::generate(
639639
const std::string& positive_prompt,
640-
const std::string& negative_prompt,
641640
const ov::AnyMap& properties
642641
) {
643-
return m_impl->generate(positive_prompt, negative_prompt, properties);
642+
return m_impl->generate(positive_prompt, properties);
644643
}
645644

646645
const VideoGenerationConfig& Text2VideoPipeline::get_generation_config() const {

0 commit comments

Comments
 (0)