Skip to content

Commit c88afc9

Browse files
authored
Merge pull request #141 from lilt/4.x-fix-translations
Hotfix connector translation ids
2 parents 2449f97 + 94ea19d commit c88afc9

File tree

8 files changed

+15
-11
lines changed

8 files changed

+15
-11
lines changed

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,10 @@ All notable changes to this project will be documented in this file.
44

55
The format is based on [Keep a Changelog](http://keepachangelog.com/) and this project adheres to [Semantic Versioning](http://semver.org/).
66

7+
## 4.4.3 - 2023-11-15
8+
### Changed
9+
- Change translation limit for get translation request
10+
711
## 4.4.2 - 2023-11-15
812
### Fixed
913
- Lock release issue after queue message processing

composer.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
"name": "lilt/craft-lilt-plugin",
33
"description": "The Lilt plugin makes it easy for you to send content to Lilt for translation right from within Craft CMS.",
44
"type": "craft-plugin",
5-
"version": "4.4.2",
5+
"version": "4.4.3",
66
"keywords": [
77
"craft",
88
"cms",

e2e/cypress/support/flow/instant.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -109,15 +109,15 @@ Cypress.Commands.add('instantFlow', ({
109109
'name': 'Authorization', 'values': ['Bearer this_is_apy_key'],
110110
}], 'queryStringParameters': [
111111
{
112-
'name': 'limit', 'values': ['100'],
112+
'name': 'limit', 'values': ['1000'],
113113
}, {
114114
'name': 'start', 'values': ['00'],
115115
}, {
116116
'name': 'job_id', 'values': ['777'],
117117
}],
118118
}, 'httpResponse': {
119119
'statusCode': 200, 'body': JSON.stringify({
120-
'limit': 100, 'start': 0, 'results': translationsResult,
120+
'limit': 1000, 'start': 0, 'results': translationsResult,
121121
}),
122122
}, 'times': {
123123
'unlimited': true,

e2e/cypress/support/flow/verified.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -109,15 +109,15 @@ Cypress.Commands.add('verifiedFlow', ({
109109
'name': 'Authorization', 'values': ['Bearer this_is_apy_key'],
110110
}], 'queryStringParameters': [
111111
{
112-
'name': 'limit', 'values': ['100'],
112+
'name': 'limit', 'values': ['1000'],
113113
}, {
114114
'name': 'start', 'values': ['00'],
115115
}, {
116116
'name': 'job_id', 'values': ['777'],
117117
}],
118118
}, 'httpResponse': {
119119
'statusCode': 200, 'body': JSON.stringify({
120-
'limit': 100, 'start': 0, 'results': translationsResult,
120+
'limit': 1000, 'start': 0, 'results': translationsResult,
121121
}),
122122
}, 'times': {
123123
'unlimited': true,

src/services/repositories/external/ConnectorTranslationRepository.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ public function findByJobId(int $jobId): ConnectorTranslationsResponse
3232
}
3333

3434
$response = $this->apiInstance->servicesApiDeliveriesGetDeliveriesByJobId(
35-
100,
35+
1000,
3636
"00",
3737
$jobId
3838
);

tests/integration/controllers/job/GetSyncFromLiltControllerCest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -121,7 +121,7 @@ public function testSyncSuccess(IntegrationTester $I): void
121121
$I->expectTranslationsGetRequest(
122122
777,
123123
0,
124-
100,
124+
1000,
125125
HttpCode::OK,
126126
$responseBody
127127
);

tests/integration/modules/FetchJobStatusFromConnectorCest.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,7 @@ public function testExecuteSuccessVerified(IntegrationTester $I): void
109109
$I->expectTranslationsGetRequest(
110110
777,
111111
0,
112-
100,
112+
1000,
113113
HttpCode::OK,
114114
$responseBody
115115
);
@@ -240,7 +240,7 @@ public function testExecuteSuccessInstant(IntegrationTester $I): void
240240
$I->expectTranslationsGetRequest(
241241
777,
242242
0,
243-
100,
243+
1000,
244244
HttpCode::OK,
245245
$responseBody
246246
);

tests/integration/modules/FetchTranslationFromConnectorCest.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,7 @@ public function testExecuteInstantSuccess(IntegrationTester $I): void
9999
$I->expectTranslationsGetRequest(
100100
777,
101101
0,
102-
100,
102+
1000,
103103
HttpCode::OK,
104104
$translationsResponseBody
105105
);
@@ -241,7 +241,7 @@ public function testExecuteVerifiedSuccess(IntegrationTester $I): void
241241
$I->expectTranslationsGetRequest(
242242
777,
243243
0,
244-
100,
244+
1000,
245245
HttpCode::OK,
246246
$translationsResponseBody
247247
);

0 commit comments

Comments
 (0)