Skip to content

Commit d4d0618

Browse files
fix: Minor fixes about queue and cron
1 parent 93ff7df commit d4d0618

File tree

3 files changed

+11
-10
lines changed

3 files changed

+11
-10
lines changed

app/handlers/queue.go

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -116,11 +116,11 @@ func (h *QueueHandler) Index(c *fiber.Ctx) error {
116116
}
117117

118118
var queues []*models.Queue
119-
if err := h.db.Model(&models.Queue{}).
120-
Where("type = ?", c.Params("queue_type")).
121-
Where("data->>'extension_id' ?", extension_id).
122-
Where("data->>'server_id' ?", server_id).
123-
Where("data->>'user_id' ?", user_id).Find(&queues).Error; err != nil {
119+
if err := h.db.Debug().Model(&models.Queue{}).
120+
Where("type = ?", c.FormValue("queue_type")).
121+
Where("data->>'extension_id' = ?", extension_id).
122+
Where("data->>'server_id' = ?", server_id).
123+
Where("data->>'user_id' = ?", user_id).Find(&queues).Error; err != nil {
124124
return err
125125
}
126126

@@ -156,9 +156,9 @@ func (h *QueueHandler) Delete(c *fiber.Ctx) error {
156156
if err := h.db.Model(&models.Queue{}).
157157
Where("type = ?", c.FormValue("queue_type")).
158158
Where("id = ?", uid_).
159-
Where("data->>'extension_id' ?", extension_id).
160-
Where("data->>'server_id' ?", server_id).
161-
Where("data->>'user_id' ?", user_id).Delete(models.Queue{}).Error; err != nil {
159+
Where("data->>'extension_id' = ?", extension_id).
160+
Where("data->>'server_id' = ?", server_id).
161+
Where("data->>'user_id' = ?", user_id).Delete(models.Queue{}).Error; err != nil {
162162
return err
163163
}
164164

app/models/cron_job.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,7 @@ func (cj *CronJob) UpdateAsFailed(message string) {
5858

5959
func (cj *CronJob) UpdateAsDone(output string) {
6060
cj.Status = StatusDone
61+
cj.Output = output
6162
cj.Message = "CronJob completed successfully. Waiting for next run."
6263

6364
database.Connection().Model(cj).Save(cj)

internal/process_queue/create_report.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,7 @@ func (c CreateReport) Process() error {
106106

107107
if err := json.Unmarshal([]byte(output), &response); err != nil {
108108
// Update job as failed
109-
c.Queue.UpdateError(err.Error())
109+
c.Queue.UpdateError("error when unmarshalling json, output: " + output)
110110
return err
111111
}
112112

@@ -115,7 +115,7 @@ func (c CreateReport) Process() error {
115115
c.Queue.UpdateError(response.Message)
116116
} else {
117117
// Update job as done
118-
c.Queue.UpdateAsDone(strings.TrimSpace(strings.ReplaceAll(output, "\"", "")))
118+
c.Queue.UpdateAsDone(strings.TrimSpace(strings.ReplaceAll(response.Message, "\"", "")))
119119
}
120120

121121
return nil

0 commit comments

Comments
 (0)