Skip to content

Commit daa3065

Browse files
committed
fix: Error handling
1 parent 995c6e1 commit daa3065

File tree

4 files changed

+7
-4
lines changed

4 files changed

+7
-4
lines changed

.gitignore

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
.env
22
tmp/
33
grind.sh
4-
.air.toml
4+
.air.toml
5+
TODO

app/handlers/extension.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ import (
1212

1313
func ExtensionRunner(c *fiber.Ctx) error {
1414
if len(c.FormValue("extension_id")) < 1 {
15-
return logger.FiberError(fiber.StatusUnprocessableEntity, "extension not found")
15+
return logger.FiberError(fiber.StatusBadRequest, "extension not found")
1616
}
1717

1818
extension, err := liman.GetExtension(&models.Extension{

internal/sandbox/command_generator.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ func GenerateCommand(extension *models.Extension, credentials *models.Credential
2020
extension.Name = shellescape.StripUnsafe(extension.Name)
2121

2222
if !helpers.IsLetter(extension.Name) {
23-
return "", logger.FiberError(fiber.StatusUnprocessableEntity, "extension names can only contains letters")
23+
return "", logger.FiberError(fiber.StatusBadRequest, "extension names can only contains letters")
2424
}
2525

2626
server, user, settings, err := getParams(extension, credentials, params)

internal/server/error_handler.go

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,11 +13,13 @@ var ErrorHandler = func(c *fiber.Ctx, err error) error {
1313
message := &fiber.Map{}
1414
if code == fiber.StatusOK {
1515
message = &fiber.Map{
16+
"status": "ok",
1617
"message": err.Error(),
1718
}
1819
} else {
1920
message = &fiber.Map{
20-
"error": err.Error(),
21+
"status": "fail",
22+
"message": err.Error(),
2123
}
2224
}
2325

0 commit comments

Comments
 (0)