several updates

Author: arietimmerman

.github/workflows/ci.yml

@@ -35,6 +35,8 @@ jobs:
           # Wait for server to be ready
           timeout 60 bash -c 'until curl -f http://localhost:8000/scim/v2/Schemas; do sleep 2; done'
           
+          sed -i 's/requireAuthentication: true/requireAuthentication: false/' ./site/.vitepress/theme/components/config.yaml
+
           # Run scimverify tests against the server
           npx node ./bin/scimverify.js --config ./site/.vitepress/theme/components/config.yaml --base-url http://localhost:8000/scim/v2/ --auth-header "Bearer YOUR_TOKEN" 
           

site/.vitepress/theme/components/config.yaml

@@ -2,6 +2,7 @@ detectSchema: true
 detectResourceTypes: true
 verifyPagination: true
 verifySorting: true
+requireAuthentication: false
 
 users:
   enabled: true
@@ -317,8 +318,7 @@ groups:
                           "items":
                             {
                               "type": "object",
-                              "properties": { "value": { "type": "string" } },
-                            },
+                              "properties": { "value": { "type": ["string", "number"] } },                   },
                         },
                     },
                   "required": ["displayName", "members"],
@@ -365,8 +365,7 @@ groups:
                           "items":
                             {
                               "type": "object",
-                              "properties": { "value": { "type": "string" } },
-                            },
+                              "properties": { "value": { "type": ["string", "number"] } },                   },
                         },
                     },
                   "required": ["displayName", "members"],

src/basics.js

@@ -20,15 +20,17 @@ function runTests(config) {
             );
         });
 
-        test('Authentication should be required for /Users', async function (t) {
-            const axios = getAxiosInstance(config, t);
-            const response = await axios.get('/Users', {
-                headers: {
-                    'Authorization': null
-                }
+        if (config?.requireAuthentication !== false) {
+            test('Authentication should be required for /Users', async function (t) {
+                const axios = getAxiosInstance(config, t);
+                const response = await axios.get('/Users', {
+                    headers: {
+                        'Authorization': null
+                    }
+                });
+                assert.ok([401, 403].includes(response.status), 'Expected 401 Unauthorized or 403 Forbidden status');
             });
-            assert.ok([401, 403].includes(response.status), 'Expected 401 Unauthorized or 403 Forbidden status');
-        });
+        }
     });
 }
 

src/groups.js

@@ -174,9 +174,9 @@ function runTests(groupSchema, groupSchemaExtensions = [], configuration) {
                 };
 
                 const response = await testAxios.post('/Groups', newGroup);
-                assert.strictEqual(response.status, '400', 'Creating an invalid group should return status code 400');
+                assert.strictEqual(response.status, 400, 'Creating an invalid group should return status code 400');
                 assert.strictEqual(response.data.scimType, "invalidSyntax", 'Error should have scimType set to invalidSyntax');
-                assert.strictEqual(response.data.status, '400', 'Error response status should match HTTP status code');
+                assert.strictEqual(response.data.status, 400, 'Error response status should match HTTP status code');
                 assert.strictEqual(response.data.schemas[0], 'urn:ietf:params:scim:api:messages:2.0:Error', 'Error response should contain the correct error schema');
             });
         }
@@ -264,7 +264,12 @@ function runTests(groupSchema, groupSchemaExtensions = [], configuration) {
                 });
                 assert.strictEqual(patchResponse.status, 200, 'PATCH /Groups/{id} should return status code 200 when assigning a user to a group');
                 assert.strictEqual(patchResponse.data.schemas[0], 'urn:ietf:params:scim:schemas:core:2.0:Group', 'Response should contain the correct schema');
-                assert.ok(patchResponse.data.members.some(member => member.value === user.id), 'User should be assigned to the group');
+                assert.ok(
+                    getResourceAttributeValue(patchResponse.data, 'members').some(
+                        member => String(member.value) === String(user.id)
+                    ),
+                    'User should be assigned to the group'
+                );
             });
         }