Fixing tests.

Author: christian-oreilly

pylossless/conftest.py

@@ -18,7 +18,7 @@
 def pipeline_fixture():
     """Return a namedTuple containing MNE eyetracking raw data and events."""
     raw, config, bids_path = load_openneuro_bids()
-    raw.crop(tmin=0, tmax=60)  # take 60 seconds for speed
+    # raw.crop(tmin=0, tmax=60)  # Too short for ICA to converge in some tests.
     annots = Annotations(
         onset=[1, 15], duration=[1, 1], description=["test_annot", "test_annot"]
     )
@@ -28,6 +28,7 @@ def pipeline_fixture():
     config["find_breaks"]["min_break_duration"] = 9
     config["find_breaks"]["t_start_after_previous"] = 1
     config["find_breaks"]["t_stop_before_next"] = 0
+    config["ica"]["ica_args"]["run1"]["max_iter"] = 5000
     config.save("test_config.yaml")
     pipeline = ll.LosslessPipeline("test_config.yaml")
     not_in_1020 = ["EXG1", "EXG2", "EXG3", "EXG4", "EXG5", "EXG6", "EXG7", "EXG8"]

pylossless/datasets/datasets.py

@@ -33,7 +33,10 @@ def load_openneuro_bids(subject="pd6"):
     openneuro = ll.utils.import_optional_dependency("openneuro")
 
     config = ll.config.Config()
-    config.load_default()
+    # TODO: Tests were developed using this configuration. The adult version
+    # should probably be used instead, but this change will require fixing the
+    # tests accordingly.
+    config.load_default("infants")
     config["project"]["bids_montage"] = ""
     config["project"]["analysis_montage"] = "standard_1020"
     config["project"]["set_montage_kwargs"]["on_missing"] = "warn"

pylossless/tests/test_utils.py

@@ -5,14 +5,18 @@ def test_import_optional_dependency():
     from pylossless.utils import check
 
     # Test the case where the package is not installed.
-    with pytest.raises(ImportError, match="Missing optional dependency 'astropy'."):
-        # choosing a package that will probably never be added to the requirements!
-        check.import_optional_dependency("astropy")
+    package = "sdgssfersfsdesdfsefsdfsdt"
+    with pytest.raises(ImportError, match=f"Missing optional dependency '{package}'."):
+        # Choosing a package that will probably never be added to the requirements!
+        # We also choose a name of a package that is likely not to exist at all
+        # to avoid the corresponding package is installed in the development
+        # environment of developpers.
+        check.import_optional_dependency(package)
 
     # Test the case where the package is installed.
     mne = check.import_optional_dependency("mne", raise_error=False)
     assert mne is not None
 
     # Test the where case package is not installed but we don't want to raise an error.
-    astropy = check.import_optional_dependency("astropy", raise_error=False)
-    assert astropy is None
+    ret_val = check.import_optional_dependency(package, raise_error=False)
+    assert ret_val is None