@@ -272,8 +272,8 @@ def find_bads_by_threshold(epochs, threshold=5e-5):
272272 >>> epochs = mne.make_fixed_length_epochs(raw, preload=True)
273273 >>> bad_chs = ll.pipeline.find_bads_by_threshold(epochs)
274274 """
275- # XXX : We should make this function handle multiple channel types.
276- # XXX : but I'd like to avoid making a copy of the epochs object
275+ # TODO : We should make this function handle multiple channel types.
276+ # TODO : but I'd like to avoid making a copy of the epochs object
277277 ch_types = np .unique (epochs .get_channel_types ()).tolist ()
278278 if len (ch_types ) > 1 :
279279 warn (
@@ -823,7 +823,6 @@ def _flag_volt_std(self, flag_dim, threshold=5e-5, picks="eeg"):
823823 on. You may need to assess a more appropriate value for your own data.
824824 """
825825 epochs = self .get_epochs (picks = picks )
826- # So yes this add a few LOC, but IMO it's worth it for readability
827826 if flag_dim == "ch" :
828827 above_threshold = find_bads_by_threshold (epochs , threshold = threshold )
829828 if above_threshold .any ():
@@ -1367,7 +1366,10 @@ def _run(self):
13671366 msg = "Flagging Channels by fixed threshold"
13681367 kwargs = dict (picks = picks , message = msg )
13691368 if "threshold" in self .config ["flag_channels_fixed_threshold" ]:
1370- kwargs ["threshold" ] = self .config ["flag_channels_fixed_threshold" ]["threshold" ]
1369+ threshold = self .config ["flag_channels_fixed_threshold" ][
1370+ "threshold"
1371+ ]
1372+ kwargs ["threshold" ] = threshold
13711373 self .flag_channels_fixed_threshold (** kwargs )
13721374
13731375 # 3.flag channels based on large Stdev. across time
0 commit comments