Skip to content

Commit 9354f88

Browse files
Apply suggestions from Christian O'Reilly code review
- Change API form `inst` to `epochs | None` - if `None`, then make epochs from self.raw - No need check and raise type error now. Co-authored-by: Christian O'Reilly <[email protected]>
1 parent 9afe0fe commit 9354f88

File tree

1 file changed

+4
-7
lines changed

1 file changed

+4
-7
lines changed

pylossless/pipeline.py

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -770,12 +770,12 @@ def _flag_volt_std(self, flag_dim, threshold=5e-5, picks="eeg"):
770770
)
771771
self.flags[flag_dim].add_flag_cat("volt_std", above_threshold, epochs)
772772

773-
def find_outlier_chs(self, inst, picks="eeg"):
773+
def find_outlier_chs(self, epochs, picks="eeg"):
774774
"""Detect outlier Channels to leave out of rereference.
775775
776776
Parameters
777777
----------
778-
inst : mne.Epochs
778+
epochs : mne.Epochs | None
779779
an instance of mne.Epochs.
780780
picks : str (default "eeg")
781781
Channels to include in the outlier detection process. You can pass any
@@ -796,12 +796,9 @@ def find_outlier_chs(self, inst, picks="eeg"):
796796
"""
797797
# TODO: Reuse _detect_outliers here.
798798
logger.info("🔍 Detecting channels to leave out of reference.")
799-
if isinstance(inst, mne.Epochs):
800-
epochs = inst
801-
else:
802-
raise TypeError(
799+
if epochs is None:
800+
epochs = self.get_epochs(rereference=False, picks=picks)
803801
"inst must be an instance of mne.Epochs," f" but got {type(inst)}."
804-
)
805802
epochs_xr = epochs_to_xr(epochs, kind="ch")
806803

807804
# Determines comically bad channels,

0 commit comments

Comments
 (0)