Updating the default config to be compatible with adult recordings. #173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #173 +/- ##
==========================================
- Coverage 71.93% 71.90% -0.04%
==========================================
Files 22 22
Lines 1176 1178 +2
==========================================
+ Hits 846 847 +1
- Misses 330 331 +1 ☔ View full report in Codecov by Sentry. |
scott-huberty
approved these changes
Nov 10, 2024
Member
scott-huberty
left a comment
scott-huberty
left a comment
There was a problem hiding this comment.
Thanks @christian-oreilly !!!
| with pytest.raises(ImportError, match="Missing optional dependency 'astropy'."): | ||
| # choosing a package that will probably never be added to the requirements! | ||
| check.import_optional_dependency("astropy") | ||
| package = "sdgssfersfsdesdfsefsdfsdt" |
Andesha
pushed a commit
to Andesha/pylossless
that referenced
this pull request
Mar 31, 2025
…ina-usc#173) * Updating the default config to be compatible with adult recordings. * Code linting. * Fixing tests. * Fixing spelling. * Fixing simulation test.
Andesha
pushed a commit
to Andesha/pylossless
that referenced
this pull request
Apr 1, 2025
…ina-usc#173) * Updating the default config to be compatible with adult recordings. * Code linting. * Fixing tests. * Fixing spelling. * Fixing simulation test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our default configuration came from the EEG-IP project. This project is in infants which have notoriously noisy data. These parameters are not optimal for adult defaults and the default configuration should not be for such a specific population. This PR creates two configs, one for adults and one for infants. It provides the capability to load the infant default config, but if nothing is specified, it will load the adult default config. It also cleans up some unused arguments in these config files.