Fix bug issue #175 #176
Merged
Fix bug issue #175 #176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #176 +/- ##
==========================================
+ Coverage 71.90% 73.68% +1.78%
==========================================
Files 22 22
Lines 1178 1178
==========================================
+ Hits 847 868 +21
+ Misses 331 310 -21 ☔ View full report in Codecov by Sentry. |
scott-huberty
approved these changes
Nov 11, 2024
Member
scott-huberty
left a comment
scott-huberty
left a comment
There was a problem hiding this comment.
Thanks @christian-oreilly ! 🙏 🚀
Co-authored-by: Scott Huberty <[email protected]>
Co-authored-by: Scott Huberty <[email protected]>
Co-authored-by: Scott Huberty <[email protected]>
| bids_root=tmp_path / "bids_dataset", | ||
| overwrite=True | ||
| ) | ||
| shutil.rmtree(tmp_path / "bids_dataset") |
Member
There was a problem hiding this comment.
FYI the shutil.rmtree isn't actually necessary because tmp_path is a magic pytest fixture and will tear down the temporary directory for you 🙂
christian-oreilly
deleted the
175-typeerror-write_raw_bids-got-an-unexpected-keyword-argument-events_data
branch
Member
|
Thanks @christian-oreilly ! |
Andesha
pushed a commit
to Andesha/pylossless
that referenced
this pull request
Mar 31, 2025
* Fix bug issue lina-usc#175 * Code linting. * Update pylossless/tests/test_bids.py Co-authored-by: Scott Huberty <[email protected]> * Update pylossless/tests/test_bids.py Co-authored-by: Scott Huberty <[email protected]> * Update pylossless/tests/test_bids.py Co-authored-by: Scott Huberty <[email protected]> * Remove print, clean test files, rename test. --------- Co-authored-by: Scott Huberty <[email protected]>
Andesha
pushed a commit
to Andesha/pylossless
that referenced
this pull request
Apr 1, 2025
* Fix bug issue lina-usc#175 * Code linting. * Update pylossless/tests/test_bids.py Co-authored-by: Scott Huberty <[email protected]> * Update pylossless/tests/test_bids.py Co-authored-by: Scott Huberty <[email protected]> * Update pylossless/tests/test_bids.py Co-authored-by: Scott Huberty <[email protected]> * Remove print, clean test files, rename test. --------- Co-authored-by: Scott Huberty <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #175