Skip to content

Conversation

@christian-oreilly
Copy link
Member

Closes #123.

@christian-oreilly christian-oreilly linked an issue Nov 11, 2024 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Nov 11, 2024

Codecov Report

Attention: Patch coverage is 91.30435% with 2 lines in your changes missing coverage. Please review.

Project coverage is 73.95%. Comparing base (645cb12) to head (c7e355f).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pylossless/pipeline.py 90.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #177      +/-   ##
==========================================
+ Coverage   73.68%   73.95%   +0.26%     
==========================================
  Files          22       22              
  Lines        1178     1194      +16     
==========================================
+ Hits          868      883      +15     
- Misses        310      311       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@scott-huberty
Copy link
Member

scott-huberty commented Nov 11, 2024

Thanks @christian-oreilly ! I'm fine with the failing Codecov patch (-0.11%) is nothing to sweat IMO

@christian-oreilly christian-oreilly merged commit ec1cedb into main Nov 11, 2024
8 checks passed
@christian-oreilly christian-oreilly deleted the 123-make-the-losslesspipeline-constructor-more-user-friendly branch November 11, 2024 23:28
Andesha pushed a commit to Andesha/pylossless that referenced this pull request Mar 31, 2025
* Fixing issues 123.

* Fixing coverage.

* Linting
Andesha pushed a commit to Andesha/pylossless that referenced this pull request Apr 1, 2025
* Fixing issues 123.

* Fixing coverage.

* Linting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make the LosslessPipeline constructor more user-friendly

3 participants