Skip to content

Conversation

@christian-oreilly
Copy link
Member

@christian-oreilly christian-oreilly commented Nov 12, 2024

Closes #157

@christian-oreilly christian-oreilly linked an issue Nov 12, 2024 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Nov 13, 2024

Codecov Report

Attention: Patch coverage is 96.07843% with 2 lines in your changes missing coverage. Please review.

Project coverage is 78.74%. Comparing base (ec1cedb) to head (0e8d213).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
pylossless/datasets/datasets.py 66.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #178      +/-   ##
==========================================
+ Coverage   73.95%   78.74%   +4.78%     
==========================================
  Files          22       22              
  Lines        1194     1223      +29     
==========================================
+ Hits          883      963      +80     
+ Misses        311      260      -51     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@scott-huberty
Copy link
Member

Thanks @christian-oreilly ! I just did some minor linting in 0e8d213, mostly whitespace around operators (which I'm surprised ruff doesn't complain about).

@scott-huberty scott-huberty self-requested a review November 13, 2024 16:35
@christian-oreilly
Copy link
Member Author

Agreed. I also prefer the spaced version! Thanks for the review!

@christian-oreilly christian-oreilly merged commit 68c1784 into main Nov 13, 2024
8 checks passed
@christian-oreilly christian-oreilly deleted the 157-loading-of-flags-is-empty branch November 13, 2024 16:46
Andesha pushed a commit to Andesha/pylossless that referenced this pull request Mar 31, 2025
* Adding test for flags after loading.

* Fix loading epoch flags.

* STY: minor linting

---------

Co-authored-by: Scott Huberty <[email protected]>
Andesha pushed a commit to Andesha/pylossless that referenced this pull request Apr 1, 2025
* Adding test for flags after loading.

* Fix loading epoch flags.

* STY: minor linting

---------

Co-authored-by: Scott Huberty <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Loading of flags is empty

3 participants