Skip to content

Conversation

@christian-oreilly
Copy link
Member

Closes #64

@codecov
Copy link

codecov bot commented Nov 27, 2024

Codecov Report

Attention: Patch coverage is 92.06349% with 5 lines in your changes missing coverage. Please review.

Project coverage is 80.81%. Comparing base (5236a77) to head (c101722).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pylossless/pipeline.py 91.07% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #191      +/-   ##
==========================================
+ Coverage   80.50%   80.81%   +0.30%     
==========================================
  Files          22       22              
  Lines        1262     1282      +20     
==========================================
+ Hits         1016     1036      +20     
  Misses        246      246              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@christian-oreilly
Copy link
Member Author

The commit message is not accurate; it is not running ICA only for EEG, but ICALabel only for EEG. ICA can be run for MEG too, but ICALabel will not be ran.

Copy link
Member

@scott-huberty scott-huberty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @christian-oreilly ! I only had time to take a brief look, but see that you added a test (which is passing), so am +1 for merging!

@christian-oreilly christian-oreilly merged commit c647153 into main Nov 27, 2024
8 checks passed
@christian-oreilly christian-oreilly deleted the multimodality branch November 27, 2024 20:29
@christian-oreilly
Copy link
Member Author

Thanks for the review, @scott-huberty !

Andesha pushed a commit to Andesha/pylossless that referenced this pull request Mar 31, 2025
* Supporting multimodal datasets.

* Linting

* Running ICALabel only for EEG.
Andesha pushed a commit to Andesha/pylossless that referenced this pull request Apr 1, 2025
* Supporting multimodal datasets.

* Linting

* Running ICALabel only for EEG.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Handling Multi-modal recordings

3 participants