You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: openspec/changes/switch-default-database-to-postgres/tasks.md
+2Lines changed: 2 additions & 0 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -229,6 +229,7 @@
229
229
- FB-19 verification passed after adding SQLite translation debug diagnostics for skipped `COMMENT ON TABLE/COLUMN` statements and explicit index-preservation coverage: `cd apps/lina-core && go test -count=1 ./pkg/dialect/internal/sqlite`; `cd apps/lina-core && go test -count=1 ./pkg/dialect`; `cd apps/lina-core && go test -run 'TestTranslateDDLDropsCommentsWithDebugLogPreservingIndexes|TestSQLiteTranslateDDLExecutesPostgreSQLFixture' -count=3 ./pkg/dialect/internal/sqlite ./pkg/dialect`; and `openspec validate switch-default-database-to-postgres`. Review found no issues: the logger uses the propagated translation context, comment filtering remains scoped to PostgreSQL comment metadata, and `CREATE INDEX` / `CREATE UNIQUE INDEX` / `DROP INDEX` / `REINDEX` statements stay on the compatible SQL path. i18n resources, runtime cache behavior, API behavior, and role data-permission behavior are unchanged.
230
230
- FB-20 verification passed after converting the `apps/lina-core/Makefile` terminal/help-facing Chinese text to English: `rg -n "[\\p{Han}]" apps/lina-core/Makefile` returned no matches; `make -C apps/lina-core init` printed the English confirmation guidance; and `openspec validate switch-default-database-to-postgres` passed. This is a project governance feedback item, so no unit test or E2E test is required; runtime behavior, API behavior, cache behavior, data-permission behavior, and i18n resources are unchanged.
231
231
- FB-21 verification passed after moving the remaining root `Makefile` command implementations into `hack/makefiles`: `make help`; `make -n init confirm=init`; and `make -n mock confirm=mock` all passed. A root target scan confirmed the root `Makefile` now only keeps shared variables and split makefile includes. This is a project governance feedback item, so no unit test or E2E test is required; runtime behavior, API behavior, cache behavior, data-permission behavior, and i18n resources are unchanged.
232
+
- FB-22 verification passed after resolving opened tab titles from stable runtime i18n keys at render time: `cd apps/lina-vben && pnpm -F @lina/web-antd run typecheck`; `cd hack/tests && pnpm run test:validate`; `cd hack/tests && E2E_BROWSER_CHANNEL=chrome pnpm exec playwright test e2e/i18n/TC0177-tab-title-language-switch.ts`; and `openspec validate switch-default-database-to-postgres`. i18n impact is limited to frontend tab title relocalization behavior; no runtime language resource, backend API, cache behavior, or role data-permission behavior changed.
232
233
233
234
## Feedback
234
235
@@ -253,3 +254,4 @@
253
254
-[x]**FB-19**: SQLite SQL 翻译器丢弃 `COMMENT ON TABLE/COLUMN` 注释语句时输出 Debug 日志,并确保创建和更新索引语句不会被误丢弃
0 commit comments