Commit 5567e0d
authored
Introduce
Motivation:
When integrating cross-cutting server concerns (e.g., xDS-driven TLS,
service decorators, server listeners), users currently need to call
multiple `ServerBuilder` methods individually. There's no way to bundle
these concerns into a reusable unit that also participates in
`Server.reconfigure()` and gets cleaned up on server stop.
Modifications:
- Added `ServerPlugin` interface (extends `SafeCloseable`) with a single
`install(ServerBuilder)` method.
- Added `ServerBuilder.plugin(ServerPlugin)` to register plugins at
build time.
- In `ServerBuilder.build()`, call `plugin.install(this)` for each
registered plugin before building the server config.
- In `Server.reconfigure()`, re-install all plugins on the new
`ServerBuilder` after the `ServerConfigurator` runs.
- In `Server.finishDoStop()`, close plugins via the existing
`ShutdownSupport` machinery.
- Added `ServerPluginTest` covering install-on-build,
install-on-reconfigure, close-on-stop, ordering, and builder
modification.
Result:
- Users can encapsulate multi-concern server configuration into a single
`ServerPlugin` and register it with `ServerBuilder.plugin(plugin)`.
- Plugins are automatically re-installed during `Server.reconfigure()`
and closed when the server stops.ServerPlugin (#6825)1 parent 87a2533 commit 5567e0d
4 files changed
Lines changed: 344 additions & 2 deletions
File tree
- core/src
- main/java/com/linecorp/armeria/server
- test/java/com/linecorp/armeria/server
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
113 | 113 | | |
114 | 114 | | |
115 | 115 | | |
| 116 | + | |
116 | 117 | | |
117 | 118 | | |
118 | 119 | | |
119 | 120 | | |
120 | 121 | | |
121 | 122 | | |
122 | | - | |
| 123 | + | |
123 | 124 | | |
124 | 125 | | |
125 | 126 | | |
126 | 127 | | |
| 128 | + | |
127 | 129 | | |
128 | 130 | | |
129 | 131 | | |
| |||
418 | 420 | | |
419 | 421 | | |
420 | 422 | | |
| 423 | + | |
421 | 424 | | |
422 | 425 | | |
423 | 426 | | |
| |||
720 | 723 | | |
721 | 724 | | |
722 | 725 | | |
| 726 | + | |
| 727 | + | |
| 728 | + | |
723 | 729 | | |
724 | 730 | | |
725 | 731 | | |
| |||
Lines changed: 38 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
44 | 44 | | |
45 | 45 | | |
46 | 46 | | |
| 47 | + | |
47 | 48 | | |
48 | 49 | | |
49 | 50 | | |
50 | 51 | | |
| 52 | + | |
51 | 53 | | |
52 | 54 | | |
53 | 55 | | |
| |||
245 | 247 | | |
246 | 248 | | |
247 | 249 | | |
| 250 | + | |
| 251 | + | |
| 252 | + | |
248 | 253 | | |
249 | 254 | | |
250 | 255 | | |
| |||
532 | 537 | | |
533 | 538 | | |
534 | 539 | | |
| 540 | + | |
| 541 | + | |
| 542 | + | |
| 543 | + | |
| 544 | + | |
| 545 | + | |
| 546 | + | |
| 547 | + | |
| 548 | + | |
| 549 | + | |
| 550 | + | |
| 551 | + | |
| 552 | + | |
| 553 | + | |
| 554 | + | |
| 555 | + | |
| 556 | + | |
| 557 | + | |
| 558 | + | |
535 | 559 | | |
536 | 560 | | |
537 | 561 | | |
| |||
2466 | 2490 | | |
2467 | 2491 | | |
2468 | 2492 | | |
2469 | | - | |
| 2493 | + | |
| 2494 | + | |
| 2495 | + | |
2470 | 2496 | | |
2471 | 2497 | | |
2472 | 2498 | | |
2473 | 2499 | | |
| 2500 | + | |
| 2501 | + | |
| 2502 | + | |
| 2503 | + | |
| 2504 | + | |
| 2505 | + | |
| 2506 | + | |
| 2507 | + | |
| 2508 | + | |
| 2509 | + | |
| 2510 | + | |
2474 | 2511 | | |
2475 | 2512 | | |
2476 | 2513 | | |
| |||
Lines changed: 69 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
0 commit comments