Skip to content

Commit 835ccaf

Browse files
authored
(Thrift Field Masker Pt1) Remove redundant thrift files (#6310)
Motivation: While adding test cases for thrift, I found it inconvenient to update thrift messages for each module (thrift0.9, thrift0.12, and thrift 0.13). When diffing each file, the only difference I found for thrift0.9 was `i8` was used instead of `byte`. I propose that thrift0.13 IDL definitions are used across all versions. To accomodate thrift0.9, a new `thrift9ify` task is added. Modifications: - Removed thrift IDL definitions for thrift0.9, thrift0.12. Result: - It is easier to define thrift messages for tests <!-- Visit this URL to learn more about how to write a pull request description: https://armeria.dev/community/developer-guide#how-to-write-pull-request-description -->
1 parent 90ba429 commit 835ccaf

12 files changed

Lines changed: 12 additions & 2566 deletions

File tree

thrift/thrift0.12/build.gradle

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,7 @@ tasks.processTestResources.from "${rootProject.projectDir}/thrift/thrift0.13/src
4646
def thriftFullVersion = libs.thrift012.get().versionConstraint.requiredVersion
4747
ext {
4848
thriftVersion = thriftFullVersion.substring(0, thriftFullVersion.lastIndexOf('.'))
49+
testThriftSrcDirs = ["${rootProject.projectDir}/thrift/thrift0.13/src/test/thrift"]
4950
}
5051

5152
// Disable checkstyle because it's checked by ':thrift0.13'.

thrift/thrift0.12/src/test/thrift/RpcDebugTest.thrift

Lines changed: 0 additions & 21 deletions
This file was deleted.

thrift/thrift0.12/src/test/thrift/TTextProtocolTest.thrift

Lines changed: 0 additions & 118 deletions
This file was deleted.

thrift/thrift0.12/src/test/thrift/TreeStructTest.thrift

Lines changed: 0 additions & 27 deletions
This file was deleted.

0 commit comments

Comments
 (0)