Test failure: `com.linecorp.armeria.spring.client.ArmeriaHttpExchangeAdapterTest.greetingWithAbsoluteUri()`

[ikhoon]

org.awaitility.core.ConditionTimeoutException: Assertion condition defined as a Lambda expression in com.linecorp.armeria.spring.client.ArmeriaHttpExchangeAdapterTest 
Expecting code not to raise a throwable but caught
  "java.util.concurrent.CompletionException: java.net.BindException: Address already in use: bind
	at java.base/java.util.concurrent.CompletableFuture.wrapInCompletionException(CompletableFuture.java:323)
	at java.base/java.util.concurrent.CompletableFuture.reportJoin(CompletableFuture.java:457)
	at java.base/java.util.concurrent.CompletableFuture.join(CompletableFuture.java:2139)
	at com.linecorp.armeria.common.util.EventLoopCheckingFuture.join(EventLoopCheckingFuture.java:86)
	at com.linecorp.armeria.spring.client.ArmeriaHttpExchangeAdapterTest.lambda$greetingWithAbsoluteUri$2(ArmeriaHttpExchangeAdapterTest.java:211)
	at org.assertj.core.api.ThrowableAssert.catchThrowable(ThrowableAssert.java:66)
	at org.assertj.core.api.AssertionsForClassTypes.catchThrowable(AssertionsForClassTypes.java:908)
	at org.assertj.core.api.AssertionsForClassTypes.assertThatCode(AssertionsForClassTypes.java:879)
	at org.assertj.core.api.Assertions.assertThatCode(Assertions.java:1396)
	at com.linecorp.armeria.spring.client.ArmeriaHttpExchangeAdapterTest.lambda$greetingWithAbsoluteUri$1(ArmeriaHttpExchangeAdapterTest.java:211)
	at org.awaitility.core.AssertionCondition.lambda$new$0(AssertionCondition.java:53)
	at org.awaitility.core.ConditionAwaiter$ConditionPoller.call(ConditionAwaiter.java:248)
	at org.awaitility.core.ConditionAwaiter$ConditionPoller.call(ConditionAwaiter.java:235)
	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:328)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1090)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:614)
	at java.base/java.lang.Thread.run(Thread.java:1474)
Caused by: java.net.BindException: Address already in use: bind
	at java.base/sun.nio.ch.Net.bind0(Native Method)
	at java.base/sun.nio.ch.Net.bind(Net.java:522)
	at java.base/sun.nio.ch.ServerSocketChannelImpl.netBind(ServerSocketChannelImpl.java:350)
	at java.base/sun.nio.ch.ServerSocketChannelImpl.bind(ServerSocketChannelImpl.java:310)
	at io.netty.channel.socket.nio.NioServerSocketChannel.doBind(NioServerSocketChannel.java:148)
	at io.netty.channel.AbstractChannel$AbstractUnsafe.bind(AbstractChannel.java:431)
	at io.netty.channel.DefaultChannelPipeline$HeadContext.bind(DefaultChannelPipeline.java:1353)
	at io.netty.channel.AbstractChannelHandlerContext.bind(AbstractChannelHandlerContext.java:500)
	at io.netty.channel.DefaultChannelPipeline.bind(DefaultChannelPipeline.java:994)
	at io.netty.channel.Channel.bind(Channel.java:302)
	at io.netty.bootstrap.AbstractBootstrap$1.run(AbstractBootstrap.java:381)
	at io.netty.util.concurrent.AbstractEventExecutor.runTask(AbstractEventExecutor.java:148)
	at io.netty.util.concurrent.AbstractEventExecutor.safeExecute(AbstractEventExecutor.java:141)
	at io.netty.util.concurrent.SingleThreadEventExecutor.runAllTasks(SingleThreadEventExecutor.java:535)
	at io.netty.channel.SingleThreadIoEventLoop.run(SingleThreadIoEventLoop.java:201)
	at io.netty.util.concurrent.SingleThreadEventExecutor$5.run(SingleThreadEventExecutor.java:1195)
	at io.netty.util.internal.ThreadExecutorMap$2.run(ThreadExecutorMap.java:74)
	at io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
	... 1 more
" within 10 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:119)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:31)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1160)
	at org.awaitility.core.ConditionFactory.untilAsserted(ConditionFactory.java:790)
	at com.linecorp.armeria.spring.client.ArmeriaHttpExchangeAdapterTest.greetingWithAbsoluteUri(ArmeriaHttpExchangeAdapterTest.java:210)
	at java.base/java.lang.reflect.Method.invoke(Method.java:565)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1604)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1604)
Caused by: java.util.concurrent.TimeoutException
	at java.base/java.util.concurrent.FutureTask.get(FutureTask.java:206)
	at org.awaitility.core.Uninterruptibles.getUninterruptibly(Uninterruptibles.java:101)
	at org.awaitility.core.Uninterruptibles.getUninterruptibly(Uninterruptibles.java:81)
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:103)
	... 8 more

[kwondh5217]

I investigated this and it seems the issue is that the hardcoded port 65493 is already in use. I reproduced this locally by holding 65493 from another process; the failure is identical.

Would it make sense to handle the port dynamically? For example, letting the OS pick the port and injecting it via Spring's embeddedValueResolver :

- @GetExchange("http://foo.com:65493/greeting")
+ @GetExchange("http://foo.com:${absoluteUri.port}/greeting")
  Mono<String> getGreetingAbsoluteUri();

final Server server = Server.builder().http(0).service(...).build();
server.start().join();
final int port = server.activeLocalPort();

final Service service =
        HttpServiceProxyFactory.builderFor(adapter)
                               .embeddedValueResolver(value -> value == null ? null
                                       : value.replace("${absoluteUri.port}",
                                                       String.valueOf(port)))
                               .build()
                               .createClient(Service.class);