NO-ISSUE: Fix form param keys for openapi-generator#823
Draft
mokuzon wants to merge 3 commits into
Draft
Conversation
6d2ab46 to
610fd0b
Compare
610fd0b to
f9ebe70
Compare
cec5fc7 to
eb1e4bf
Compare
ba9bbeb to
9d20e66
Compare
ea77e56 to
541b70a
Compare
mokuzon
commented
May 19, 2026
| {{/collectionFormat}} | ||
| if (${{paramName}} !== null) { | ||
| $resourcePath = str_replace( | ||
| '{' . '{{baseName}}' . '}', |
Author
There was a problem hiding this comment.
このテンプレートのカスタマイズ箇所はこの1行のみ
openapi-generator 7.22.0 の元の api.mustache と比較すると、差分はこの 643 行目のみです。
# Line 643 (path param URL substitution)
- {{=<< >>=}}'{<<baseName>>}'<<={{ }}=>>, # 7.22.0 upstream
+ '{' . '{{baseName}}' . '}', # custom両者ともパスパラメータの置換用文字列 (例: '{audienceGroupId}') を生成しますが、生成される PHP コードが異なります:
- upstream:
'{audienceGroupId}'(string literal) - custom:
'{' . 'audienceGroupId' . '}'(string concatenation)
実行時の挙動は同じです。
注意: form param key の修正は upstream で既に対応済み
この PR のタイトルにある「form param keys の修正」は、もともと openapi-generator 7.21.0 で '{{paramName}}' => $... (camelCase) になっていたバグを直すためでしたが、7.22.0 で upstream 修正されています:
# Line 657
7.21.0: '{{paramName}}' => ${{paramName}}, # bug (camelCase)
7.22.0: '{{baseName}}' => ${{paramName}}, # fixed upstream
custom: '{{baseName}}' => ${{paramName}}, # same as 7.22.0
つまり 7.22.0 + custom api.mustache 構成では、Line 643 のスタイル違いのみが残っており、もしこの違いに技術的理由がなければ custom api.mustache 自体が不要になる可能性があります。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolve #810
Summary
api.mustachetemplate to use{{paramName}}(camelCase) as form data keys inFormDataProcessor::prepare(), instead of{{baseName}}(snake_case)grantType=client_credentialsinstead ofgrant_type=client_credentials), breaking all form-based endpointsapi.mustacheoverride with a single-line fix:'{{baseName}}'instead of'{{paramName}}'Test plan
python generate-code.pywith 7.21.0 locally and check diff of auto generated codesissueStatelessChannelTokentests