Automatically set created_by field when creating new Silence

Currently, when a user creates a new Silence, they can enter anything into the created_by
field. If left empty, the user's email will automatically be filled in. In cases where the
user doesn't have an email, the value "Promgen" will be set. This can cause ambiguity and
make tracking difficult.

Therefore, we have removed the ability to input values for created_by and always set the
user's username instead to ensure accountability when creating a Silence.

Author: hoangpn

promgen/forms.py

@@ -52,18 +52,13 @@ class SilenceForm(forms.Form):
     startsAt = forms.CharField(required=False, validators=[validators.datetime])
     endsAt = forms.CharField(required=False, validators=[validators.datetime])
     comment = forms.CharField(required=False)
-    createdBy = forms.CharField(required=False)
+    createdBy = forms.CharField()
 
     def clean_comment(self):
         if self.cleaned_data["comment"]:
             return self.cleaned_data["comment"]
         return "Silenced from Promgen"
 
-    def clean_createdBy(self):
-        if self.cleaned_data["createdBy"]:
-            return self.cleaned_data["createdBy"]
-        return "Promgen"
-
     def clean(self):
         data = super().clean()
 

promgen/proxy.py

@@ -181,7 +181,7 @@ def get(self, request):
     def post(self, request):
         body = json.loads(request.body.decode("utf-8"))
         body.setdefault("comment", "Silenced from Promgen")
-        body.setdefault("createdBy", request.user.email)
+        body.setdefault("createdBy", request.user.username)
 
         form = forms.SilenceForm(body)
         if not form.is_valid():
@@ -222,7 +222,9 @@ class ProxySilencesV2(APIView):
     permission_classes = [permissions.AllowAny]
 
     def post(self, request, *args, **kwargs):
-        serializer = serializers.SilenceSerializer(data=request.data)
+        serializer = serializers.SilenceSerializer(
+            data={**request.data, "createdBy": request.user.username}
+        )
         if not serializer.is_valid():
             return JsonResponse(
                 {

promgen/serializers.py

@@ -133,7 +133,7 @@ class SilenceSerializer(serializers.Serializer):
     matchers = MatcherSerializer(many=True)
     startsAt = serializers.CharField(required=False)
     endsAt = serializers.CharField(required=False)
-    createdBy = serializers.CharField(default="Promgen")
+    createdBy = serializers.CharField()
     comment = serializers.CharField(default="Silenced from Promgen")
     duration = serializers.CharField(required=False)
 

promgen/templates/promgen/vue/silence_create_modal.html

@@ -86,17 +86,6 @@ <h5>Matcher</h5>
             </div>
           </div>
 
-          <div class="row mb-4">
-            <div class="col-md-6">
-              <h5>
-                Created By
-              </h5>
-              <div>
-                <input v-model="form.createdBy" class="form-control" /> 
-              </div>
-            </div>  
-          </div>
-
           <div class="row mb-4">
             <div class="col-md-12">
               <h5>

promgen/tests/examples/silence.duration.json

@@ -1,5 +1,5 @@
 {
-    "createdBy": "demo@example.com",
+    "createdBy": "demo",
     "matchers": [{
         "value": "example.com:[0-9]*",
         "isRegex": true,

promgen/tests/examples/silence.range.json

@@ -1,5 +1,5 @@
 {
-  "createdBy": "demo@example.com",
+  "createdBy": "demo",
   "matchers": [{
     "value": "example.com:[0-9]*",
     "isRegex": true,

promgen/tests/test_silence.py

@@ -64,35 +64,51 @@ def test_range(self, mock_post):
 
     @override_settings(PROMGEN=TEST_SETTINGS)
     def test_site_silence_errors(self):
-        form = forms.SilenceForm(data={"labels": {}, "duration": "1m"})
+        form = forms.SilenceForm(
+            data={"labels": {}, "duration": "1m", "createdBy": self.user.username}
+        )
         self.assertEqual(
             form.errors.as_data(),
             {"__all__": [errors.SilenceError.NOLABEL.error()]},
         )
 
-        form = forms.SilenceForm(data={"labels": {"alertname": "example-rule"}, "duration": "1m"})
+        form = forms.SilenceForm(
+            data={
+                "labels": {"alertname": "example-rule"},
+                "duration": "1m",
+                "createdBy": self.user.username,
+            }
+        )
         self.assertEqual(
             form.errors.as_data(),
             {"__all__": [errors.SilenceError.GLOBALSILENCE.error()]},
         )
 
         form = forms.SilenceForm(
-            data={"labels": {"alertname": "example-rule", "foo": "bar"}, "duration": "1m"}
+            data={
+                "labels": {"alertname": "example-rule", "foo": "bar"},
+                "duration": "1m",
+                "createdBy": self.user.username,
+            }
         )
         self.assertEqual(
             form.errors.as_data(),
             {"__all__": [errors.SilenceError.GLOBALSILENCE.error()]},
         )
 
         form = forms.SilenceForm(
-            data={"labels": {"alertname": "example-rule", "service": "foo"}, "duration": "1m"}
+            data={
+                "labels": {"alertname": "example-rule", "service": "foo"},
+                "duration": "1m",
+                "createdBy": self.user.username,
+            }
         )
         self.assertEqual(form.errors, {}, "Expected no errors")
         self.assertEqual(
             form.cleaned_data,
             {
                 "comment": "Silenced from Promgen",
-                "createdBy": "Promgen",
+                "createdBy": "demo",
                 "duration": "1m",
                 "endsAt": "",
                 "labels": {"alertname": "example-rule", "service": "foo"},