code review feedback (sans the generated code changes)

Author: ajakubowicz-canva

Cargo.lock

@@ -17,10 +17,10 @@ members = [
     "sparse_strips/vello_common",
     "sparse_strips/vello_cpu",
     "sparse_strips/vello_hybrid",
-    "sparse_strips/vello_hybrid_shaders",
+    "sparse_strips/vello_sparse_shaders",
     "sparse_strips/vello_hybrid/examples/native_webgl",
     "sparse_strips/vello_hybrid/examples/scenes",
-    "sparse_strips/vello_hybrid/examples/webgl",
+    "sparse_strips/vello_hybrid/examples/wgpu_webgl",
     "sparse_strips/vello_hybrid/examples/winit",
     "sparse_strips/vello_toy",
     "sparse_strips/vello_dev_macros",
@@ -115,7 +115,7 @@ vello_api = { path = "sparse_strips/vello_api", default-features = false }
 vello_common = { version = "0.0.1", path = "sparse_strips/vello_common", default-features = false }
 vello_cpu = { path = "sparse_strips/vello_cpu" }
 vello_hybrid = { path = "sparse_strips/vello_hybrid" }
-vello_hybrid_shaders = { path = "sparse_strips/vello_hybrid_shaders" }
+vello_sparse_shaders = { path = "sparse_strips/vello_sparse_shaders" }
 vello_hybrid_scenes = { path = "sparse_strips/vello_hybrid/examples/scenes" }
 vello_dev_macros = { path = "sparse_strips/vello_dev_macros" }
 

Cargo.toml

@@ -22,7 +22,7 @@ This directory contains the core crates for the Vello rendering. Each crate serv
 - **`vello_common`** – Provides shared data structures and utilities for rendering.
 - **`vello_cpu`** – Implements a CPU-based renderer optimized for multithreading and SIMD.
 - **`vello_hybrid`** – A hybrid CPU/GPU renderer, balancing workload between CPU and GPU.
-- **`vello_hybrid_shaders`** – Provide compilation of wgsl to glsl to support the WebGL `vello_hybrid` backend.
+- **`vello_sparse_shaders`** – Provide compilation of wgsl to glsl to support the WebGL `vello_hybrid` backend.
 
 ## Development Status
 

sparse_strips/README.md

@@ -19,7 +19,7 @@ bytemuck = { workspace = true, features = ["derive"] }
 thiserror = { workspace = true }
 vello_common = { workspace = true, features = ["std"] }
 wgpu = { workspace = true, optional = true }
-vello_hybrid_shaders = { workspace = true, optional = true }
+vello_sparse_shaders = { workspace = true, optional = true }
 
 
 [target.'cfg(target_arch = "wasm32")'.dependencies]
@@ -49,4 +49,4 @@ roxmltree = "0.20.0"
 [features]
 default = ["wgpu"]
 wgpu = ["dep:wgpu"]
-webgl = ["dep:js-sys", "dep:web-sys", "dep:vello_hybrid_shaders"]
+webgl = ["dep:js-sys", "dep:web-sys", "dep:vello_sparse_shaders"]

sparse_strips/vello_hybrid/Cargo.toml

@@ -4,7 +4,7 @@ Uses Vello Hybrid with a native WebGL2 backend in the browser. This example does
 
 ## Development
 
-Run with `cargo run_wasm -p native_webgl`.
+Run with `cargo run_wasm -p native_webgl --release`.
 
 ## Testing
 

sparse_strips/vello_hybrid/examples/native_webgl/README.md

@@ -65,6 +65,7 @@ pub fn get_example_scenes(svg_paths: Option<Vec<&str>>) -> Box<[AnyScene]> {
 
     scenes.push(AnyScene::new(text::TextScene::new("Hello, Vello!")));
     scenes.push(AnyScene::new(simple::SimpleScene::new()));
+    scenes.push(AnyScene::new(clip::ClipScene::new()));
 
     scenes.into_boxed_slice()
 }

sparse_strips/vello_hybrid/examples/scenes/src/lib.rs

@@ -1,5 +1,5 @@
 [package]
-name = "webgl"
+name = "wgpu_webgl"
 version.workspace = true
 description = "An example showing Vello Hybrid using WebGL2."
 edition.workspace = true

sparse_strips/vello_hybrid/examples/webgl/Cargo.toml renamed to sparse_strips/vello_hybrid/examples/wgpu_webgl/Cargo.toml

@@ -1,10 +1,10 @@
 ## WebGL Demo
 
-Uses Vello Hybrid with a WebGL2 backend in the browser.
+Uses Vello Hybrid with a `wgpu` powered WebGL2 backend in the browser.
 
 ## Development
 
-Run with `cargo run_wasm -p webgl`.
+Run with `cargo run_wasm -p wgpu_webgl --release`.
 
 ## Testing
 

sparse_strips/vello_hybrid/examples/webgl/README.md renamed to sparse_strips/vello_hybrid/examples/wgpu_webgl/README.md

@@ -11,7 +11,7 @@
 fn main() {
     #[cfg(target_arch = "wasm32")]
     {
-        use webgl::run_interactive;
+        use wgpu_webgl::run_interactive;
 
         console_error_panic_hook::set_once();
         console_log::init_with_level(log::Level::Debug).unwrap();

sparse_strips/vello_hybrid/examples/webgl/src/lib.rs renamed to sparse_strips/vello_hybrid/examples/wgpu_webgl/src/lib.rs

@@ -7,7 +7,7 @@
 mod wasm {
     use vello_common::peniko::{color::palette, kurbo::BezPath};
     use wasm_bindgen_test::*;
-    use webgl::render_scene;
+    use wgpu_webgl::render_scene;
 
     wasm_bindgen_test_configure!(run_in_browser);
 

sparse_strips/vello_hybrid/examples/webgl/src/main.rs renamed to sparse_strips/vello_hybrid/examples/wgpu_webgl/src/main.rs

@@ -24,37 +24,26 @@
 //! The renderer is split into several key components:
 //!
 //! - `Scene`: Manages the render context and path processing on the CPU
-//! - `Renderer`: Handles GPU resource management and executes draw operations
+//! - `Renderer` or `WebGlRenderer`: Handles GPU resource management and executes draw operations
 //! - `Scheduler`: Manages and schedules draw operations on the renderer.
 //!
-//! ## Renderer Backends
-//!
-//! - `render_wgpu` contains the default renderer backend, leveraging `wgpu`.
-//! - `render_webgl` contains a WebGL2 backend specifically for `wasm32` if the `webgl` feature is
-//!   active.
-//!
 //! See the individual module documentation for more details on usage and implementation.
 
 #![no_std]
 
 extern crate alloc;
 
 mod render;
-#[cfg(all(target_arch = "wasm32", feature = "webgl"))]
-mod render_webgl;
-#[cfg(feature = "wgpu")]
-mod render_wgpu;
-
 mod scene;
 #[cfg(any(all(target_arch = "wasm32", feature = "webgl"), feature = "wgpu"))]
 mod schedule;
 pub mod util;
 
-pub use render::{Config, GpuStrip, RenderSize};
 #[cfg(all(target_arch = "wasm32", feature = "webgl"))]
-pub use render_webgl::WebGlRenderer;
+pub use render::WebGlRenderer;
+pub use render::{Config, GpuStrip, RenderSize};
 #[cfg(feature = "wgpu")]
-pub use render_wgpu::{RenderTargetConfig, Renderer};
+pub use render::{RenderTargetConfig, Renderer};
 pub use scene::Scene;
 pub use util::DimensionConstraints;
 pub use vello_common::pixmap::Pixmap;

sparse_strips/vello_hybrid/examples/webgl/tests/webgl.rs renamed to sparse_strips/vello_hybrid/examples/wgpu_webgl/tests/webgl.rs

@@ -1,9 +1,7 @@
 // Copyright 2025 the Vello Authors
 // SPDX-License-Identifier: Apache-2.0 OR MIT
 
-//! Backend agnostic render module.
-//!
-//! For backend specific render code see `render_wgpu` or `render_webgl`.
+//! Backend agnostic renderer module.
 
 use bytemuck::{Pod, Zeroable};
 

sparse_strips/vello_hybrid/src/lib.rs

@@ -0,0 +1,22 @@
+// Copyright 2025 the Vello Authors
+// SPDX-License-Identifier: Apache-2.0 OR MIT
+
+//! Provides renderer backends which handle GPU resource management and executes draw operations.
+//!
+//! ## Renderer Backends
+//!
+//! - `wgpu` contains the default renderer backend, leveraging `wgpu`.
+//! - `webgl` contains a WebGL2 backend specifically for `wasm32` if the `webgl` feature is active.
+
+mod common;
+#[cfg(all(target_arch = "wasm32", feature = "webgl"))]
+mod webgl;
+#[cfg(feature = "wgpu")]
+mod wgpu;
+
+pub use common::{Config, GpuStrip, RenderSize};
+
+#[cfg(all(target_arch = "wasm32", feature = "webgl"))]
+pub use webgl::WebGlRenderer;
+#[cfg(feature = "wgpu")]
+pub use wgpu::{RenderTargetConfig, Renderer};