`TextInput` placeholder has jarring offset.

[xStrom]

The placeholder text should be located at the same spot as the main text if they both have the same font size. This is true e.g. on the web.

However the Masonry widget currently has like a 1px offset pushing the placeholder text slightly away from the start.

One easy way to confirm this is with the xilem to_do_mvc example. Although you'll need to comment out the .text_size(16.) line to get equal font size. After that, try cut/pasting in the same text as the placeholder. You will see that the placeholder is slightly offset.

I'm not sure what causes this, because TextInput::layout calls ctx.place_child on both the main text and the placeholder with the same position. So the offset is introduced by something else.

[StefanSalewski]

comment out the .text_size(16.) line to get equal font size.

My feeling is, that default size is not identical for placeholder text and actual text. Placeholder is a few percent smaller. So placeholder and actual text have not much in common -- I think placeholder is a label, and actual text a text-area. For the offset -- I guess you are right, but it is hard to see, and jarring might be not the correct adjective for it, seems to be only one pixel.

[PoignardAzur]

The culprit is this line in theme.rs:

properties.insert::<Label, _>(Padding::from_vh(0., 2.));

I'm pretty sure I originally added this line to keep screenshot tests the same while refactoring the layout system / adding properties. I'll remove it.

[PoignardAzur]

(This is an example of why adding default padding to everything is a bad idea and we shouldn't do it lightly. Later on you end up with extra padding and you have no idea where it comes from.)

[StefanSalewski]

Nice that you found it. I had looked into the sources, but got no idea. What is about the font size? I am quite sure that placeholder text and actual text has different font sizes. Is that intended? And when it is intended, where are the sizes defined. I only found something like a default size, which is used for the placeholder label and the actual text, so my assumption is that text sizes should be identical?

[StefanSalewski]

Here is a screenshot, I commented out the explicit font size use:

    )
    //.text_size(16.)
    .placeholder("What needs to be done for Xilem in 2026?")

[StefanSalewski]

And when we decide that the smaller placeholder text is desired, what is with a larger text like

    )
    .text_size(32.)
    .placeholder("What needs to be done for Xilem in 2026?")

Here we get a larger text font, but the placeholder stays small. Is that intended and a good decision?

[PoignardAzur]

I'll look into it. The two are constructed through different code paths, so there's probably other discrepancies.

Here we get a larger text font, but the placeholder stays small. Is that intended and a good decision?

No to both.