Fixed namespace issue for sitemap generation

Author: linkdotnet

LinkDotNet.Blog.IntegrationTests/Web/Shared/Services/SitemapServiceTests.cs

@@ -0,0 +1,66 @@
+using System;
+using System.Collections.Generic;
+using System.IO;
+using System.Threading.Tasks;
+using FluentAssertions;
+using LinkDotNet.Blog.Domain;
+using LinkDotNet.Blog.Infrastructure.Persistence;
+using LinkDotNet.Blog.Web.Shared.Services;
+using LinkDotNet.Blog.Web.Shared.Services.Sitemap;
+using Moq;
+using Xunit;
+
+namespace LinkDotNet.Blog.IntegrationTests.Web.Shared.Services
+{
+    public sealed class SitemapServiceTests : IDisposable
+    {
+        private const string OutputDirectory = "wwwroot";
+        private const string OutputFilename = $"{OutputDirectory}/sitemap.xml";
+        private readonly SitemapService sut;
+
+        public SitemapServiceTests()
+        {
+            var repositoryMock = new Mock<IRepository<BlogPost>>();
+            sut = new SitemapService(repositoryMock.Object, null, new XmlFileWriter());
+            Directory.CreateDirectory("wwwroot");
+        }
+
+        [Fact]
+        public async Task ShouldSaveSitemapUrlInCorrectFormat()
+        {
+            var urlSet = new SitemapUrlSet()
+            {
+                Urls = new List<SitemapUrl>
+                {
+                    new SitemapUrl
+                    {
+                        Location = "here",
+                    },
+                },
+            };
+            await sut.SaveSitemapToFileAsync(urlSet);
+
+            var lines = await File.ReadAllTextAsync(OutputFilename);
+            lines.Should().Be(
+@"<?xml version=""1.0"" encoding=""utf-8""?>
+<urlset xmlns:xsi=""http://www.w3.org/2001/XMLSchema-instance"" xmlns:xsd=""http://www.w3.org/2001/XMLSchema"" xmlns=""http://www.sitemaps.org/schemas/sitemap/0.9"">
+  <url>
+    <loc>here</loc>
+  </url>
+</urlset>");
+        }
+
+        public void Dispose()
+        {
+            if (File.Exists(OutputFilename))
+            {
+                File.Delete(OutputFilename);
+            }
+
+            if (Directory.Exists(OutputDirectory))
+            {
+                Directory.Delete(OutputDirectory, true);
+            }
+        }
+    }
+}

LinkDotNet.Blog.UnitTests/Web/Shared/Services/SitemapServiceTests.cs

@@ -58,7 +58,6 @@ public async Task ShouldCreateSitemap()
 
         var sitemap = await sut.CreateSitemapAsync();
 
-        sitemap.Namespace.Should().Be("http://www.sitemaps.org/schemas/sitemap/0.9");
         sitemap.Urls.Should().HaveCount(5);
         sitemap.Urls[0].Location.Should().Be($"{fakeNavigationManager.BaseUri}");
         sitemap.Urls[1].Location.Should().Be($"{fakeNavigationManager.BaseUri}blogPost/id1");

LinkDotNet.Blog.Web/Shared/AccessControl.razor

@@ -16,7 +16,7 @@
                 <li><h6 class="dropdown-header">Others</h6></li>
                 <li><a class="dropdown-item" href="Sitemap">Sitemap</a></li>
                 <li><hr class="dropdown-divider"></li>
-                <li><a class="dropdown-item" href="https://github.com/linkdotnet/Blog/releases">Version 2.7</a></li>
+                <li><a class="dropdown-item" href="https://github.com/linkdotnet/Blog/releases">Version 2.71</a></li>
             </ul>
         </li>
         <li class="nav-item"><a class="nav-link" href="logout">Log out</a></li>

LinkDotNet.Blog.Web/Shared/Services/Sitemap/SitemapService.cs

@@ -26,11 +26,7 @@ public SitemapService(
 
     public async Task<SitemapUrlSet> CreateSitemapAsync()
     {
-        const string sitemapNamespace = "http://www.sitemaps.org/schemas/sitemap/0.9";
-        var urlSet = new SitemapUrlSet
-        {
-            Namespace = sitemapNamespace,
-        };
+        var urlSet = new SitemapUrlSet();
 
         var blogPosts = (await repository.GetAllAsync(f => f.IsPublished, b => b.UpdatedDate)).ToList();
 

LinkDotNet.Blog.Web/Shared/Services/Sitemap/SitemapUrlSet.cs

@@ -3,12 +3,9 @@
 
 namespace LinkDotNet.Blog.Web.Shared.Services.Sitemap;
 
-[XmlRoot(ElementName = "urlset")]
+[XmlRoot(ElementName = "urlset", Namespace = "http://www.sitemaps.org/schemas/sitemap/0.9")]
 public class SitemapUrlSet
 {
     [XmlElement(ElementName = "url")]
     public List<SitemapUrl> Urls { get; set; } = new();
-
-    [XmlAttribute(AttributeName = "xmlns")]
-    public string Namespace { get; set; }
 }

LinkDotNet.Blog.Web/Shared/Services/XmlFileWriter.cs

@@ -10,7 +10,7 @@ public class XmlFileWriter : IXmlFileWriter
     public async Task WriteObjectToXmlFileAsync<T>(T objectToSave, string fileName)
     {
         await using var file = File.Create(fileName);
-        await using var xmlWriter = XmlWriter.Create(file, new XmlWriterSettings { Indent = true });
+        await using var xmlWriter = XmlWriter.Create(file, new XmlWriterSettings { Indent = true, Async = true });
         var serializer = new XmlSerializer(typeof(T));
         serializer.Serialize(xmlWriter, objectToSave);
         xmlWriter.Close();