Commit e86b854
committed
[ingestion] Fix deserializePositionWithOffsetFallback to preserve symbolic positions
The deserializePositionWithOffsetFallback method was incorrectly treating
symbolic positions (EARLIEST, LATEST) as regular positions and comparing
their numeric offsets against the provided minimum offset. This caused
EARLIEST (numeric offset -1) to be replaced with an offset-based position
when the minimum offset was >= 0.
Added a guard to detect and preserve symbolic positions before performing
numeric offset comparison, ensuring they are returned as-is regardless of
the minimum offset parameter.
This fix resolves the failing testDeserializePositionWithOffsetFallback
test in LeaderFollowerStoreIngestionTaskTest.
Test: ./gradlew :clients:da-vinci-client:test --tests "com.linkedin.davinci.kafka.consumer.LeaderFollowerStoreIngestionTaskTest"1 parent adbeca6 commit e86b854
File tree
1 file changed
+6
-0
lines changed- clients/da-vinci-client/src/main/java/com/linkedin/davinci/kafka/consumer
1 file changed
+6
-0
lines changedLines changed: 6 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
5179 | 5179 | | |
5180 | 5180 | | |
5181 | 5181 | | |
| 5182 | + | |
| 5183 | + | |
| 5184 | + | |
| 5185 | + | |
| 5186 | + | |
| 5187 | + | |
5182 | 5188 | | |
5183 | 5189 | | |
5184 | 5190 | | |
| |||
0 commit comments