fix incorrect linode-cli obj du number formatting (#480)

Author: jafreche-akamai

linodecli/plugins/obj/helpers.py

@@ -106,16 +106,11 @@ def _denominate(total):
     """
     Coverts bucket size to human readable bytes.
     """
-    total = float(total)
-    denomination = ["KB", "MB", "GB", "TB"]
-    for x in denomination:
-        if total > 1024:
-            total = total / 1024
+    for unit in ("KB", "MB", "GB", "TB"):
+        total = total / 1024
         if total < 1024:
-            total = round(total, 2)
-            total = str(total) + " " + x
             break
-    return total
+    return f"{round(total, 2)} {unit}"
 
 
 # helper functions for output

tests/unit/test_plugin_obj.py

@@ -1,6 +1,6 @@
 from pytest import CaptureFixture
 
-from linodecli.plugins.obj import get_obj_args_parser, print_help
+from linodecli.plugins.obj import get_obj_args_parser, helpers, print_help
 
 
 def test_print_help(capsys: CaptureFixture):
@@ -12,3 +12,24 @@ def test_print_help(capsys: CaptureFixture):
         "See --help for individual commands for more information"
         in captured_text.out
     )
+
+
+def test_helpers_denominate():
+    assert helpers._denominate(0) == "0.0 KB"
+    assert helpers._denominate(1) == "0.0 KB"
+    assert helpers._denominate(12) == "0.01 KB"
+    assert helpers._denominate(123) == "0.12 KB"
+    assert helpers._denominate(1000) == "0.98 KB"
+
+    assert helpers._denominate(1024) == "1.0 KB"
+    assert helpers._denominate(1024**2) == "1.0 MB"
+    assert helpers._denominate(1024**3) == "1.0 GB"
+    assert helpers._denominate(1024**4) == "1.0 TB"
+    assert helpers._denominate(1024**5) == "1024.0 TB"
+
+    assert helpers._denominate(102400) == "100.0 KB"
+    assert helpers._denominate(1024000) == "1000.0 KB"
+    assert helpers._denominate((1024**2) // 10) == "102.4 KB"
+
+    assert helpers._denominate(123456789) == "117.74 MB"
+    assert helpers._denominate(1e23) == "90949470177.29 TB"