Project: Linode Interfaces #735
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Implement changes for account APIs * Cleanup and re-add tests * gofumpt * Add availability notice
…inodes Enhanced Interfaces (#727) * Added support for networking/firewalls related changes * Added support for Networking IPs and VPC changes * Addressed PR comments
* Add firewall template functions * Add integration tests * Fix inline doc
## 📝 Description **What does this PR do and why is this change necessary?** Initial additions for interfaces ## ✔️ How to Test **How do I run the relevant unit/integration tests?** ```bash make test-unit ```
* Add linode instance changes for linode interfaces * Fix interface structs * Add tests * go work sum
* Add DoublePointer helper function * Remove duplicated DoublePointer in test * Fix * Add DoublePointerNull * lint * Make nullable default firewall IDs pointer * Make default firewall IDs in update options double pointers * Update unit test to utilize DoublePointer helper func
* firewall_tests * fix * fix * fix_format * fixPRcomments * fix
…es fields into InstanceCreateOptions (#759) * Consolidate InterfaceGeneration and LinodeInterfaces fields into InstanceCreateOptions * Add network_helper to create opts * Add unmarshal * Re-run fixtures * Fix various issues
* Fix firewall settings tests * Make optional fields pointers for Linode interface structs
zliang-akamai
force-pushed
the
proj/vpc-linodes-enhanced-interfaces
branch
from
7e8516e to
9dcaf5a
Compare
zliang-akamai
force-pushed
the
proj/vpc-linodes-enhanced-interfaces
branch
from
9dcaf5a to
bf3104f
Compare
* Make default_firewall_ids nullable * Fix unit test
* Add future breaking change notice for ConfigID in VPC IP * Update wording
4 tasks
* Make FirewallID in linode interface creation options a double ptr * golangci-lint fmt * Refresh the monthly transfer test fixture
zliang-akamai
requested review from
jriddle-linode and
yec-akamai
and removed request for
a team
lgarber-akamai
approved these changes
Aug 21, 2025
Contributor
lgarber-akamai
left a comment
lgarber-akamai
left a comment
There was a problem hiding this comment.
🎉
I'll get the VPC Dual Stack project PR ready once this has been merged.
yec-akamai
approved these changes
Aug 21, 2025
lgarber-akamai
approved these changes
Aug 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.