Skip to content

Commit 32e9d71

Browse files
fix: [DI-28760] - Add type safety for dependent filter ref's usage (#13196)
* upcoming: [DI-28760] - Reset dependent filter ref on dashboard switch and add type safety for ref's usage * upcoming: [DI-28760] - Remove side effects * upcoming: [DI-28760] - Add changeset
1 parent aab5b22 commit 32e9d71

File tree

2 files changed

+10
-3
lines changed

2 files changed

+10
-3
lines changed
Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"@linode/manager": Fixed
3+
---
4+
5+
CloudPulse-Metrics: Update `CloudPulseDashboardFilterBuilder.tsx` to add type-check for usage of dependent filters ref ([#13196](https://github.com/linode/manager/pull/13196))

packages/manager/src/features/CloudPulse/shared/CloudPulseDashboardFilterBuilder.tsx

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -368,9 +368,11 @@ export const CloudPulseDashboardFilterBuilder = React.memo(
368368
preferences,
369369
resource_ids: resource_ids?.length
370370
? resource_ids
371-
: (
372-
dependentFilterReference.current[RESOURCE_ID] as string[]
373-
)?.map((id: string) => Number(id)),
371+
: Array.isArray(dependentFilterReference.current[RESOURCE_ID])
372+
? dependentFilterReference.current[RESOURCE_ID].map(
373+
Number
374+
).filter((id) => !Number.isNaN(id))
375+
: [],
374376
shouldDisable: isError || isLoading,
375377
},
376378
handleNodeTypeChange

0 commit comments

Comments
 (0)