Merge pull request #12509 from linode/staging

Release v1.146.0 - staging → master

Author: coliu-akamai

.gitignore

@@ -10,6 +10,7 @@ lib
 
 # editor configuration
 .vscode
+.cursor
 .idea
 **/*.iml
 *.mdc

docs/CONTRIBUTING.md

@@ -39,6 +39,7 @@ Feel free to open an issue to report a bug or request a feature.
     `Added`, `Fixed`, `Changed`, `Removed`, `Tech Stories`, `Tests`, `Upcoming Features`
       - Select the changeset category that matches the commit type in your PR title. (Where this isn't a 1:1 match: generally, a `feat` commit type falls under an `Added` change and `refactor` falls under `Tech Stories`.)
       - Write your changeset by following our [best practices](#writing-a-changeset).
+9. Automated tests and other CI checks will run automatically against the PR. It is the contributor's responsibility to ensure their changes pass the CI checks.
 
 Two reviews from members of the Cloud Manager team are required before merge. After approval, all pull requests are squash merged.
 

docs/PULL_REQUEST_TEMPLATE.md

@@ -72,7 +72,7 @@ Please specify a release date (and environment, if applicable) to guarantee time
 
 ## As an Author, before moving this PR from Draft to Open, I confirmed ✅
 
-- [ ] All unit tests are passing
+- [ ] All tests and CI checks are passing
 - [ ] TypeScript compilation succeeded without errors
 - [ ] Code passes all linting rules
 

package.json

@@ -51,6 +51,7 @@
     "test:search": "pnpm run --filter @linode/search test",
     "test:ui": "pnpm run --filter @linode/ui test",
     "test:utilities": "pnpm run --filter @linode/utilities test",
+    "test:shared": "pnpm run --filter @linode/shared test",
     "coverage": "pnpm run --filter linode-manager coverage",
     "coverage:summary": "pnpm run --filter linode-manager coverage:summary",
     "cy:run": "pnpm run --filter linode-manager cy:run",

packages/api-v4/CHANGELOG.md

@@ -1,3 +1,21 @@
+## [2025-07-15] - v0.144.0
+
+
+### Changed:
+
+- ACLP:Alerting - fixed the typo from evaluation_periods_seconds to evaluation_period_seconds ([#12466](https://github.com/linode/manager/pull/12466))
+- Use `v4beta` for `/maintenance` endpoint ([#12519](https://github.com/linode/manager/pull/12519))
+
+### Fixed:
+
+- Unnecessary 404 errors when components attempt to fetch deleted resources ([#12474](https://github.com/linode/manager/pull/12474))
+
+### Upcoming Features:
+
+- CloudPulse: Update types in `alerts.ts` and `types.ts`; Linode: Update type in `types.ts` ([#12393](https://github.com/linode/manager/pull/12393))
+- CloudPulse: Update service type in `types.ts` ([#12401](https://github.com/linode/manager/pull/12401))
+- Add `regions` in `Alert` interface in `types.ts` file for cloudpulse ([#12435](https://github.com/linode/manager/pull/12435))
+
 ## [2025-07-01] - v0.143.0
 
 ### Changed:

packages/api-v4/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@linode/api-v4",
-  "version": "0.143.0",
+  "version": "0.144.0",
   "homepage": "https://github.com/linode/manager/tree/develop/packages/api-v4",
   "bugs": {
     "url": "https://github.com/linode/manager/issues"

packages/api-v4/src/account/maintenance.ts

@@ -1,4 +1,4 @@
-import { API_ROOT, BETA_API_ROOT } from '../constants';
+import { BETA_API_ROOT } from '../constants';
 import Request, { setMethod, setParams, setURL, setXFilter } from '../request';
 
 import type { Filter, Params, ResourcePage } from '../types';
@@ -12,7 +12,7 @@ import type { AccountMaintenance, MaintenancePolicy } from './types';
  */
 export const getAccountMaintenance = (params?: Params, filter?: Filter) =>
   Request<ResourcePage<AccountMaintenance>>(
-    setURL(`${API_ROOT}/account/maintenance`),
+    setURL(`${BETA_API_ROOT}/account/maintenance`),
     setMethod('GET'),
     setParams(params),
     setXFilter(filter),

packages/api-v4/src/cloudpulse/alerts.ts

@@ -16,6 +16,7 @@ import type { Filter, Params, ResourcePage } from '../types';
 import type {
   Alert,
   AlertServiceType,
+  CloudPulseAlertsPayload,
   CreateAlertDefinitionPayload,
   EditAlertDefinitionPayload,
   NotificationChannel,
@@ -126,3 +127,16 @@ export const deleteAlertDefinition = (serviceType: string, alertId: number) =>
     ),
     setMethod('DELETE'),
   );
+
+export const updateServiceAlerts = (
+  serviceType: string,
+  entityId: string,
+  payload: CloudPulseAlertsPayload,
+) =>
+  Request<{}>(
+    setURL(
+      `${API_ROOT}/${serviceType}/instances/${encodeURIComponent(entityId)}`,
+    ),
+    setMethod('PUT'),
+    setData(payload),
+  );

packages/api-v4/src/cloudpulse/types.ts

@@ -1,7 +1,10 @@
+import type { AccountCapability } from 'src/account';
+
 export type AlertSeverityType = 0 | 1 | 2 | 3;
 export type MetricAggregationType = 'avg' | 'count' | 'max' | 'min' | 'sum';
 export type MetricOperatorType = 'eq' | 'gt' | 'gte' | 'lt' | 'lte';
 export type AlertServiceType = 'dbaas' | 'linode';
+export type MetricsServiceType = 'dbaas' | 'linode' | 'nodebalancer';
 export type AlertClass = 'dedicated' | 'shared';
 export type DimensionFilterOperatorType =
   | 'endswith'
@@ -165,7 +168,7 @@ export interface CloudPulseMetricsList {
 }
 
 export interface ServiceAlert {
-  evaluation_periods_seconds: number[];
+  evaluation_period_seconds: number[];
   polling_interval_seconds: number[];
   scope: AlertDefinitionScope[];
 }
@@ -238,6 +241,7 @@ export interface Alert {
   has_more_resources: boolean;
   id: number;
   label: string;
+  regions?: string[];
   rule_criteria: {
     rules: AlertDefinitionMetricCriteria[];
   };
@@ -366,10 +370,18 @@ export interface CloudPulseAlertsPayload {
    * Array of enabled system alert IDs in ACLP (Beta) mode.
    * Only included in Beta mode.
    */
-  system: number[];
+  system?: number[];
   /**
    * Array of enabled user alert IDs in ACLP (Beta) mode.
    * Only included in Beta mode.
    */
-  user: number[];
-}
+  user?: number[];
+}
+export const capabilityServiceTypeMapping: Record<
+  MetricsServiceType,
+  AccountCapability
+> = {
+  linode: 'Linodes',
+  dbaas: 'Managed Databases',
+  nodebalancer: 'NodeBalancers',
+};

packages/api-v4/src/iam/types.ts

@@ -64,46 +64,32 @@ export type EntityRoleType =
 
 export type RoleName = AccountRoleType | EntityRoleType;
 
-/** Permissions associated with the "account_admin" role. */
+/**
+ * Permissions associated with the "account_admin" role.
+ * Note: Permissions associated with profile have been excluded as all users have access to their own profile.
+ * This is to align with the permissions API array.
+ */
 export type AccountAdmin =
   | 'accept_service_transfer'
   | 'acknowledge_account_agreement'
-  | 'answer_profile_security_questions'
   | 'cancel_account'
   | 'cancel_service_transfer'
-  | 'create_profile_pat'
-  | 'create_profile_ssh_key'
-  | 'create_profile_tfa_secret'
   | 'create_service_transfer'
   | 'create_user'
-  | 'delete_profile_pat'
-  | 'delete_profile_phone_number'
-  | 'delete_profile_ssh_key'
   | 'delete_user'
-  | 'disable_profile_tfa'
   | 'enable_managed'
-  | 'enable_profile_tfa'
   | 'enroll_beta_program'
   | 'is_account_admin'
   | 'list_account_agreements'
   | 'list_account_logins'
   | 'list_available_services'
   | 'list_default_firewalls'
-  | 'list_enrolled_beta_programs'
   | 'list_service_transfers'
   | 'list_user_grants'
-  | 'revoke_profile_app'
-  | 'revoke_profile_device'
-  | 'send_profile_phone_number_verification_code'
   | 'update_account'
   | 'update_account_settings'
-  | 'update_profile'
-  | 'update_profile_pat'
-  | 'update_profile_ssh_key'
   | 'update_user'
   | 'update_user_grants'
-  | 'update_user_preferences'
-  | 'verify_profile_phone_number'
   | 'view_account'
   | 'view_account_login'
   | 'view_account_settings'
@@ -114,13 +100,8 @@ export type AccountAdmin =
   | 'view_user'
   | 'view_user_preferences'
   | AccountBillingAdmin
-  | AccountEventViewer
   | AccountFirewallAdmin
-  | AccountLinodeAdmin
-  | AccountMaintenanceViewer
-  | AccountNotificationViewer
-  | AccountOauthClientAdmin
-  | AccountProfileViewer;
+  | AccountLinodeAdmin;
 
 /** Permissions associated with the "account_billing_admin" role. */
 export type AccountBillingAdmin =