remove all instances of update_user (#13198)

Author: abailly-akamai

packages/manager/src/features/IAM/Users/UserDetails/UserEmailPanel.test.tsx

@@ -108,7 +108,7 @@ describe('UserEmailPanel', () => {
     expect(errorText).toBeInTheDocument();
   });
 
-  it('disables the save button when the user does not have update_user permission', async () => {
+  it('disables the save button when the user does not have is_account_admin permission', async () => {
     const user = accountUserFactory.build({
       email: 'my-linode-email',
     });

packages/manager/src/features/IAM/Users/UserDetails/UserProfile.tsx

@@ -19,11 +19,7 @@ import { UsernamePanel } from './UsernamePanel';
 
 export const UserProfile = () => {
   const { username } = useParams({ from: '/iam/users/$username' });
-  const { data: permissions } = usePermissions('account', [
-    'is_account_admin',
-    'update_user',
-    'delete_user',
-  ]);
+  const { data: permissions } = usePermissions('account', ['is_account_admin']);
 
   const isAccountAdmin = permissions?.is_account_admin;
 
@@ -34,10 +30,6 @@ export const UserProfile = () => {
   } = useAccountUser(username ?? '', isAccountAdmin);
   const { data: assignedRoles } = useUserRoles(username ?? '', isAccountAdmin);
 
-  // Only admin users get update_user and delete_user permissions, but doing a bit of defensive programming here to be safe.
-  const canUpdateUser = isAccountAdmin || permissions?.update_user;
-  const canDeleteUser = isAccountAdmin || permissions?.delete_user;
-
   if (isLoading) {
     return <CircleProgress />;
   }
@@ -66,9 +58,9 @@ export const UserProfile = () => {
         sx={(theme) => ({ marginTop: theme.tokens.spacing.S16 })}
       >
         <UserDetailsPanel activeUser={user} assignedRoles={assignedRoles} />
-        <UsernamePanel activeUser={user} canUpdateUser={canUpdateUser} />
-        <UserEmailPanel activeUser={user} canUpdateUser={canUpdateUser} />
-        <DeleteUserPanel activeUser={user} canDeleteUser={canDeleteUser} />
+        <UsernamePanel activeUser={user} canUpdateUser={isAccountAdmin} />
+        <UserEmailPanel activeUser={user} canUpdateUser={isAccountAdmin} />
+        <DeleteUserPanel activeUser={user} canDeleteUser={isAccountAdmin} />
       </Stack>
     </>
   );

packages/manager/src/features/IAM/Users/UserDetails/UsernamePanel.test.tsx

@@ -9,7 +9,7 @@ import { UsernamePanel } from './UsernamePanel';
 const queryMocks = vi.hoisted(() => ({
   userPermissions: vi.fn(() => ({
     data: {
-      update_user: false,
+      is_account_admin: false,
     },
   })),
 }));
@@ -31,7 +31,7 @@ describe('UsernamePanel', () => {
     expect(usernameTextField).toHaveDisplayValue(user.username);
   });
 
-  it('disables the input if the user doesn not have update_user permission', async () => {
+  it('disables the input if the user doesn not have is_account_admin permission', async () => {
     const user = accountUserFactory.build();
 
     const { getByLabelText } = renderWithTheme(
@@ -50,7 +50,7 @@ describe('UsernamePanel', () => {
   it("does not allow the user to update a proxy user's username", async () => {
     queryMocks.userPermissions.mockReturnValue({
       data: {
-        update_user: true,
+        is_account_admin: true,
       },
     });
 
@@ -76,14 +76,14 @@ describe('UsernamePanel', () => {
     expect(getByText('Save').closest('button')).toBeDisabled();
   });
 
-  it('enables the save button when the user makes a change to the username and has update_user permission', async () => {
+  it('enables the save button when the user makes a change to the username and has is_account_admin permission', async () => {
     const user = accountUserFactory.build({
       username: 'my-linode-username',
     });
 
     queryMocks.userPermissions.mockReturnValue({
       data: {
-        update_user: true,
+        is_account_admin: true,
       },
     });
 
@@ -102,14 +102,14 @@ describe('UsernamePanel', () => {
     expect(saveButton).toBeEnabled();
   });
 
-  it('disables the save button when the user does not have update_user permission', async () => {
+  it('disables the save button when the user does not have is_account_admin permission', async () => {
     const user = accountUserFactory.build({
       username: 'my-linode-username',
     });
 
     queryMocks.userPermissions.mockReturnValue({
       data: {
-        update_user: false,
+        is_account_admin: false,
       },
     });
 

packages/manager/src/features/Profile/DisplaySettings/UsernameForm.test.tsx

@@ -11,7 +11,7 @@ import { UsernameForm } from './UsernameForm';
 const queryMocks = vi.hoisted(() => ({
   userPermissions: vi.fn(() => ({
     data: {
-      update_user: false,
+      is_account_admin: false,
     },
   })),
 }));
@@ -38,7 +38,7 @@ describe('UsernameForm', () => {
     await findByDisplayValue(profile.username);
   });
 
-  it('disables the input if the user doesn not have update_user permission', async () => {
+  it('disables the input if the user doesn not have is_account_admin permission', async () => {
     const { getByLabelText } = renderWithTheme(<UsernameForm />);
 
     expect(getByLabelText('Username')).toBeDisabled();
@@ -53,7 +53,7 @@ describe('UsernameForm', () => {
   it('disables the input if the user is a proxy user', async () => {
     queryMocks.userPermissions.mockReturnValue({
       data: {
-        update_user: true,
+        is_account_admin: true,
       },
     });
 
@@ -73,14 +73,14 @@ describe('UsernameForm', () => {
     expect(getByLabelText('This field can’t be modified.')).toBeVisible();
   });
 
-  it('enables the save button when the user makes a change to the username and has update_user permission', async () => {
+  it('enables the save button when the user makes a change to the username and has is_account_admin permission', async () => {
     const profile = profileFactory.build({ username: 'my-linode-username' });
 
     server.use(http.get('*/v4/profile', () => HttpResponse.json(profile)));
 
     queryMocks.userPermissions.mockReturnValue({
       data: {
-        update_user: true,
+        is_account_admin: true,
       },
     });
 

packages/manager/src/features/Profile/DisplaySettings/UsernameForm.tsx

@@ -24,7 +24,7 @@ export const UsernameForm = () => {
 
   const values = { username: profile?.username ?? '' };
 
-  const { data: permissions } = usePermissions('account', ['update_user']);
+  const { data: permissions } = usePermissions('account', ['is_account_admin']);
 
   const {
     control,
@@ -37,7 +37,7 @@ export const UsernameForm = () => {
     values,
   });
 
-  const tooltipForDisabledUsernameField = !permissions.update_user
+  const tooltipForDisabledUsernameField = !permissions.is_account_admin
     ? 'Restricted users cannot update their username. Please contact an account administrator.'
     : profile?.user_type === 'proxy'
       ? RESTRICTED_FIELD_TOOLTIP