Merge pull request #12061 from linode/staging

Release v1.140.0 - staging → master

Author: cpathipa

.github/workflows/eslint_review.yml

@@ -0,0 +1,30 @@
+name: ESLint Review
+on: [pull_request]
+jobs:
+  eslint:
+    name: ESLint Review
+    runs-on: ubuntu-latest
+    permissions:
+      contents: read
+      checks: write
+    strategy:
+      matrix:
+        package: [manager, api-v4, queries, shared, ui, utilities, validation]
+    steps:
+      - uses: actions/checkout@v4
+      - uses: pnpm/action-setup@v2
+        with:
+          run_install: false
+          version: 10
+      - uses: actions/setup-node@v4
+        with:
+          node-version: "20.17"
+          cache: "pnpm"
+      - run: pnpm install
+      - uses: abailly-akamai/action-eslint@8ad68ba04fa60924ef7607b07deb5989f38f5ed6 # v1.0.2
+        with:
+          workdir: packages/${{ matrix.package }}
+          github_token: ${{ secrets.GITHUB_TOKEN }}
+          reporter: github-pr-check
+          level: warning  # This will report both warnings and errors
+          filter_mode: added  # Only comment on new/modified lines

package.json

@@ -2,16 +2,35 @@
   "name": "root",
   "private": true,
   "license": "Apache-2.0",
+  "type": "module",
   "devDependencies": {
+    "@eslint/js": "^9.23.0",
     "concurrently": "9.1.0",
     "husky": "^9.1.6",
     "typescript": "^5.7.3",
     "vitest": "^3.0.7",
     "@vitest/ui": "^3.0.7",
-    "lint-staged": "^15.4.3"
+    "lint-staged": "^15.4.3",
+    "eslint": "^9.23.0",
+    "eslint-config-prettier": "^10.1.1",
+    "eslint-plugin-cypress": "^4.2.1",
+    "eslint-plugin-jsx-a11y": "^6.10.2",
+    "eslint-plugin-perfectionist": "^4.10.1",
+    "eslint-plugin-prettier": "~5.2.6",
+    "eslint-plugin-react": "^7.37.4",
+    "eslint-plugin-react-hooks": "^5.2.0",
+    "eslint-plugin-sonarjs": "^3.0.2",
+    "eslint-plugin-testing-library": "^7.1.1",
+    "eslint-plugin-xss": "^0.1.12",
+    "prettier": "~3.5.3",
+    "typescript-eslint": "^8.29.0",
+    "@typescript-eslint/eslint-plugin": "^8.29.0",
+    "@typescript-eslint/parser": "^8.29.0",
+    "@linode/eslint-plugin-cloud-manager": "^0.0.10",
+    "jiti": "^2.4.2"
   },
   "scripts": {
-    "lint": "eslint . --quiet --ext .js,.ts,.tsx",
+    "lint:all": "pnpm -r --parallel lint",
     "install:all": "pnpm install --frozen-lockfile",
     "build:sdk": "pnpm run --filter @linode/api-v4 build",
     "build:validation": "pnpm run --filter @linode/validation build",
@@ -46,7 +65,7 @@
     "package-versions": "pnpm run --filter @linode/scripts package-versions",
     "junit:summary": "pnpm run --filter @linode/scripts --silent junit:summary",
     "generate-tod": "pnpm run --filter @linode/scripts --silent generate-tod",
-    "clean": "rm -rf node_modules && rm -rf packages/manager/node_modules && rm -rf packages/api-v4/node_modules && rm -rf packages/validation/node_modules && rm -rf packages/api-v4/lib && rm -rf packages/validation/lib && rm -rf packages/ui/node_modules && rm -rf packages/utilities/node_modules",
+    "clean": "concurrently \"rm -rf node_modules\" \"pnpm -r exec rm -rf node_modules lib dist\" \"pnpm store prune\"",
     "prepare": "husky"
   },
   "resolutions": {

packages/api-v4/.eslintrc.json

@@ -1,5 +1,26 @@
-## [2025-04-08] - v0.137.0
+## [2025-04-22] - v0.138.0
+
+### Added:
+
+- `Linode Interfaces` to the `AccountCapability` type ([#11995](https://github.com/linode/manager/pull/11995))
+
+### Changed:
+
+- Add VPC field to `LinodeIPsResponseIPV4` ([#11976](https://github.com/linode/manager/pull/11976))
+
+### Tech Stories:
 
+- Eslint Overhaul ([#11941](https://github.com/linode/manager/pull/11941))
+
+### Upcoming Features:
+
+- Add schema validation for `edit alert` call in cloudpulse alerts ([#11868](https://github.com/linode/manager/pull/11868))
+- Fix the iam api for put method ([#11978](https://github.com/linode/manager/pull/11978))
+- fix the api to the right one for iam ([#11998](https://github.com/linode/manager/pull/11998))
+- Rename `DeleteLinodeConfigInterfacePayload` to `DeleteInterfaceIds` ([#12016](https://github.com/linode/manager/pull/12016))
+- fix the api to the right one for iam ([#12027](https://github.com/linode/manager/pull/12027))
+
+## [2025-04-08] - v0.137.0
 
 ### Added:
 
@@ -27,7 +48,6 @@
 
 ## [2025-03-25] - v0.136.0
 
-
 ### Added:
 
 - Add and update `/v4beta/nodebalancers` endpoints for NB-VPC Integration ([#11811](https://github.com/linode/manager/pull/11811))
@@ -73,7 +93,6 @@
 
 ## [2025-02-11] - v0.134.0
 
-
 ### Added:
 
 - Labels and Taints types and params ([#11528](https://github.com/linode/manager/pull/11528))
@@ -116,7 +135,6 @@
 - Add types for Quotas endpoints ([#11493](https://github.com/linode/manager/pull/11493))
 - Add Notification Channel related types to cloudpulse/alerts.ts ([#11511](https://github.com/linode/manager/pull/11511))
 
-
 ## [2025-01-14] - v0.132.0
 
 ### Added:
@@ -126,7 +144,7 @@
 
 ### Changed:
 
-- Type of `AlertDefinitionType` to `'system'|'user'`   ([#11346](https://github.com/linode/manager/pull/11346))
+- Type of `AlertDefinitionType` to `'system'|'user'` ([#11346](https://github.com/linode/manager/pull/11346))
 - Property names, and types of the CreateAlertDefinitionPayload and Alert interfaces ([#11392](https://github.com/linode/manager/pull/11392))
 - BaseDatabase total_disk_size_gb and used_disk_size_gb are always expected and used_disk_size_gb can be null ([#11426](https://github.com/linode/manager/pull/11426))
 - Renamed `AvailableMetrics` type to `MetricDefinition` ([#11433](https://github.com/linode/manager/pull/11433))

packages/api-v4/CHANGELOG.md

@@ -0,0 +1,7 @@
+import { defineConfig } from 'eslint/config';
+
+import { baseConfig } from '../manager/eslint.config.js';
+
+export default defineConfig({
+  extends: baseConfig,
+});

packages/api-v4/eslint.config.js

@@ -1,6 +1,6 @@
 {
   "name": "@linode/api-v4",
-  "version": "0.137.0",
+  "version": "0.138.0",
   "homepage": "https://github.com/linode/manager/tree/develop/packages/api-v4",
   "bugs": {
     "url": "https://github.com/linode/manager/issues"
@@ -58,9 +58,6 @@
   "devDependencies": {
     "axios-mock-adapter": "^1.22.0",
     "concurrently": "^9.0.1",
-    "eslint": "^6.8.0",
-    "eslint-plugin-sonarjs": "^0.5.0",
-    "prettier": "~2.2.1",
     "tsup": "^8.4.0"
   },
   "lint-staged": {
@@ -72,4 +69,4 @@
       "tsc -p tsconfig.json --noEmit true --emitDeclarationOnly false"
     ]
   }
-}
+}

packages/api-v4/package.json

@@ -70,6 +70,7 @@ export const accountCapabilities = [
   'Kubernetes',
   'Kubernetes Enterprise',
   'Linodes',
+  'Linode Interfaces',
   'LKE HA Control Planes',
   'LKE Network Access Control List (IP ACL)',
   'Machine Images',
@@ -87,7 +88,7 @@ export const accountCapabilities = [
   'VPCs',
 ] as const;
 
-export type AccountCapability = typeof accountCapabilities[number];
+export type AccountCapability = (typeof accountCapabilities)[number];
 
 export interface AccountAvailability {
   region: string; // will be slug of dc (matches id field of region object returned by API)
@@ -101,7 +102,8 @@ export const linodeInterfaceAccountSettings = [
   'linode_only',
 ] as const;
 
-export type LinodeInterfaceAccountSetting = typeof linodeInterfaceAccountSettings[number];
+export type LinodeInterfaceAccountSetting =
+  (typeof linodeInterfaceAccountSettings)[number];
 
 export interface AccountSettings {
   managed: boolean;
@@ -494,7 +496,7 @@ export const EventActionKeys = [
   'vpc_update',
 ] as const;
 
-export type EventAction = typeof EventActionKeys[number];
+export type EventAction = (typeof EventActionKeys)[number];
 
 export type EventStatus =
   | 'scheduled'

packages/api-v4/src/account/types.ts

@@ -1,4 +1,7 @@
-import { createAlertDefinitionSchema } from '@linode/validation';
+import {
+  createAlertDefinitionSchema,
+  editAlertDefinitionSchema,
+} from '@linode/validation';
 import Request, {
   setURL,
   setMethod,
@@ -54,16 +57,16 @@ export const getAlertDefinitionByServiceTypeAndId = (
 export const editAlertDefinition = (
   data: EditAlertDefinitionPayload,
   serviceType: string,
-  alertId: number
+  alertId: number,
 ) =>
   Request<Alert>(
     setURL(
       `${API_ROOT}/monitor/services/${encodeURIComponent(
-        serviceType
-      )}/alert-definitions/${encodeURIComponent(alertId)}`
+        serviceType,
+      )}/alert-definitions/${encodeURIComponent(alertId)}`,
     ),
     setMethod('PUT'),
-    setData(data)
+    setData(data, editAlertDefinitionSchema),
   );
 export const getNotificationChannels = (params?: Params, filters?: Filter) =>
   Request<ResourcePage<NotificationChannel>>(