test [M3-9926]: fix for misc test failures (#12198)

* try to fix broken devcloud tests

* fix file upload

* fix multipleRegions tag

* remove test skip

* remove multipleRegions filter on test

* Added changeset: Fix for misc test failures

Author: dmcintyr-akamai

packages/manager/.changeset/pr-12198-tests-1747230624301.md

@@ -0,0 +1,5 @@
+---
+"@linode/manager": Tests
+---
+
+Fix for misc test failures ([#12198](https://github.com/linode/manager/pull/12198))

packages/manager/cypress/e2e/core/firewalls/migrate-linode-with-firewall.spec.ts

@@ -128,7 +128,9 @@ describe('Migrate Linode With Firewall', () => {
           'be.visible'
         );
         ui.regionSelect.find().click();
-        ui.regionSelect.findItemByRegionLabel(mockSingapore.label).click();
+        ui.regionSelect
+          .findItemByRegionLabel(mockSingapore.label, mockRegions)
+          .click();
 
         ui.button
           .findByTitle('Enter Migration Queue')
@@ -143,9 +145,8 @@ describe('Migrate Linode With Firewall', () => {
   /*
    * - Uses real API data to create a Firewall, attach a Linode to it, then migrate the Linode.
    */
-  it.skip('migrates linode with firewall - real data', () => {
+  it('migrates linode with firewall - real data', () => {
     cy.tag('method:e2e', 'purpose:dcTesting', 'env:multipleRegions');
-
     // Execute the body of the test inside Cypress's command queue to ensure
     // that logic that requires multiple regions only executes after tags are evaluated.
     cy.defer(async () => {}).then(() => {

packages/manager/cypress/e2e/core/nodebalancers/smoke-create-nodebal.spec.ts

@@ -172,24 +172,26 @@ describe('create NodeBalancer', () => {
    */
   it('shows DC-specific pricing information when creating a NodeBalancer', () => {
     // test fails in environments w/ only one region
-    cy.addTag('env:multipleRegions');
-    const initialRegion = getRegionById('us-west');
-    const linodePayload = {
-      // NodeBalancers require Linodes with private IPs.
-      private_ip: true,
-      region: initialRegion.id,
-    };
-    cy.defer(() => createTestLinode(linodePayload)).then((linode) => {
-      const nodeBal = nodeBalancerFactory.build({
-        ipv4: linode.ipv4[1],
-        label: randomLabel(),
+    cy.tag('env:multipleRegions');
+    cy.defer(async () => {}).then(() => {
+      const initialRegion = getRegionById('us-west');
+      const linodePayload = {
+        // NodeBalancers require Linodes with private IPs.
+        private_ip: true,
         region: initialRegion.id,
+      };
+      cy.defer(() => createTestLinode(linodePayload)).then((linode) => {
+        const nodeBal = nodeBalancerFactory.build({
+          ipv4: linode.ipv4[1],
+          label: randomLabel(),
+          region: initialRegion.id,
+        });
+
+        // catch request
+        interceptCreateNodeBalancer().as('createNodeBalancer');
+
+        createNodeBalancerWithUI(nodeBal, true);
       });
-
-      // catch request
-      interceptCreateNodeBalancer().as('createNodeBalancer');
-
-      createNodeBalancerWithUI(nodeBal, true);
     });
   });
 });

packages/manager/cypress/e2e/core/objectStorage/access-key.e2e.spec.ts

@@ -12,6 +12,7 @@ import {
 } from 'support/intercepts/object-storage';
 import { ui } from 'support/ui';
 import { cleanUp } from 'support/util/cleanup';
+import { chooseCluster } from 'support/util/clusters';
 import { randomLabel } from 'support/util/random';
 
 import { accountFactory } from 'src/factories';
@@ -120,9 +121,9 @@ describe('object storage access key end-to-end tests', () => {
    */
   it('can create an access key with limited access - e2e', () => {
     const bucketLabel = randomLabel();
-    const bucketCluster = 'us-east-1';
+    const bucketClusterObj = chooseCluster();
     const bucketRequest = createObjectStorageBucketFactoryLegacy.build({
-      cluster: bucketCluster,
+      cluster: bucketClusterObj.id,
       label: bucketLabel,
       // Default factory sets `cluster` and `region`, but API does not accept `region` yet.
       region: undefined,
@@ -208,7 +209,7 @@ describe('object storage access key end-to-end tests', () => {
             });
         });
 
-        const permissionLabel = `This token has read-only access for ${bucketCluster}-${bucketLabel}`;
+        const permissionLabel = `This token has read-only access for ${bucketClusterObj.id}-${bucketLabel}`;
         cy.findByLabelText(permissionLabel).should('be.visible');
       });
     });

packages/manager/cypress/e2e/core/objectStorageMulticluster/object-storage-objects-multicluster.spec.ts

@@ -5,6 +5,7 @@ import { mockAppendFeatureFlags } from 'support/intercepts/feature-flags';
 import { interceptUploadBucketObjectS3 } from 'support/intercepts/object-storage';
 import { ui } from 'support/ui';
 import { cleanUp } from 'support/util/cleanup';
+import { chooseCluster } from 'support/util/clusters';
 import { randomLabel } from 'support/util/random';
 
 import { createObjectStorageBucketFactoryGen1 } from 'src/factories';
@@ -131,8 +132,8 @@ describe('Object Storage Multicluster objects', () => {
    */
   it('can upload, access, and delete objects', () => {
     const bucketLabel = randomLabel();
-    const bucketCluster = 'us-southeast-1';
-    const bucketRegionId = 'us-southeast';
+    const bucketClusterObj = chooseCluster();
+    const bucketRegionId = bucketClusterObj.region;
     const bucketPage = `/object-storage/buckets/${bucketRegionId}/${bucketLabel}/objects`;
     const bucketFolderName = randomLabel();
 
@@ -147,7 +148,7 @@ describe('Object Storage Multicluster objects', () => {
     ).then(() => {
       interceptUploadBucketObjectS3(
         bucketLabel,
-        bucketCluster,
+        bucketClusterObj.domain,
         bucketFiles[0].name
       ).as('uploadObject');
 
@@ -200,7 +201,7 @@ describe('Object Storage Multicluster objects', () => {
       cy.findByText(emptyFolderMessage).should('be.visible');
       interceptUploadBucketObjectS3(
         bucketLabel,
-        bucketCluster,
+        bucketClusterObj.domain,
         `${bucketFolderName}/${bucketFiles[1].name}`
       ).as('uploadObject');
       uploadFile(bucketFiles[1].path, bucketFiles[1].name);

packages/manager/cypress/support/intercepts/object-storage.ts

@@ -296,20 +296,17 @@ export const mockUploadBucketObject = (
  * Intercepts S3 PUT request to upload bucket object.
  *
  * @param label - Object storage bucket label.
- * @param cluster - Object storage bucket cluster.
+ * @param domain - Object storage bucket cluster.
  * @param filename - Object filename.
  *
  * @returns Cypress chainable.
  */
 export const interceptUploadBucketObjectS3 = (
   label: string,
-  cluster: string,
+  domain: string,
   filename: string
 ): Cypress.Chainable<null> => {
-  return cy.intercept(
-    'PUT',
-    `https://${cluster}.linodeobjects.com/${label}/${filename}*`
-  );
+  return cy.intercept('PUT', `https://${domain}/${label}/${filename}*`);
 };
 
 /**